HttpAuth

Complexity

Total Complexity

10

Size/Duplication

Total Lines	57
Duplicated Lines	35.09 %

Coupling/Cohesion

Components	0
Dependencies	11

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	authenticate()	0	6	2
A	createSession()	12	12	1
A	delete()	8	8	2
A	current()	0	4	2
A	getBasicAuthMember()	0	7	3

<?php

/**
 * Authentication mechanism using a BasicAuth request.
 *
 * @author Andre Lohmann <lohmann.andre@gmail.com>
 */
class HttpAuth extends Object implements IAuth {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    public static function authenticate($email, $password) {
        $authenticator = Injector::inst()->get('ApiMemberAuthenticator');
        if($user = $authenticator->authenticate(['Password' => $password, 'Email' => $email])) {
	        return self::createSession($user);
        }
    }

	/**
	 * @param Member $user
	 * @return ApiSession
	 */
	public static function createSession($user) {

This method seems to be duplicated in your project.

		$user->logIn();
		/** @var Member $user */
		$user = DataObject::get(Config::inst()->get('BaseRestController', 'Owner'))->byID($user->ID);

		// create session
		$session = ApiSession::create();
		$session->User = $user;
		$session->Token = AuthFactory::generate_token($user);

		return $session;
	}

	public static function delete($request) {

This method seems to be duplicated in your project.

        $owner = self::current($request);
        if(!$owner) {
            throw new RestUserException("No session found", 404, 404);
        }
        $owner->logOut();
        return true;
    }


        /**
         * @param SS_HTTPRequest $request
         * @return Member

Should the return type not be Member|null?

         */
        public static function current($request) {
            $member = self::getBasicAuthMember();
            return ($member instanceof Member) ? DataObject::get(Config::inst()->get('BaseRestController', 'Owner'))->byID($member->ID) : null;
        }
        
        /**
         * @return Member
         */
        protected static function getBasicAuthMember(){
            $realm = Config::inst()->get('HttpAuth', 'Realm');
            $permissionCode = Config::inst()->get('HttpAuth', 'PermissionCode');
            $isRunningTests = (class_exists('SapphireTest', false) && SapphireTest::is_running_test());
            $tryUsingSessionLogin = $isRunningTests || Config::inst()->get('HttpAuth', 'TryUsingSessionLogin');
            return BasicAuth::requireLogin($realm, $permissionCode, $tryUsingSessionLogin);
        }

}