HtmlSerializer::recursive() - Code Metrics - Inspection of "New release 0.7.1" - notthatbad/silverstripe-rest-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#33)

by Christian

created 2016-05-25 19:12 UTC

HtmlSerializer::recursive() A

↳ Parent: HtmlSerializer

Complexity

Conditions	4
Paths	2

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	0
loc	14
rs	9.2
cc	4
eloc	10
nc	2
nop	2

<?php

/**
 * Serializer for html.
 * @author Christian Blank <[email protected]>
 */
class HtmlSerializer extends ViewableData implements IRestSerializer {
namespace YourVendor;

class YourClass { }

    /**
     * @config
     */
    private static $is_active = true;


    /**
     * The content type
     * @var string
     */
    private $contentType = "text/html";

    /**
     * The given data will be serialized into an html string using a Silverstripe template.
     *
     * @param array $data
     * @return string an html string

     */
    public function serialize($data) {
        $list = $this->recursive($data, 1);
        return $this->renderWith(['Result', 'Controller'], ['Data' => ArrayList::create($list)]);
    }

    public function contentType() {
        return $this->contentType;
    }

    private function recursive($data, $level) {
        $list = [];
        if(is_array($data)) {
            foreach ($data as $key => $value) {
                if(is_array($value)) {
                    $list[] = ArrayData::create(['Key' => $key, 'Value' => '', 'Heading' => true, 'Level' => $level]);
                    $list = array_merge($list, $this->recursive($value, $level+1));
                } else {
                    $list[] = ArrayData::create(['Key' => $key, 'Value' => $value, 'Level' => $level]);
                }
            }
        }
        return $list;
    }

    /**
     * Indicates if the serializer is active.
     * Serializers can be deactivated to use another implementation for the same mime type.
     *
     * @return boolean

     */
    public function active() {
        return $this->config()->get('is_active');
    }
}


1			<?php
2
3			/**
4			* Serializer for html.
5			* @author Christian Blank <[email protected]>
6			*/
7			class HtmlSerializer extends ViewableData implements IRestSerializer {
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-18 07:01 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8
9			/**
10			* @config
11			*/
12			private static $is_active = true;
			0 ignored issues – show Unused Code introduced 2016-05-25 18:57 UTC by Report Bug Copy Issue Report The property `$is_active` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13
14			/**
15			* The content type
16			* @var string
17			*/
18			private $contentType = "text/html";
19
20			/**
21			* The given data will be serialized into an html string using a Silverstripe template.
22			*
23			* @param array $data
24			* @return string an html string
			0 ignored issues – show Documentation introduced 2016-05-18 07:01 UTC by Report Bug Copy Issue Report Should the return type not be `HTMLText`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
25			*/
26			public function serialize($data) {
27			$list = $this->recursive($data, 1);
28			return $this->renderWith(['Result', 'Controller'], ['Data' => ArrayList::create($list)]);
29			}
30
31			public function contentType() {
32			return $this->contentType;
33			}
34
35			private function recursive($data, $level) {
36			$list = [];
37			if(is_array($data)) {
38			foreach ($data as $key => $value) {
39			if(is_array($value)) {
40			$list[] = ArrayData::create(['Key' => $key, 'Value' => '', 'Heading' => true, 'Level' => $level]);
41			$list = array_merge($list, $this->recursive($value, $level+1));
42			} else {
43			$list[] = ArrayData::create(['Key' => $key, 'Value' => $value, 'Level' => $level]);
44			}
45			}
46			}
47			return $list;
48			}
49
50			/**
51			* Indicates if the serializer is active.
52			* Serializers can be deactivated to use another implementation for the same mime type.
53			*
54			* @return boolean
			0 ignored issues – show Documentation introduced 2016-05-25 18:57 UTC by Report Bug Copy Issue Report Should the return type not be `array\|integer\|double\|string\|boolean`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
55			*/
56			public function active() {
57			return $this->config()->get('is_active');
58			}
59			}
60

notthatbad / silverstripe-rest-api

Pull Request — master (#33)

HtmlSerializer::recursive() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like