XmlSerializer

Complexity

Total Complexity

7

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	2
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	serialize()	0	5	1
A	contentType()	0	3	1
A	toXml()	0	13	4
A	active()	0	3	1

<?php

/**
 * Serializer for xml.
 * @author Christian Blank <c.blank@notthatbad.net>
 */
class XmlSerializer extends Object implements IRestSerializer {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @config
     */
    private static $is_active = true;

The property $is_active is not used and could be removed.

    
    /**
     * The content type.
     * @var string
     */
    private $contentType = "application/xml";

    /**
     * Serializes the given data into a xml string.
     *
     * @param array $data the data that should be serialized
     * @return string a xml formatted string

Should the return type not be string|false?

     */
    public function serialize($data) {
        $xml = new SimpleXMLElement('<result/>');
        $this->toXml($xml, $data);
        return $xml->asXML();
    }

    public function contentType() {
        return $this->contentType;
    }

    private function toXml(SimpleXMLElement $object, array $data) {
        foreach( $data as $key => $value ) {
            if(is_array($value) ) {
                if( is_numeric($key) ){
                    $key = 'item'.$key; //dealing with <0/>..<n/> issues
                }
                $subnode = $object->addChild($key);
                $this->toXml($subnode, $value);
            } else {
                $object->addChild("$key",htmlspecialchars("$value"));
            }
        }
    }

    /**
     * Indicates if the serializer is active.
     * Serializers can be deactivated to use another implementation for the same mime type.
     *
     * @return boolean

Should the return type not be array|integer|double|string|boolean?

     */
    public function active() {
        return $this->config()->get('is_active');
    }
}