RestValidatorHelperTest - Code Metrics - Inspection of "V1" - notthatbad/silverstripe-rest-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#37)

by Christian

created 2016-08-19 22:55 UTC

RestValidatorHelperTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	198
Duplicated Lines	23.74 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	9
c	0
b	0
f	0
lcom	0
cbo	3
dl	47
loc	198
rs	10

7 Methods

Rating	Name	Duplication	Size	Complexity
B	testIsUrl()	0	91	3
A	testValidateCountryCode()	11	11	1
A	testValidateEmail()	12	12	1
A	testValidateUrl()	12	12	1
A	testValidateString()	0	23	1
B	testValidateInt()	0	24	1
A	testValidateDatetime()	12	12	1

How to fix Duplicated Code

<?php

namespace Ntb\RestAPI;

use SapphireTest;

/**
 * Tests for the rest validation helper.
 * @todo: add more tests
 * @author Christian Blank <[email protected]>
 */
class RestValidatorHelperTest extends SapphireTest {

    public function testIsUrl() {
        $correctUrls = [
            'https://example.com',
            'http://example.com',
            'http://foo.com/blah_blah',
            'http://foo.com/blah_blah/',
            'http://foo.com/blah_blah_(wikipedia)',
            'http://foo.com/blah_blah_(wikipedia)_(again)',
            'http://www.example.com/wpstyle/?p=364',
            'https://www.example.com/foo/?bar=baz&inga=42&quux',
            'http://df.ws/123',
            'http://userid:[email protected]:8080',
            'http://userid:[email protected]:8080/',
            'http://[email protected]',
            'http://[email protected]/',
            'http://[email protected]:8080',
            'http://[email protected]:8080/',
            'http://userid:[email protected]',
            'http://userid:[email protected]/',
            'http://142.42.1.1/',
            'http://142.42.1.1:8080/',
            'http://fg.ws/',
            'http://fg.ws',
            'http://foo.com/blah_(wikipedia)#cite-1',
            'http://foo.com/blah_(wikipedia)_blah#cite-1',
            'http://foo.com/unicode_(✪)_in_parens',
            'http://foo.com/(something)?after=parens',
            'http://☺.damowmow.com/',
            'http://code.google.com/events/#&product=browser',
            'http://j.mp',
            'ftp://foo.bar/baz',
            'http://foo.bar/?q=Test%20URL-encoded%20stuff',
            'http://مثال.إختبار',
            'http://例子.测试',
            'http://उदाहरण.परीक्',
            "http://-.~_!$&'()*+,;=:%40:80%2f::::::@example.com",
            'http://1337.net',
            'http://a.b-c.de',
            'http://223.255.255.254'
        ];

        $incorrectUrls = [
            'http://',
            'http://.',
            'http://..',
            'http://../',
            'http://?',
            'http://??',
            'http://??/',
            'http://#',
            'http://##',
            'http://##/',
            'http://foo.bar?q=Spaces should be encoded',
            '//',
            '//a',
            '///a',
            '///',
            'http:///a',
            'foo.com',
            'rdar://1234',
            'h://test',
            'http:// shouldfail.com',
            ':// should fail',
            'http://foo.bar/foo(bar)baz quux',
            'ftps://foo.bar/',
            'http://-error-.invalid/',
            'http://-a.b.co',
            'http://a.b-.co',
            'http://0.0.0.0',
            'http://10.1.1.0',
            'http://10.1.1.255',
            'http://224.1.1.1',
            'http://1.1.1.1.1',
            'http://123.123.123',
            'http://3628126748',
            'http://.www.foo.bar/',
            'http://.www.foo.bar./',
            'http://10.1.1.1',
            'http://10.1.1.254'
        ];

        foreach($correctUrls as $url) {
            $t = $url;
            $this->assertTrue(RestValidatorHelper::is_url($url), "$t should be valid");

        }

        foreach($incorrectUrls as $url) {
            $t = $url;
            $this->assertFalse(RestValidatorHelper::is_url($url), "$t should be invalid");

        }
    }

    public function testValidateCountryCode() {

        $this->assertEquals('US', RestValidatorHelper::validate_country_code(['cc' => 'US'], 'cc'));

        $this->assertEquals(null, RestValidatorHelper::validate_country_code([], 'cc', ['required' => false]));


        TestHelper::assertException(function() {
            RestValidatorHelper::validate_country_code(['cc' => 'FOO'], 'cc');
        }, 'ValidationException');
        TestHelper::assertException(function() {
            RestValidatorHelper::validate_country_code([], 'cc');
        }, 'ValidationException');
    }

    public function testValidateEmail() {

        $this->assertEquals('[email protected]', RestValidatorHelper::validate_email(['mail' => '[email protected]'], 'mail'));


        TestHelper::assertException(function() {
            RestValidatorHelper::validate_email(['mail' => 'FOO'], 'mail');
        }, 'ValidationException');

        $this->assertEquals(null, RestValidatorHelper::validate_email([], 'mail', ['required' => false]));

        TestHelper::assertException(function() {
            RestValidatorHelper::validate_email([], 'mail');
        }, 'ValidationException');
    }

    public function testValidateUrl() {

        $this->assertEquals('http://test.com', RestValidatorHelper::validate_url(['url' => 'http://test.com'], 'url'));


        TestHelper::assertException(function() {
            RestValidatorHelper::validate_url(['url' => 'FOO'], 'url');
        }, 'ValidationException');

        $this->assertEquals(null, RestValidatorHelper::validate_url([], 'url', ['required' => false]));

        TestHelper::assertException(function() {
            RestValidatorHelper::validate_url([], 'url');
        }, 'ValidationException');
    }


    public function testValidateString() {
        $this->assertEquals('foo bar', RestValidatorHelper::validate_string(['str' => 'foo bar'], 'str'));

        $this->assertEquals(null, RestValidatorHelper::validate_string([], 'str', ['required' => false]));


        TestHelper::assertException(function() {
            RestValidatorHelper::validate_string([], 'str');
        }, 'ValidationException');

        TestHelper::assertException(function() {
            RestValidatorHelper::validate_string(['str' => 15], 'str');
        }, 'ValidationException');

        TestHelper::assertException(function() {
            RestValidatorHelper::validate_string(['str' => 'foo bar'], 'str', ['max' => 4]);
        }, 'ValidationException');
        $this->assertEquals('foo', RestValidatorHelper::validate_string(['str' => 'foo'], 'str'), ['max' => 4]);



        TestHelper::assertException(function() {
            RestValidatorHelper::validate_string(['str' => 'fo'], 'str', ['min' => 3, 'max' => 4]);
        }, 'ValidationException');
        $this->assertEquals('foo', RestValidatorHelper::validate_string(['str' => 'foo'], 'str', ['min' => 2, 'max' => 4]));

    }


    public function testValidateInt() {
        $this->assertEquals(5, RestValidatorHelper::validate_int(['int' => 5], 'int'));

        $this->assertEquals(null, RestValidatorHelper::validate_int([], 'int', ['required' => false]));


        TestHelper::assertException(function() {
            RestValidatorHelper::validate_int([], 'int');
        }, 'ValidationException');

        TestHelper::assertException(function() {
            RestValidatorHelper::validate_int(['int' => 'foo bar'], 'int');
        }, 'ValidationException');

        TestHelper::assertException(function() {
            RestValidatorHelper::validate_int(['int' => 5], 'int', ['max' => 4]);
        }, 'ValidationException');
        $this->assertEquals(-5, RestValidatorHelper::validate_int(['int' => -5], 'int', ['max' => 0]));



        TestHelper::assertException(function() {
            RestValidatorHelper::validate_int(['int' => 1], 'int', ['min' => 3, 'max' => 4]);
        }, 'ValidationException');
        $this->assertEquals(2, RestValidatorHelper::validate_int(['int' => 2], 'int', ['min' => 2, 'max' => 4]));

        $this->assertEquals(4, RestValidatorHelper::validate_int(['int' => 4], 'int', ['min' => 2, 'max' => 4]));

    }


    public function testValidateDatetime() {

        $this->assertEquals('2015-08-07 12:13:14', RestValidatorHelper::validate_datetime(['date' => '2015-08-07 12:13:14'], 'date'));

        $this->assertEquals(null, RestValidatorHelper::validate_datetime([], 'date', ['required' => false]));


        TestHelper::assertException(function() {
            RestValidatorHelper::validate_datetime([], 'date');
        }, 'ValidationException');

        TestHelper::assertException(function() {
            RestValidatorHelper::validate_datetime(['date' => 'error'], 'date');
        }, 'ValidationException');
    }

}


1		<?php
2
3		namespace Ntb\RestAPI;
4
5		use SapphireTest;
6
7		/**
8		* Tests for the rest validation helper.
9		* @todo: add more tests
10		* @author Christian Blank <[email protected]>
11		*/
12		class RestValidatorHelperTest extends SapphireTest {
13
14		public function testIsUrl() {
15		$correctUrls = [
16		'https://example.com',
17		'http://example.com',
18		'http://foo.com/blah_blah',
19		'http://foo.com/blah_blah/',
20		'http://foo.com/blah_blah_(wikipedia)',
21		'http://foo.com/blah_blah_(wikipedia)_(again)',
22		'http://www.example.com/wpstyle/?p=364',
23		'https://www.example.com/foo/?bar=baz&inga=42&quux',
24		'http://df.ws/123',
25		'http://userid:[email protected]:8080',
26		'http://userid:[email protected]:8080/',
27		'http://[email protected]',
28		'http://[email protected]/',
29		'http://[email protected]:8080',
30		'http://[email protected]:8080/',
31		'http://userid:[email protected]',
32		'http://userid:[email protected]/',
33		'http://142.42.1.1/',
34		'http://142.42.1.1:8080/',
35		'http://fg.ws/',
36		'http://fg.ws',
37		'http://foo.com/blah_(wikipedia)#cite-1',
38		'http://foo.com/blah_(wikipedia)_blah#cite-1',
39		'http://foo.com/unicode_(✪)_in_parens',
40		'http://foo.com/(something)?after=parens',
41		'http://☺.damowmow.com/',
42		'http://code.google.com/events/#&product=browser',
43		'http://j.mp',
44		'ftp://foo.bar/baz',
45		'http://foo.bar/?q=Test%20URL-encoded%20stuff',
46		'http://مثال.إختبار',
47		'http://例子.测试',
48		'http://उदाहरण.परीक्',
49		"http://-.~_!$&'()*+,;=:%40:80%2f::::::@example.com",
50		'http://1337.net',
51		'http://a.b-c.de',
52		'http://223.255.255.254'
53		];
54
55		$incorrectUrls = [
56		'http://',
57		'http://.',
58		'http://..',
59		'http://../',
60		'http://?',
61		'http://??',
62		'http://??/',
63		'http://#',
64		'http://##',
65		'http://##/',
66		'http://foo.bar?q=Spaces should be encoded',
67		'//',
68		'//a',
69		'///a',
70		'///',
71		'http:///a',
72		'foo.com',
73		'rdar://1234',
74		'h://test',
75		'http:// shouldfail.com',
76		':// should fail',
77		'http://foo.bar/foo(bar)baz quux',
78		'ftps://foo.bar/',
79		'http://-error-.invalid/',
80		'http://-a.b.co',
81		'http://a.b-.co',
82		'http://0.0.0.0',
83		'http://10.1.1.0',
84		'http://10.1.1.255',
85		'http://224.1.1.1',
86		'http://1.1.1.1.1',
87		'http://123.123.123',
88		'http://3628126748',
89		'http://.www.foo.bar/',
90		'http://.www.foo.bar./',
91		'http://10.1.1.1',
92		'http://10.1.1.254'
93		];
94
95		foreach($correctUrls as $url) {
96		$t = $url;
97		$this->assertTrue(RestValidatorHelper::is_url($url), "$t should be valid");
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
98		}
99
100		foreach($incorrectUrls as $url) {
101		$t = $url;
102		$this->assertFalse(RestValidatorHelper::is_url($url), "$t should be invalid");
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
103		}
104		}
105
106	View Code Duplication	public function testValidateCountryCode() {
		0 ignored issues – show Duplication introduced 2016-05-18 07:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		$this->assertEquals('US', RestValidatorHelper::validate_country_code(['cc' => 'US'], 'cc'));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
108		$this->assertEquals(null, RestValidatorHelper::validate_country_code([], 'cc', ['required' => false]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
109
110		TestHelper::assertException(function() {
111		RestValidatorHelper::validate_country_code(['cc' => 'FOO'], 'cc');
112		}, 'ValidationException');
113		TestHelper::assertException(function() {
114		RestValidatorHelper::validate_country_code([], 'cc');
115		}, 'ValidationException');
116		}
117
118	View Code Duplication	public function testValidateEmail() {
		0 ignored issues – show Duplication introduced 2016-05-18 07:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		$this->assertEquals('[email protected]', RestValidatorHelper::validate_email(['mail' => '[email protected]'], 'mail'));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
120
121		TestHelper::assertException(function() {
122		RestValidatorHelper::validate_email(['mail' => 'FOO'], 'mail');
123		}, 'ValidationException');
124
125		$this->assertEquals(null, RestValidatorHelper::validate_email([], 'mail', ['required' => false]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
126		TestHelper::assertException(function() {
127		RestValidatorHelper::validate_email([], 'mail');
128		}, 'ValidationException');
129		}
130
131	View Code Duplication	public function testValidateUrl() {
		0 ignored issues – show Duplication introduced 2016-05-18 07:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
132		$this->assertEquals('http://test.com', RestValidatorHelper::validate_url(['url' => 'http://test.com'], 'url'));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
133
134		TestHelper::assertException(function() {
135		RestValidatorHelper::validate_url(['url' => 'FOO'], 'url');
136		}, 'ValidationException');
137
138		$this->assertEquals(null, RestValidatorHelper::validate_url([], 'url', ['required' => false]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
139		TestHelper::assertException(function() {
140		RestValidatorHelper::validate_url([], 'url');
141		}, 'ValidationException');
142		}
143
144
145		public function testValidateString() {
146		$this->assertEquals('foo bar', RestValidatorHelper::validate_string(['str' => 'foo bar'], 'str'));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
147		$this->assertEquals(null, RestValidatorHelper::validate_string([], 'str', ['required' => false]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
148
149		TestHelper::assertException(function() {
150		RestValidatorHelper::validate_string([], 'str');
151		}, 'ValidationException');
152
153		TestHelper::assertException(function() {
154		RestValidatorHelper::validate_string(['str' => 15], 'str');
155		}, 'ValidationException');
156
157		TestHelper::assertException(function() {
158		RestValidatorHelper::validate_string(['str' => 'foo bar'], 'str', ['max' => 4]);
159		}, 'ValidationException');
160		$this->assertEquals('foo', RestValidatorHelper::validate_string(['str' => 'foo'], 'str'), ['max' => 4]);
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
161
162
163		TestHelper::assertException(function() {
164		RestValidatorHelper::validate_string(['str' => 'fo'], 'str', ['min' => 3, 'max' => 4]);
165		}, 'ValidationException');
166		$this->assertEquals('foo', RestValidatorHelper::validate_string(['str' => 'foo'], 'str', ['min' => 2, 'max' => 4]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
167		}
168
169
170		public function testValidateInt() {
171		$this->assertEquals(5, RestValidatorHelper::validate_int(['int' => 5], 'int'));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
172		$this->assertEquals(null, RestValidatorHelper::validate_int([], 'int', ['required' => false]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
173
174		TestHelper::assertException(function() {
175		RestValidatorHelper::validate_int([], 'int');
176		}, 'ValidationException');
177
178		TestHelper::assertException(function() {
179		RestValidatorHelper::validate_int(['int' => 'foo bar'], 'int');
180		}, 'ValidationException');
181
182		TestHelper::assertException(function() {
183		RestValidatorHelper::validate_int(['int' => 5], 'int', ['max' => 4]);
184		}, 'ValidationException');
185		$this->assertEquals(-5, RestValidatorHelper::validate_int(['int' => -5], 'int', ['max' => 0]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
186
187
188		TestHelper::assertException(function() {
189		RestValidatorHelper::validate_int(['int' => 1], 'int', ['min' => 3, 'max' => 4]);
190		}, 'ValidationException');
191		$this->assertEquals(2, RestValidatorHelper::validate_int(['int' => 2], 'int', ['min' => 2, 'max' => 4]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
192		$this->assertEquals(4, RestValidatorHelper::validate_int(['int' => 4], 'int', ['min' => 2, 'max' => 4]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
193		}
194
195
196	View Code Duplication	public function testValidateDatetime() {
		0 ignored issues – show Duplication introduced 2016-05-18 07:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
197		$this->assertEquals('2015-08-07 12:13:14', RestValidatorHelper::validate_datetime(['date' => '2015-08-07 12:13:14'], 'date'));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
198		$this->assertEquals(null, RestValidatorHelper::validate_datetime([], 'date', ['required' => false]));
		0 ignored issues – show Bug introduced 2016-08-19 22:57 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<Ntb\RestAPI\RestValidatorHelperTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
199
200		TestHelper::assertException(function() {
201		RestValidatorHelper::validate_datetime([], 'date');
202		}, 'ValidationException');
203
204		TestHelper::assertException(function() {
205		RestValidatorHelper::validate_datetime(['date' => 'error'], 'date');
206		}, 'ValidationException');
207		}
208
209		}
210

notthatbad / silverstripe-rest-api

Pull Request — develop (#37)

RestValidatorHelperTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like