Ntb\RestAPI\NestedResourceRestControllerTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	30
Duplicated Lines	46.67 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testControllerGET()	7	7	1
A	testNotProvidedID()	0	3	1
A	testControllerDELETE()	7	7	1

<?php

namespace Ntb\RestAPI;

/**
 * @author Christian Blank <c.blank@notthatbad.net>
 */
class NestedResourceRestControllerTest extends RestTest {

    public function setUp() {
        parent::setUp();
        \Config::inst()->update('Director', 'rules', [
            'v/1/RestTestRoute/$ID/Nested/$OtherID' => 'Ntb\RestAPI\NestedTestController',
        ]);
    }

    public function testControllerGET() {

This method seems to be duplicated in your project.

        $id = 'Foo';
        $result = $this->makeApiRequest("RestTestRoute/$id/Nested");
        $this->assertTrue(array_key_exists('message', $result));

The method assertTrue() does not seem to exist on object<Ntb\RestAPI\NestedResourceRestControllerTest>.

        $this->assertEquals('Test GET', $result['message']);

The method assertEquals() does not seem to exist on object<Ntb\RestAPI\NestedResourceRestControllerTest>.

        $this->assertEquals($id, $result['resource']['id']);

The method assertEquals() does not seem to exist on object<Ntb\RestAPI\NestedResourceRestControllerTest>.

    }

    public function testNotProvidedID() {
        $this->makeApiRequest("RestTestRoute//Nested", ['code' => 404]);
    }


    public function testControllerDELETE() {

This method seems to be duplicated in your project.

        $id = 'Bar';
        $result = $this->makeApiRequest("RestTestRoute/$id/Nested", ['method' => 'DELETE']);
        $this->assertTrue(array_key_exists('message', $result));

The method assertTrue() does not seem to exist on object<Ntb\RestAPI\NestedResourceRestControllerTest>.

        $this->assertEquals('Test DELETE', $result['message']);

The method assertEquals() does not seem to exist on object<Ntb\RestAPI\NestedResourceRestControllerTest>.

        $this->assertEquals($id, $result['resource']['id']);

The method assertEquals() does not seem to exist on object<Ntb\RestAPI\NestedResourceRestControllerTest>.

    }
}

class NestedTestController extends NestedResourceRestController implements \TestOnly {

    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

        'delete' => true,
        'get' => true
    ];

    public function get($request, $resource) {

The parameter $request is not used and could be removed.

        return ['message' => 'Test GET', 'resource' => $resource];
    }

    public function delete($request, $resource) {

The parameter $request is not used and could be removed.

        return ['message' => 'Test DELETE', 'resource' => $resource];
    }

    protected function getRootResource($id) {
        return ['id' => $id];
    }
}