LazyHandler::__construct() - Code Metrics - Inspection of "Add support for lazy request handlers" - northwoods/lazy-middleware - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by Woody

created 2018-11-06 02:50 UTC

LazyHandler::__construct() A

↳ Parent: LazyHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	2
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Northwoods\Middleware;

use InvalidArgumentException;
use Psr\Container\ContainerInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;

class LazyHandler implements RequestHandlerInterface
{
    /** @var ContainerInterface */
    private $container;


    /** @var string */
    private $handler;


    public function __construct(ContainerInterface $container, string $handler)

    {
        if (! is_subclass_of($handler, RequestHandlerInterface::class, true)) {
            throw new InvalidArgumentException(
                sprintf('%s does not implement %s', $handler, RequestHandlerInterface::class)
            );
        }

        $this->container = $container;
        $this->handler = $handler;
    }


    // RequestHandlerInterface
    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        return $this->resolve()->handle($request);
    }


    private function resolve(): RequestHandlerInterface
    {
        return $this->container->get($this->handler);
    }

}


1		<?php
2		declare(strict_types=1);
3
4		namespace Northwoods\Middleware;
5
6		use InvalidArgumentException;
7		use Psr\Container\ContainerInterface;
8		use Psr\Http\Message\ResponseInterface;
9		use Psr\Http\Message\ServerRequestInterface;
10		use Psr\Http\Server\RequestHandlerInterface;
11
12		class LazyHandler implements RequestHandlerInterface
13		{
14		/** @var ContainerInterface */
15		private $container;
		0 ignored issues – show Coding Style introduced 2018-10-31 13:08 UTC by Report Bug Copy Issue Report Private member variable "container" must contain a leading underscore Loading history... Coding Style introduced 2018-10-31 13:08 UTC by Report Bug Copy Issue Report Expected 1 blank line before member var; 0 found Loading history...
16
17		/** @var string */
18		private $handler;
		0 ignored issues – show Coding Style introduced 2018-11-06 02:52 UTC by Report Bug Copy Issue Report Private member variable "handler" must contain a leading underscore Loading history...
19
20	3	public function __construct(ContainerInterface $container, string $handler)
		0 ignored issues – show Coding Style introduced 2018-11-06 02:52 UTC by Report Bug Copy Issue Report Expected 2 blank lines before function; 1 found Loading history...
21		{
22	3	if (! is_subclass_of($handler, RequestHandlerInterface::class, true)) {
23	1	throw new InvalidArgumentException(
24	1	sprintf('%s does not implement %s', $handler, RequestHandlerInterface::class)
25		);
26		}
27
28	2	$this->container = $container;
29	2	$this->handler = $handler;
30	2	}
		0 ignored issues – show Coding Style introduced 2018-11-06 02:52 UTC by Report Bug Copy Issue Report Expected 2 blank lines after function; 1 found Loading history...
31
32		// RequestHandlerInterface
33	1	public function handle(ServerRequestInterface $request): ResponseInterface
34		{
35	1	return $this->resolve()->handle($request);
36		}
		0 ignored issues – show Coding Style introduced 2018-11-06 02:52 UTC by Report Bug Copy Issue Report Expected 2 blank lines after function; 1 found Loading history...
37
38	1	private function resolve(): RequestHandlerInterface
39		{
40	1	return $this->container->get($this->handler);
41		}
		0 ignored issues – show Coding Style introduced 2018-11-06 02:52 UTC by Report Bug Copy Issue Report Expected 2 blank lines after function; 0 found Loading history...
42		}
43

northwoods / lazy-middleware

Pull Request — master (#2)

LazyHandler::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like