LoaderFactory::make() - Code Metrics - Inspection of "Add hard set functionality" - northwoods/config - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#14)

unknown

created 2018-11-08 13:07 UTC

LoaderFactory::make() A

↳ Parent: LoaderFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	11
ccs	0
cts	9
cp	0
crap	12
rs	10
c	0
b	0
f	0

<?php

namespace Northwoods\Config\Loader;

class LoaderFactory
{
    /**
     * @var array
     */
    private $loaders = [

        'php' => PhpLoader::class,
        'yaml' => YamlLoader::class,
    ];

    /**
     * @var LoaderInterface[]
     */
    private $instances = [];


    /**
     * @param array $loaders
     */
    public function __construct(array $loaders = [])

    {
        $this->loaders = array_replace($this->loaders, $loaders);
    }


    /**
     * @param string $extension
     * @return LoaderInterface
     */
    public function forType($extension)
    {
        if (empty($this->instances[$extension])) {
            $this->instances[$extension] = $this->make($this->loaders[$extension]);
        }

        return $this->instances[$extension];
    }


    /**
     * @param string $loader
     * @return LoaderInterface
     * @throws LoaderException
     *  If the requested loader cannot be created.
     */
    private function make($loader)
    {
        if (!is_a($loader, LoaderInterface::class, true)) {

            throw LoaderException::invalidLoader($loader);
        }

        if (!call_user_func([$loader, 'isSupported'])) {

            throw LoaderException::unsupportedLoader($loader);
        }

        return new $loader();
    }

}


1			<?php
2
3			namespace Northwoods\Config\Loader;
4
5			class LoaderFactory
6			{
7			/**
8			* @var array
9			*/
10			private $loaders = [
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report Private member variable "loaders" must contain a leading underscore Loading history... Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report Expected 1 blank line before member var; 0 found Loading history...
11			'php' => PhpLoader::class,
12			'yaml' => YamlLoader::class,
13			];
14
15			/**
16			* @var LoaderInterface[]
17			*/
18			private $instances = [];
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report Private member variable "instances" must contain a leading underscore Loading history...
19
20			/**
21			* @param array $loaders
22			*/
23			public function __construct(array $loaders = [])
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report Expected 2 blank lines before function; 1 found Loading history...
24			{
25			$this->loaders = array_replace($this->loaders, $loaders);
26			}
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report Expected 2 blank lines after function; 1 found Loading history...
27
28			/**
29			* @param string $extension
30			* @return LoaderInterface
31			*/
32			public function forType($extension)
33			{
34			if (empty($this->instances[$extension])) {
35			$this->instances[$extension] = $this->make($this->loaders[$extension]);
36			}
37
38			return $this->instances[$extension];
39			}
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report Expected 2 blank lines after function; 1 found Loading history...
40
41			/**
42			* @param string $loader
43			* @return LoaderInterface
44			* @throws LoaderException
45			* If the requested loader cannot be created.
46			*/
47			private function make($loader)
48			{
49			if (!is_a($loader, LoaderInterface::class, true)) {
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report There must be a single space after a NOT operator; 0 found Loading history...
50			throw LoaderException::invalidLoader($loader);
51			}
52
53			if (!call_user_func([$loader, 'isSupported'])) {
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report There must be a single space after a NOT operator; 0 found Loading history...
54			throw LoaderException::unsupportedLoader($loader);
55			}
56
57			return new $loader();
58			}
			0 ignored issues – show Coding Style introduced 2018-11-08 02:16 UTC by Report Bug Copy Issue Report Expected 2 blank lines after function; 0 found Loading history...
59			}
60

northwoods / config

Pull Request — master (#14)

LoaderFactory::make() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like