Northwoods\Config\Loader\FactoryTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	3	1
A	testPhpLoader()	0	9	1
A	testUnsupportedLoader()	0	14	1
A	testYamlLoader()	0	9	1
A	testInvalidLoader()	0	10	1
A	testTypes()	0	13	1

<?php

namespace Northwoods\Config\Loader;

use Eloquent\Phony\Phpunit\Phony;
use PHPUnit\Framework\TestCase;

class FactoryTest extends TestCase
{
    /**
     * @var LoaderFactory
     */
    private $factory;

Private member variable "factory" must contain a leading underscore

Expected 1 blank line before member var; 0 found

    public function setUp()

Expected 2 blank lines before function; 1 found

    {
        $this->factory = new LoaderFactory();
    }

Expected 2 blank lines after function; 1 found

    public function testTypes()
    {
        $loader = $this->factory->forType('php');

        $this->assertInstanceOf(LoaderInterface::class, $loader);
        $this->assertInstanceOf(PhpLoader::class, $loader);
        $this->assertTrue($loader::isSupported());

        $loader = $this->factory->forType('yaml');

        $this->assertInstanceOf(LoaderInterface::class, $loader);
        $this->assertInstanceOf(YamlLoader::class, $loader);
        $this->assertTrue($loader::isSupported());
    }

Expected 2 blank lines after function; 1 found

    public function testPhpLoader()
    {
        $loader = $this->factory->forType('php');

        $config = $loader->load(__DIR__ . '/../../examples/app');
        $this->assertArrayHasKey('timezone', $config);

        $config = $loader->load(__DIR__ . '/failure/fail');
        $this->assertSame([], $config);
    }

Expected 2 blank lines after function; 1 found

    public function testYamlLoader()
    {
        $loader = $this->factory->forType('yaml');

        $config = $loader->load(__DIR__ . '/../../examples/users');
        $this->assertArrayHasKey('admins', $config);

        $config = $loader->load(__DIR__ . '/failure/fail');
        $this->assertSame([], $config);
    }

Expected 2 blank lines after function; 1 found

    public function testInvalidLoader()
    {
        $factory = new LoaderFactory([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'test' => \stdclass::class,
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $this->expectException(LoaderException::class);
        $this->expectExceptionCode(LoaderException::INVALID_LOADER);

        $loader = $factory->forType('test');

The assignment to $loader is dead and can be removed.

    }

Expected 2 blank lines after function; 1 found

    public function testUnsupportedLoader()
    {
        $loader = Phony::mock(LoaderInterface::class);
        $loader = Phony::onStatic($loader);
        $loader->isSupported->returns(false);

        $factory = new LoaderFactory([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'test' => $loader->className(),
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $this->expectException(LoaderException::class);
        $this->expectExceptionCode(LoaderException::UNSUPPORTED_LOADER);

        $loader = $factory->forType('test');

The assignment to $loader is dead and can be removed.

    }

Expected 2 blank lines after function; 0 found

}