Issues in File.php (develop) - Issues in develop - nordsoftware/lumen-file-manager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Eloquent/File.php (7 issues)

Labels

Documentation 7

Severity

Informational 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Nord\Lumen\FileManager\Eloquent;

use Carbon\Carbon;
use Illuminate\Database\Eloquent\Model;
use Nord\Lumen\FileManager\Contracts\File as FileContract;
use Nord\Lumen\FileManager\Facades\FileManager;

class File extends Model implements FileContract
{

    /**
     * @inheritdoc
     */
    protected $fillable = [
        'file_id',
        'name',
        'extension',
        'path',
        'mime_type',
        'byte_size',
        'data',
        'disk',
        'saved_at',
    ];

    /**
     * @var array
     */
    protected $hidden = [
        'id',
    ];

    /**
     * @var array
     */
    protected $casts = [
        'data' => 'array',
    ];

    /**
     * @var array
     */
    protected $dates = [
        'saved_at',
    ];

    /**
     * @var array
     */
    protected $guarded = ['*'];

    /**
     * @var bool
     */
    public $timestamps = false;


    /**
     * @return string
     */
    public function getId()
    {
        return $this->attributes['file_id'];
    }


    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    /**
     * @return string
     */
    public function getExtension()
    {
        return $this->extension;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    /**
     * @return string
     */
    public function getMimeType()
    {
        return $this->attributes['mime_type'];
    }


    /**
     * @return int
     */
    public function getByteSize()
    {
        return $this->attributes['byte_size'];
    }


    /**
     * @return array
     */
    public function getData()
    {
        return $this->data;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    /**
     * @return string
     */
    public function getDisk()
    {
        return $this->disk;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    /**
     * @return Carbon
     */
    public function getSavedAt()
    {
        return $this->attributes['saved_at'];
    }


    /**
     * @return string
     */
    public function getSavedAtAsTimestamp()
    {
        return $this->getSavedAt()->getTimestamp();
    }


    /**
     * @return string
     */
    public function getFilename()
    {
        return $this->name . '-' . $this->getId() . '.' . $this->extension;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    /**
     * @inheritdoc
     */
    public function getFilePath()
    {
        return $this->getPath() . $this->getFilename();
    }


    /**
     * @inheritdoc
     */
    public function getUrl(array $options = [])
    {
        return FileManager::getFileUrl($this, $options);
    }


    /**
     * @return string
     */
    private function getPath()
    {
        return isset($this->path) ? $this->path . '/' : '';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    /**
     * @inheritdoc
     */
    public function toArray()
    {
        return array_merge(parent::toArray(), ['url' => $this->getUrl()]);
    }


    /**
     * @param string $id
     *
     * @return File
     */
    public static function findByFileId($id)
    {
        return self::where('file_id', $id)->first();
    }
}


1			<?php
2
3			namespace Nord\Lumen\FileManager\Eloquent;
4
5			use Carbon\Carbon;
6			use Illuminate\Database\Eloquent\Model;
7			use Nord\Lumen\FileManager\Contracts\File as FileContract;
8			use Nord\Lumen\FileManager\Facades\FileManager;
9
10			class File extends Model implements FileContract
11			{
12
13			/**
14			* @inheritdoc
15			*/
16			protected $fillable = [
17			'file_id',
18			'name',
19			'extension',
20			'path',
21			'mime_type',
22			'byte_size',
23			'data',
24			'disk',
25			'saved_at',
26			];
27
28			/**
29			* @var array
30			*/
31			protected $hidden = [
32			'id',
33			];
34
35			/**
36			* @var array
37			*/
38			protected $casts = [
39			'data' => 'array',
40			];
41
42			/**
43			* @var array
44			*/
45			protected $dates = [
46			'saved_at',
47			];
48
49			/**
50			* @var array
51			*/
52			protected $guarded = ['*'];
53
54			/**
55			* @var bool
56			*/
57			public $timestamps = false;
58
59
60			/**
61			* @return string
62			*/
63			public function getId()
64			{
65			return $this->attributes['file_id'];
66			}
67
68
69			/**
70			* @return string
71			*/
72			public function getName()
73			{
74			return $this->name;
			0 ignored issues – show Documentation introduced 2016-06-30 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `name` does not exist on `object<Nord\Lumen\FileManager\Eloquent\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
75			}
76
77
78			/**
79			* @return string
80			*/
81			public function getExtension()
82			{
83			return $this->extension;
			0 ignored issues – show Documentation introduced 2016-06-30 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `extension` does not exist on `object<Nord\Lumen\FileManager\Eloquent\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
84			}
85
86
87			/**
88			* @return string
89			*/
90			public function getMimeType()
91			{
92			return $this->attributes['mime_type'];
93			}
94
95
96			/**
97			* @return int
98			*/
99			public function getByteSize()
100			{
101			return $this->attributes['byte_size'];
102			}
103
104
105			/**
106			* @return array
107			*/
108			public function getData()
109			{
110			return $this->data;
			0 ignored issues – show Documentation introduced 2016-06-30 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `data` does not exist on `object<Nord\Lumen\FileManager\Eloquent\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
111			}
112
113
114			/**
115			* @return string
116			*/
117			public function getDisk()
118			{
119			return $this->disk;
			0 ignored issues – show Documentation introduced 2016-06-30 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `disk` does not exist on `object<Nord\Lumen\FileManager\Eloquent\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
120			}
121
122
123			/**
124			* @return Carbon
125			*/
126			public function getSavedAt()
127			{
128			return $this->attributes['saved_at'];
129			}
130
131
132			/**
133			* @return string
134			*/
135			public function getSavedAtAsTimestamp()
136			{
137			return $this->getSavedAt()->getTimestamp();
138			}
139
140
141			/**
142			* @return string
143			*/
144			public function getFilename()
145			{
146			return $this->name . '-' . $this->getId() . '.' . $this->extension;
			0 ignored issues – show Documentation introduced 2016-06-30 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `name` does not exist on `object<Nord\Lumen\FileManager\Eloquent\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-06-30 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `extension` does not exist on `object<Nord\Lumen\FileManager\Eloquent\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
147			}
148
149
150			/**
151			* @inheritdoc
152			*/
153			public function getFilePath()
154			{
155			return $this->getPath() . $this->getFilename();
156			}
157
158
159			/**
160			* @inheritdoc
161			*/
162			public function getUrl(array $options = [])
163			{
164			return FileManager::getFileUrl($this, $options);
165			}
166
167
168			/**
169			* @return string
170			*/
171			private function getPath()
172			{
173			return isset($this->path) ? $this->path . '/' : '';
			0 ignored issues – show Documentation introduced 2016-06-30 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `path` does not exist on `object<Nord\Lumen\FileManager\Eloquent\File>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
174			}
175
176
177			/**
178			* @inheritdoc
179			*/
180			public function toArray()
181			{
182			return array_merge(parent::toArray(), ['url' => $this->getUrl()]);
183			}
184
185
186			/**
187			* @param string $id
188			*
189			* @return File
190			*/
191			public static function findByFileId($id)
192			{
193			return self::where('file_id', $id)->first();
194			}
195			}
196

nordsoftware / lumen-file-manager

Issues (18)

Security Analysis not enabled

src/Eloquent/File.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like