EmailAddress::equals() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/dev'" - nordic-alliance/email-address - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a50425...6eae0f )

by Serhii

created 2019-05-01 09:05 UTC

EmailAddress::equals() A

↳ Parent: EmailAddress

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Nordic\EmailAddress;

/**
 * Immutable email address value object
 */
class EmailAddress implements EmailAddressInterface
{
    /** @var string */
    private $emailAddress;

    /**
     * Constructor
     *
     * @throws \Nordic\EmailAddress\InvalidEmailAddressException
     */
    public function __construct(string $emailAddress)
    {
        $this->emailAddress = Assertion::email($emailAddress);
    }

    /**
     * @inheritDoc
     */
    public function equals(EmailAddressInterface $emailAddress): bool
    {
        return $this->emailAddress === $emailAddress->emailAddress;

    }

    /**
     * @inheritDoc
     */
    public function __toString(): string
    {
        return $this->emailAddress;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Nordic\EmailAddress;
6
7		/**
8		* Immutable email address value object
9		*/
10		class EmailAddress implements EmailAddressInterface
11		{
12		/** @var string */
13		private $emailAddress;
14
15		/**
16		* Constructor
17		*
18		* @throws \Nordic\EmailAddress\InvalidEmailAddressException
19		*/
20	27	public function __construct(string $emailAddress)
21		{
22	27	$this->emailAddress = Assertion::email($emailAddress);
23	21	}
24
25		/**
26		* @inheritDoc
27		*/
28	6	public function equals(EmailAddressInterface $emailAddress): bool
29		{
30	6	return $this->emailAddress === $emailAddress->emailAddress;
		0 ignored issues – show Bug introduced 2019-05-01 09:07 UTC by Report Bug Copy Issue Report Accessing `emailAddress` on the interface `Nordic\EmailAddress\EmailAddressInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
31		}
32
33		/**
34		* @inheritDoc
35		*/
36	12	public function __toString(): string
37		{
38	12	return $this->emailAddress;
39		}
40		}
41

nordic-alliance / email-address

Push — master ( a50425...6eae0f )

EmailAddress::equals() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like