PluginMatcher::matches() - Code Metrics - Inspection of "Merge branch 'master' into feature/refactor" - nopolabs/yabot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1b605f...95b7c3 )

by Dan

created 2017-06-02 15:08 UTC

PluginMatcher::matches() C

↳ Parent: PluginMatcher

Complexity

Conditions	8
Paths	5

Size

Total Lines	24
Code Lines	14

Duplication

Lines	12
Ratio	50 %

Importance

Changes

Metric	Value
dl	12
loc	24
rs	5.7377
c	0
b	0
f	0
cc	8
eloc	14
nc	5
nop	1

<?php

namespace Nopolabs\Yabot\Plugin;


use Nopolabs\Yabot\Helpers\LogTrait;
use Nopolabs\Yabot\Message\Message;
use Psr\Log\LoggerInterface;
use Psr\Log\LogLevel;

class PluginMatcher
{
    use LogTrait;

    private $pluginId;
    private $isBot;
    private $channels;
    private $users;

    public function __construct(
        string $pluginId,
        bool $isBot = null,
        array $channels,
        array $users,
        LoggerInterface $logger)
    {
        $this->pluginId = $pluginId;
        $this->isBot = $isBot;
        $this->channels = $channels;
        $this->users = $users;
        $this->setLog($logger);
    }

    public function matches(Message $message) : bool
    {
        if ($message->isHandled()) {
            $this->debug('message already handled');
            return false;
        }

        if ($this->isBot !== null && $this->isBot !== $message->isBot()) {

            $this->debug('isBot match failed');
            return false;
        }

        if ($this->channels && !in_array($message->getChannelName(), $this->channels)) {

            $this->debug('channels match failed '.json_encode($this->channels));
            return false;
        }

        if ($this->users && !in_array($message->getUsername(), $this->users)) {

            $this->debug('users match failed '.json_encode($this->users));
            return false;
        }

        return true;
    }

    private function debug($msg)
    {
        $this->log(LogLevel::DEBUG, "PluginMatcher {$this->pluginId}: $msg");
    }
}


1		<?php
2
3		namespace Nopolabs\Yabot\Plugin;
4
5
6		use Nopolabs\Yabot\Helpers\LogTrait;
7		use Nopolabs\Yabot\Message\Message;
8		use Psr\Log\LoggerInterface;
9		use Psr\Log\LogLevel;
10
11		class PluginMatcher
12		{
13		use LogTrait;
14
15		private $pluginId;
16		private $isBot;
17		private $channels;
18		private $users;
19
20		public function __construct(
21		string $pluginId,
22		bool $isBot = null,
23		array $channels,
24		array $users,
25		LoggerInterface $logger)
26		{
27		$this->pluginId = $pluginId;
28		$this->isBot = $isBot;
29		$this->channels = $channels;
30		$this->users = $users;
31		$this->setLog($logger);
32		}
33
34		public function matches(Message $message) : bool
35		{
36		if ($message->isHandled()) {
37		$this->debug('message already handled');
38		return false;
39		}
40
41	View Code Duplication	if ($this->isBot !== null && $this->isBot !== $message->isBot()) {
		0 ignored issues – show Duplication introduced 2017-06-02 15:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		$this->debug('isBot match failed');
43		return false;
44		}
45
46	View Code Duplication	if ($this->channels && !in_array($message->getChannelName(), $this->channels)) {
		0 ignored issues – show Bug Best Practice introduced 2017-06-02 15:14 UTC by Report Bug Copy Issue Report The expression `$this->channels` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history... Duplication introduced 2017-06-02 15:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		$this->debug('channels match failed '.json_encode($this->channels));
48		return false;
49		}
50
51	View Code Duplication	if ($this->users && !in_array($message->getUsername(), $this->users)) {
		0 ignored issues – show Bug Best Practice introduced 2017-06-02 15:14 UTC by Report Bug Copy Issue Report The expression `$this->users` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history... Duplication introduced 2017-06-02 15:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		$this->debug('users match failed '.json_encode($this->users));
53		return false;
54		}
55
56		return true;
57		}
58
59		private function debug($msg)
60		{
61		$this->log(LogLevel::DEBUG, "PluginMatcher {$this->pluginId}: $msg");
62		}
63		}
64

nopolabs / yabot

Push — master ( 1b605f...95b7c3 )

PluginMatcher::matches() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like