NytPlugin::nyt() - Code Metrics - nopolabs/yabot-plugins - Measure and Improve Code Quality continuously with Scrutinizer

NytPlugin::nyt() B
last analyzed 2017-11-12 23:13 UTC

↳ Parent: NytPlugin

Complexity

Conditions	3
Paths	2

Size

Total Lines	32
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
rs	8.8571
c	0
b	0
f	0
cc	3
eloc	21
nc	2
nop	2

<?php

namespace Nopolabs\Yabot\Plugins\Examples;


use Exception;
use Nopolabs\Yabot\Message\Message;
use Nopolabs\Yabot\Plugin\PluginInterface;
use Nopolabs\Yabot\Plugin\PluginTrait;
use Nopolabs\Yabot\Plugins\Giphy\GiphyService;
use Nopolabs\Yabot\Plugins\Rss\RssService;
use Psr\Log\LoggerInterface;
use React\EventLoop\LoopInterface;

class NytPlugin implements PluginInterface
{
    use PluginTrait;

    private $rssService;
    private $giphyService;

    public function __construct(

        LoggerInterface $logger,
        RssService $rssService,
        GiphyService $giphyService,
        array $config = [])
    {
        $this->setLog($logger);
        $this->rssService = $rssService;
        $this->giphyService = $giphyService;
        $this->setConfig(array_merge(
            [
                'help' => '<prefix> number-of-items',
                'prefix' => 'nyt',
                'matchers' => [
                    'nyt' => "/^(?:(?'n'\\d\\d?)|)$/",
                ],
                'url' => 'http://rss.nytimes.com/services/xml/rss/nyt/HomePage.xml',
                'format' => 'fixed_height_downsampled',
            ],
            $config
        ));
    }

    public function nyt(Message $msg, array $matches)
    {
        $n = $matches['n'] ? $matches['n'] : 1;
        $url = $this->get('url');

        $this->rssService
            ->fetch($url)
            ->then(
                function ($rss) use ($msg, $n) {
                    $items = $rss->channel->item;
                    $n = min($n, count($items));
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                    $format = $this->get('format', 'fixed_height');
                    for ($i = 0; $i < $n; $i++) {
                        $title = $items[$i]->title;
                        $this->giphyService
                            ->search($title, $format)
                            ->then(
                                function (string $gifUrl) use ($msg, $title, $i) {
                                    $msg->reply("<$gifUrl|$i: $title>");
                                },
                                function (Exception $e) {
                                    $this->getLog()->warning($e->getMessage());
                                }
                            );
                    }
                },
                function (Exception $e) {
                    $this->getLog()->warning($e->getMessage());
                }
            );

    }
}


NytPlugin::nyt() B
last analyzed 2017-11-12 23:13 UTC

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

1		<?php
2
3		namespace Nopolabs\Yabot\Plugins\Examples;
4
5
6		use Exception;
7		use Nopolabs\Yabot\Message\Message;
8		use Nopolabs\Yabot\Plugin\PluginInterface;
9		use Nopolabs\Yabot\Plugin\PluginTrait;
10		use Nopolabs\Yabot\Plugins\Giphy\GiphyService;
11		use Nopolabs\Yabot\Plugins\Rss\RssService;
12		use Psr\Log\LoggerInterface;
13		use React\EventLoop\LoopInterface;
14
15		class NytPlugin implements PluginInterface
16		{
17		use PluginTrait;
18
19		private $rssService;
20		private $giphyService;
21
22	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2017-08-02 15:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		LoggerInterface $logger,
24		RssService $rssService,
25		GiphyService $giphyService,
26		array $config = [])
27		{
28		$this->setLog($logger);
29		$this->rssService = $rssService;
30		$this->giphyService = $giphyService;
31		$this->setConfig(array_merge(
32		[
33		'help' => '<prefix> number-of-items',
34		'prefix' => 'nyt',
35		'matchers' => [
36		'nyt' => "/^(?:(?'n'\\d\\d?)\|)$/",
37		],
38		'url' => 'http://rss.nytimes.com/services/xml/rss/nyt/HomePage.xml',
39		'format' => 'fixed_height_downsampled',
40		],
41		$config
42		));
43		}
44
45		public function nyt(Message $msg, array $matches)
46		{
47		$n = $matches['n'] ? $matches['n'] : 1;
48		$url = $this->get('url');
49
50		$this->rssService
51		->fetch($url)
52		->then(
53		function ($rss) use ($msg, $n) {
54		$items = $rss->channel->item;
55		$n = min($n, count($items));
		0 ignored issues – show Bug introduced 2017-07-04 19:07 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$n`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
56		$format = $this->get('format', 'fixed_height');
57		for ($i = 0; $i < $n; $i++) {
58		$title = $items[$i]->title;
59		$this->giphyService
60		->search($title, $format)
61		->then(
62		function (string $gifUrl) use ($msg, $title, $i) {
63		$msg->reply("<$gifUrl\|$i: $title>");
64		},
65		function (Exception $e) {
66		$this->getLog()->warning($e->getMessage());
67		}
68		);
69		}
70		},
71		function (Exception $e) {
72		$this->getLog()->warning($e->getMessage());
73		}
74		);
75
76		}
77		}
78

nopolabs / yabot-plugins

NytPlugin::nyt() B last analyzed 2017-11-12 23:13 UTC

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like

NytPlugin::nyt() B
last analyzed 2017-11-12 23:13 UTC