QueueFactory::get_scenario1_queues() - Code Metrics - Inspection of "* Тестовый билд для Travis'а" - nokitakaze/php-queue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — developer ( ad9869...0e4843 )

by Никита

created 2018-02-13 19:56 UTC

QueueFactory::get_scenario1_queues() A

↳ Parent: QueueFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	13
cts	13
cp	1
rs	9.2
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	1
crap	1

<?php

    namespace NokitaKaze\Queue;

    class QueueFactory {
        /**
         * @param GeneralQueueConstructionSettings $settings
         *
         * @return Queue
         * @throws QueueException
         */
        static function get_queue($settings) {

            if (!isset($settings->name)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                throw new QueueException('Queue name has not been set');
            }
            if (!isset($settings->sleep_time_while_consuming)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $settings->sleep_time_while_consuming = 0.02;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            }

            if (!isset($settings->queues)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                if (!isset($settings->scenario) or ($settings->scenario == 0)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    $settings->queues = self::get_scenario_read_small_files($settings);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                } elseif ($settings->scenario == 1) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    $settings->queues = self::get_scenario_write_small_files($settings);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                } else {
                    throw new QueueException("Can not resolve scenario #{$settings->scenario}");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                }
            }

            $queue = new Queue($settings);

            return $queue;
        }

        /**
         * @param GeneralQueueConstructionSettings $settings
         *
         * @return Queue[]
         */
        protected static function get_scenario_read_small_files($settings) {
            /**
             * @var FileDBQueueConstructionSettingsForGeneral $sub_set1
             */
            $sub_set1 = (object) [];
            $sub_set1->is_general = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set1->name = $settings->name.'_set1';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set1->folder = $settings->folder;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set1->mutex_folder = $settings->folder.'/mutex';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set1->class_name = 'FileDB';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

            /**
             * @var SmallFilesQueueConstructionSettingsForGeneral $sub_set2
             */
            $sub_set2 = (object) [];
            $sub_set2->is_general = false;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set2->name = $settings->name.'_set2';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set2->message_folder = $settings->folder.'/messages';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set2->class_name = 'SmallFiles';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

            return [$sub_set1, $sub_set2];
        }

        /**
         * @param GeneralQueueConstructionSettings $settings
         *
         * @return Queue[]
         */
        protected static function get_scenario_write_small_files($settings) {
            /**
             * @var SmallFilesQueueConstructionSettingsForGeneral $sub_set2
             */
            $sub_set2 = (object) [];
            $sub_set2->is_general = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set2->name = $settings->name.'_set2';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set2->message_folder = $settings->folder.'/messages';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $sub_set2->class_name = 'SmallFiles';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

            return [$sub_set2];
        }
    }

?>

1		<?php
2
3		namespace NokitaKaze\Queue;
4
5		class QueueFactory {
6		/**
7		* @param GeneralQueueConstructionSettings $settings
8		*
9		* @return Queue
10		* @throws QueueException
11		*/
12	33	static function get_queue($settings) {
		1 ignored issue – show Best Practice introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
13	33	if (!isset($settings->name)) {
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
14	3	throw new QueueException('Queue name has not been set');
15		}
16	30	if (!isset($settings->sleep_time_while_consuming)) {
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `sleep_time_while_consuming` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
17	30	$settings->sleep_time_while_consuming = 0.02;
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `sleep_time_while_consuming` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
18	10	}
19
20	30	if (!isset($settings->queues)) {
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `queues` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
21	30	if (!isset($settings->scenario) or ($settings->scenario == 0)) {
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `scenario` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
22	18	$settings->queues = self::get_scenario_read_small_files($settings);
		1 ignored issue – show Bug introduced 2018-02-13 20:40 UTC by Report Bug Copy Issue Report Accessing `queues` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
23	24	} elseif ($settings->scenario == 1) {
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `scenario` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
24	18	$settings->queues = self::get_scenario_write_small_files($settings);
		1 ignored issue – show Bug introduced 2018-02-13 20:40 UTC by Report Bug Copy Issue Report Accessing `queues` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
25	6	} else {
26	3	throw new QueueException("Can not resolve scenario #{$settings->scenario}");
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `scenario` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
27		}
28	9	}
29
30	27	$queue = new Queue($settings);
31
32	27	return $queue;
33		}
34
35		/**
36		* @param GeneralQueueConstructionSettings $settings
37		*
38		* @return Queue[]
39		*/
40	21	protected static function get_scenario_read_small_files($settings) {
41		/**
42		* @var FileDBQueueConstructionSettingsForGeneral $sub_set1
43		*/
44	18	$sub_set1 = (object) [];
45	18	$sub_set1->is_general = true;
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `is_general` on the interface `NokitaKaze\Queue\FileDBQ...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
46	18	$sub_set1->name = $settings->name.'_set1';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `NokitaKaze\Queue\FileDBQ...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
47	21	$sub_set1->folder = $settings->folder;
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `folder` on the interface `NokitaKaze\Queue\FileDBQ...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `folder` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
48	18	$sub_set1->mutex_folder = $settings->folder.'/mutex';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `mutex_folder` on the interface `NokitaKaze\Queue\FileDBQ...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `folder` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49	18	$sub_set1->class_name = 'FileDB';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `class_name` on the interface `NokitaKaze\Queue\FileDBQ...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
50
51		/**
52		* @var SmallFilesQueueConstructionSettingsForGeneral $sub_set2
53		*/
54	21	$sub_set2 = (object) [];
55	18	$sub_set2->is_general = false;
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `is_general` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
56	18	$sub_set2->name = $settings->name.'_set2';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
57	18	$sub_set2->message_folder = $settings->folder.'/messages';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `message_folder` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `folder` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
58	18	$sub_set2->class_name = 'SmallFiles';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `class_name` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
59
60	18	return [$sub_set1, $sub_set2];
61		}
62
63		/**
64		* @param GeneralQueueConstructionSettings $settings
65		*
66		* @return Queue[]
67		*/
68		protected static function get_scenario_write_small_files($settings) {
69	18	/**
70		* @var SmallFilesQueueConstructionSettingsForGeneral $sub_set2
71		*/
72		$sub_set2 = (object) [];
73	18	$sub_set2->is_general = true;
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `is_general` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
74	18	$sub_set2->name = $settings->name.'_set2';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
75	18	$sub_set2->message_folder = $settings->folder.'/messages';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `message_folder` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `folder` on the interface `NokitaKaze\Queue\GeneralQueueConstructionSettings` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
76	18	$sub_set2->class_name = 'SmallFiles';
		0 ignored issues – show Bug introduced 2017-10-05 11:47 UTC by Report Bug Copy Issue Report Accessing `class_name` on the interface `NokitaKaze\Queue\SmallFi...ctionSettingsForGeneral` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
77	18
78		return [$sub_set2];
79	18	}
80		}
81
82		?>

nokitakaze / php-queue

Push — developer ( ad9869...0e4843 )

QueueFactory::get_scenario1_queues() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like