Complex classes like FileMutex often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FileMutex, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
5 | class FileMutex implements MutexInterface { |
||
6 | /** |
||
7 | * @var string Название файла, на котором будет работать мьютекс |
||
8 | */ |
||
9 | var $filename = ''; |
||
10 | protected $_mutex_type; |
||
11 | /** |
||
12 | * @var string|null Название мьютекса, должно состоять из валидных для имени файлов символов |
||
13 | */ |
||
14 | var $_mutex_name; |
||
15 | /** |
||
16 | * @var string|null Место, где расположен файл. |
||
17 | * Не используется в логике класса |
||
18 | */ |
||
19 | protected $_mutex_folder; |
||
20 | /** |
||
21 | * @var double|null Время, когда мьютекс был получен |
||
22 | */ |
||
23 | protected $_lock_acquired_time = null; |
||
24 | /** |
||
25 | * @var boolean Текущее состояние мьютекса |
||
26 | */ |
||
27 | protected $_lock_acquired = false; |
||
28 | /** |
||
29 | * @var resource|false Файл, открывающийся через fopen |
||
30 | */ |
||
31 | protected $_file_handler = false; |
||
32 | /** |
||
33 | * @var boolean Удалять файл при анлоке |
||
34 | * В данный момент это unsafe поведение, из-за немандаторного доступа к файлам из PHP |
||
35 | */ |
||
36 | protected $_delete_on_release = false; |
||
37 | |||
38 | /** |
||
39 | * @param MutexSettings|array $settings |
||
40 | */ |
||
41 | 5 | function __construct($settings) { |
|
42 | /** |
||
43 | * @var MutexSettings $settings |
||
44 | */ |
||
45 | 5 | $settings = (object) $settings; |
|
46 | 5 | if (!isset($settings->type)) { |
|
47 | 1 | $settings->type = null; |
|
48 | 1 | } |
|
49 | 5 | if (!isset($settings->folder)) { |
|
50 | 1 | $settings->folder = null; |
|
51 | 1 | } |
|
52 | |||
53 | 5 | $this->_mutex_type = is_null($settings->type) ? self::SERVER : $settings->type; |
|
54 | 5 | $this->_mutex_folder = is_null($settings->folder) ? sys_get_temp_dir() : $settings->folder; |
|
55 | 5 | $this->_mutex_name = $settings->name; |
|
56 | 5 | if (isset($settings->delete_on_release)) { |
|
57 | 1 | $this->_delete_on_release = $settings->delete_on_release; |
|
58 | 1 | } |
|
59 | |||
60 | 5 | $prefix = ''; |
|
61 | 5 | if (isset($settings->prefix)) { |
|
62 | 1 | $prefix = $settings->prefix; |
|
63 | 5 | } elseif ($this->_mutex_type == self::DOMAIN) { |
|
64 | 1 | $prefix = hash('sha512', self::getDomainString()).'_'; |
|
65 | 5 | } elseif ($this->_mutex_type == self::DIRECTORY) { |
|
66 | 1 | $prefix = hash('sha512', strtolower(self::getDirectoryString())).'_'; |
|
67 | 1 | } |
|
68 | 5 | $this->filename = $this->_mutex_folder.DIRECTORY_SEPARATOR.'smartmutex_'.$prefix.$this->_mutex_name.'.lock'; |
|
69 | 5 | } |
|
70 | |||
71 | 5 | function __destruct() { |
|
74 | |||
75 | /** |
||
76 | * @return string |
||
77 | */ |
||
78 | 3 | static function getDomainString() { |
|
89 | |||
90 | /** |
||
91 | * @return string |
||
92 | */ |
||
93 | 2 | static function getDirectoryString() { |
|
104 | |||
105 | /** |
||
106 | * @return boolean |
||
107 | * |
||
108 | * @throws MutexException |
||
109 | */ |
||
110 | 1 | function is_free() { |
|
131 | |||
132 | /** |
||
133 | * @param double|integer $time |
||
134 | * |
||
135 | * @return bool |
||
136 | * @throws MutexException |
||
137 | */ |
||
138 | 4 | function get_lock($time = -1) { |
|
139 | 4 | $tmp_time = microtime(true); |
|
140 | 4 | if ($this->_lock_acquired) { |
|
141 | 3 | return true; |
|
142 | } |
||
143 | |||
144 | 4 | self::create_folders_in_path(dirname($this->filename)); |
|
145 | 4 | if (!is_dir(dirname($this->filename))) { |
|
146 | throw new MutexException('Folder "'.dirname($this->filename).'" is not a folder', 4); |
||
147 | 4 | } elseif (!is_writable(dirname($this->filename))) { |
|
148 | 1 | throw new MutexException('Folder "'.dirname($this->filename).'" is not writable', 2); |
|
149 | 4 | } elseif (file_exists($this->filename) and !is_writable($this->filename)) { |
|
150 | 1 | throw new MutexException('File "'.$this->filename.'" is not writable', 3); |
|
151 | } |
||
152 | |||
153 | // Открываем файл |
||
154 | 4 | $this->_file_handler = fopen($this->filename, file_exists($this->filename) ? 'ab' : 'wb'); |
|
155 | 4 | while (($this->_file_handler === false) and ( |
|
156 | ($tmp_time + $time >= microtime(true)) or ($time == -1) |
||
157 | 4 | )) { |
|
158 | usleep(10000); |
||
159 | $this->_file_handler = fopen($this->filename, 'ab'); |
||
160 | } |
||
161 | 4 | if ($this->_file_handler === false) { |
|
162 | return false; |
||
163 | } |
||
164 | |||
165 | // Блочим файл |
||
166 | 4 | if ($time >= 0) { |
|
167 | 4 | $result = flock($this->_file_handler, LOCK_EX | LOCK_NB); |
|
168 | 4 | while (!$result and ($tmp_time + $time >= microtime(true))) { |
|
169 | // U MAD? |
||
170 | 1 | usleep(10000); |
|
171 | 1 | $result = flock($this->_file_handler, LOCK_EX | LOCK_NB); |
|
172 | 1 | } |
|
173 | 4 | } else { |
|
174 | $result = flock($this->_file_handler, LOCK_EX); |
||
175 | } |
||
176 | |||
177 | 4 | if ($result) { |
|
178 | 4 | $this->_lock_acquired_time = microtime(true); |
|
179 | // @todo Не работает под Windows |
||
180 | 4 | fwrite($this->_file_handler, posix_getpid()."\n".microtime(true)."\n".posix_getuid()."\n\n"); |
|
181 | 4 | fflush($this->_file_handler); |
|
182 | 4 | $this->_lock_acquired = true; |
|
183 | 4 | } else { |
|
184 | 1 | fclose($this->_file_handler); |
|
185 | 1 | $this->_file_handler = false; |
|
186 | } |
||
187 | |||
188 | 4 | return $result; |
|
189 | } |
||
190 | |||
191 | 5 | function release_lock() { |
|
207 | |||
208 | /** |
||
209 | * @return double|null |
||
210 | */ |
||
211 | 1 | function get_acquired_time() { |
|
212 | 1 | return $this->_lock_acquired_time; |
|
213 | } |
||
214 | |||
215 | /** |
||
216 | * @return string |
||
217 | */ |
||
218 | 1 | function get_mutex_name() { |
|
221 | |||
222 | /** |
||
223 | * @return boolean |
||
224 | */ |
||
225 | 2 | function get_delete_on_release() { |
|
228 | |||
229 | /** |
||
230 | * @return boolean |
||
231 | */ |
||
232 | 4 | function is_acquired() { |
|
235 | |||
236 | /** |
||
237 | * @return string |
||
238 | */ |
||
239 | 2 | static function get_last_php_error_as_string() { |
|
248 | |||
249 | /** |
||
250 | * @param string $path |
||
251 | * |
||
252 | * @throws \NokitaKaze\Mutex\MutexException |
||
253 | */ |
||
254 | 11 | static function create_folders_in_path($path) { |
|
281 | } |
||
282 | |||
283 | ?> |
If you suppress an error, we recommend checking for the error condition explicitly: