noitran / rql

src/Processors/Eloquent/ApplyBetween.php

<?php

declare(strict_types=1);

namespace Noitran\RQL\Processors\Eloquent;

use Illuminate\Database\Eloquent\Builder;
use Noitran\RQL\Contracts\Expression\ExprInterface;
use Noitran\RQL\Contracts\Processor\ProcessorInterface;
use Noitran\RQL\Contracts\Processor\SpecInterface;
use Noitran\RQL\Expressions\BetweenExpr;

/**
 * Class ApplyBetween.
 */
class ApplyBetween implements SpecInterface
{
    /**
     * {@inheritdoc}
     */
    public function isSatisfiedBy(ProcessorInterface $processor, ExprInterface $exprClass): bool
    {
        if (! $exprClass instanceof BetweenExpr) {
            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function apply(ProcessorInterface $processor, ExprInterface $exprClass): Builder
    {
        /* @var EloquentProcessor $processor */
        return $processor->getBuilder()->whereBetween(

The expression return $processor->getBuilder()->whereBetween($exprClass->getColumn(), $exprClass->getValue()) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            $exprClass->getColumn(),
            $exprClass->getValue()
        );
    }
}