LimitBy::apply() - Code Metrics - Inspection of "Setup of test suite. Basic repo methods." - noitran/micro-repositories - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e7b285...ac21bd )

by noitran

created 2019-02-09 20:13 UTC

LimitBy::apply() A

↳ Parent: LimitBy

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	7
c	0
b	0
f	0
ccs	0
cts	4
cp	0
rs	10
cc	2
nc	2
nop	2
crap	6

<?php

namespace Noitran\Repositories\Criteria;

use Noitran\Repositories\Contracts\Criteria\CriteriaInterface;
use Noitran\Repositories\Contracts\Repository\RepositoryInterface;
use Illuminate\Database\Eloquent\Builder;

/**
 * Class LimitBy.
 */
class LimitBy implements CriteriaInterface
{
    /**
     * @var string
     */
    protected $count;

    /**
     * LimitBy constructor.
     *
     * @param $count
     */
    public function __construct($count)
    {
        $this->count = $count;
    }

    /**
     * @param Builder $model
     * @param RepositoryInterface $repository
     *
     * @return Builder
     */
    public function apply($model, RepositoryInterface $repository): Builder
    {
        if ($this->count) {
            return $model->limit($this->count);

        }

        return $model;
    }
}


1			<?php
2
3			namespace Noitran\Repositories\Criteria;
4
5			use Noitran\Repositories\Contracts\Criteria\CriteriaInterface;
6			use Noitran\Repositories\Contracts\Repository\RepositoryInterface;
7			use Illuminate\Database\Eloquent\Builder;
8
9			/**
10			* Class LimitBy.
11			*/
12			class LimitBy implements CriteriaInterface
13			{
14			/**
15			* @var string
16			*/
17			protected $count;
18
19			/**
20			* LimitBy constructor.
21			*
22			* @param $count
23			*/
24			public function __construct($count)
25			{
26			$this->count = $count;
27			}
28
29			/**
30			* @param Builder $model
31			* @param RepositoryInterface $repository
32			*
33			* @return Builder
34			*/
35			public function apply($model, RepositoryInterface $repository): Builder
36			{
37			if ($this->count) {
38			return $model->limit($this->count);
			0 ignored issues – show Bug Best Practice introduced 2019-02-09 20:16 UTC by Report Bug Copy Issue Report The expression `return $model->limit($this->count)` could return the type `Illuminate\Database\Query\Builder` which is incompatible with the type-hinted return `Illuminate\Database\Eloquent\Builder`. Consider adding an additional type-check to rule them out. Loading history...
39			}
40
41			return $model;
42			}
43			}
44

noitran / micro-repositories

Push — master ( e7b285...ac21bd )

LimitBy::apply() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like