LimitBy::__construct() - Code Metrics - Inspection of "Fixes in Criteria. Added tests." - noitran/micro-repositories - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 36df2b...89c2b4 )

by noitran

created 2019-02-13 20:33 UTC

LimitBy::__construct() A

↳ Parent: LimitBy

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace Noitran\Repositories\Criteria;

use Noitran\Repositories\Contracts\Criteria\CriteriaInterface;
use Noitran\Repositories\Contracts\Repository\RepositoryInterface;
use Illuminate\Database\Eloquent\Builder;

/**
 * Class LimitBy.
 */
class LimitBy implements CriteriaInterface
{
    /**
     * @var string
     */
    protected $count;

    /**
     * LimitBy constructor.
     *
     * @param $count
     */
    public function __construct($count)
    {
        $this->count = $count;
    }

    /**
     * @param Builder $model
     * @param RepositoryInterface $repository
     *
     * @return Builder
     */
    public function apply($model, RepositoryInterface $repository): Builder
    {
        if ($this->count) {
            return $model->limit($this->count);

        }

        return $model;
    }
}


1		<?php
2
3		namespace Noitran\Repositories\Criteria;
4
5		use Noitran\Repositories\Contracts\Criteria\CriteriaInterface;
6		use Noitran\Repositories\Contracts\Repository\RepositoryInterface;
7		use Illuminate\Database\Eloquent\Builder;
8
9		/**
10		* Class LimitBy.
11		*/
12		class LimitBy implements CriteriaInterface
13		{
14		/**
15		* @var string
16		*/
17		protected $count;
18
19		/**
20		* LimitBy constructor.
21		*
22		* @param $count
23		*/
24	1	public function __construct($count)
25		{
26	1	$this->count = $count;
27	1	}
28
29		/**
30		* @param Builder $model
31		* @param RepositoryInterface $repository
32		*
33		* @return Builder
34		*/
35	1	public function apply($model, RepositoryInterface $repository): Builder
36		{
37	1	if ($this->count) {
38	1	return $model->limit($this->count);
		0 ignored issues – show Bug Best Practice introduced 2019-02-09 20:16 UTC by Report Bug Copy Issue Report The expression `return $model->limit($this->count)` could return the type `Illuminate\Database\Query\Builder` which is incompatible with the type-hinted return `Illuminate\Database\Eloquent\Builder`. Consider adding an additional type-check to rule them out. Loading history...
39		}
40
41		return $model;
42		}
43		}
44

noitran / micro-repositories

Push — master ( 36df2b...89c2b4 )

LimitBy::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like