Noitran\Repositories\Criteria\ListOfValues

Complexity

Total Complexity

3

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	apply()	0	5	1
A	getValues()	0	3	1
A	__construct()	0	3	1

<?php

namespace Noitran\Repositories\Criteria;

use Noitran\Repositories\Contracts\Criteria\CriteriaInterface;
use Noitran\Repositories\Contracts\Repository\RepositoryInterface;
use Illuminate\Database\Eloquent\Builder;

/**
 * Class ListOfValues
 */
abstract class ListOfValues implements CriteriaInterface
{
    /**
     * @var array
     */
    protected $values;

    /**
     * ListOfValues constructor.
     *
     * @param string $valueList Comma separated sting of values
     */
    final public function __construct($valueList)
    {
        $this->values = explode(',', $valueList);
    }

    /**
     * Returns field name in schema
     *
     * @return mixed
     */
    abstract protected function getField(): string;

    /**
     * @return array
     */
    public function getValues(): array
    {
        return $this->values;
    }

    /**
     * @param Builder $model
     * @param RepositoryInterface $repository
     *
     * @return Builder
     */
    public function apply($model, RepositoryInterface $repository): Builder
    {
        $column = $repository->getColumnName($this->getField(), $model);

The method getColumnName() does not exist on Noitran\Repositories\Contracts\Repository\RepositoryInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Noitran\Repositories\Tests\Stubs\Repositories\UserRepository. Are you sure you never get one of those?

        return $model->whereIn($column, $this->getValues());

The expression return $model->whereIn($column, $this->getValues()) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

    }
}