Nofw\Session\CacheSessionHandler

Complexity

Total Complexity

14

Size/Duplication

Total Lines	114
Duplicated Lines	51.75 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	close()	0	4	1
A	destroy()	17	17	3
A	gc()	0	4	1
A	open()	0	4	1
A	read()	21	21	4
A	write()	21	21	3

<?php

namespace Nofw\Session;

use Psr\Cache\CacheItemPoolInterface;
use Psr\Cache\InvalidArgumentException;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;

/**
 * PSR-6 Session handler implementation.
 *
 * @author Márk Sági-Kazár <mark.sagikazar@gmail.com>
 */
final class CacheSessionHandler implements \SessionHandlerInterface, LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * @var CacheItemPoolInterface
     */
    private $pool;

    /**
     * @param CacheItemPoolInterface $pool
     * @param LoggerInterface|null   $logger
     */
    public function __construct(CacheItemPoolInterface $pool, LoggerInterface $logger = null)
    {
        $this->pool = $pool;
        $this->logger = $logger ?? new NullLogger();
    }

    /**
     * {@inheritdoc}
     */
    public function close()
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function destroy($session_id)

This method seems to be duplicated in your project.

    {
        try {
            return $this->pool->deleteItem($session_id);
        } catch (InvalidArgumentException $e) {
            $this->logger->error(
                $e->getMessage(),
                [
                    'exception' => $e,
                    'session_id' => is_scalar($session_id) ? $session_id : '** Non scalar session ID **',
                    'operation' => 'destroy',
                ]
            );

            return false;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function gc($maxlifetime)
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function open($save_path, $name)
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function read($session_id)

This method seems to be duplicated in your project.

    {
        try {
            $item = $this->pool->getItem($session_id);

            if ($item->isHit()) {
                return $item->get();
            }
        } catch (InvalidArgumentException $e) {
            $this->logger->error(
                $e->getMessage(),
                [
                    'exception' => $e,
                    'session_id' => is_scalar($session_id) ? $session_id : '** Non scalar session ID **',
                    'operation' => 'read',
                ]
            );
        }

        return '';
    }

    /**
     * {@inheritdoc}
     */
    public function write($session_id, $session_data)

This method seems to be duplicated in your project.

    {
        try {
            $item = $this->pool->getItem($session_id);

            $item->set($session_data);

            return $this->pool->save($item);
        } catch (InvalidArgumentException $e) {
            $this->logger->error(
                $e->getMessage(),

The method getMessage() does not seem to exist on object<Psr\Cache\InvalidArgumentException>.

                [
                    'exception' => $e,
                    'session_id' => is_scalar($session_id) ? $session_id : '** Non scalar session ID **',
                    'operation' => 'write',
                ]
            );

            return false;
        }
    }
}