nobuhiko / ec-cube

src/Eccube/Form/Type/Admin/ChangePasswordType.php

Unused Use Statements -2 removed lines

@@ -25,8 +25,6 @@
 
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
-use Symfony\Component\Form\FormError;
-use Symfony\Component\Form\FormEvents;
 use Symfony\Component\OptionsResolver\OptionsResolverInterface;
 use Symfony\Component\Security\Core\Validator\Constraints\UserPassword;
 use Symfony\Component\Validator\Constraints as Assert;

Doc Comments +3 added lines

@@ -35,6 +35,9 @@
 {
     private $app;
 
+    /**
+     * @param \Silex\Application $app
+     */
     public function __construct($app)
     {
         $this->app = $app;

src/Eccube/Form/Type/Admin/PaymentRegisterType.php

Doc Comments +3 added lines

@@ -36,6 +36,9 @@
 {
     protected $app;
 
+    /**
+     * @param \Silex\Application $app
+     */
     public function __construct($app)
     {
         $this->app = $app;

src/Eccube/Form/Type/Admin/SearchProductType.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\Extension\Core\Type;
 use Symfony\Component\Form\FormBuilderInterface;
-use Symfony\Component\Validator\Constraints as Assert;
 
 class SearchProductType extends AbstractType
 {

src/Eccube/Application.php

Doc Comments +1 added lines, -1 removed lines

@@ -953,7 +953,7 @@
      * 失敗 : \Doctrine\DBAL\DBALExceptionエラーが発生( 接続に失敗した場合 )、エラー画面を表示しdie()
      * 備考 : app['debug']がtrueの際は処理を行わない
      *
-     * @return boolean true
+     * @return null|boolean true
      *
      */
     protected function checkDatabaseConnection()

src/Eccube/Service/PluginService.php

Doc Comments +21 added lines

@@ -37,6 +37,9 @@ 
     const EVENT_YML = 'event.yml';
     private $app;
 
+    /**
+     * @param \Silex\Application $app
+     */
     public function __construct($app)
     {
         $this->app = $app;
@@ -102,6 +105,9 @@ 
         }
     }
 
+    /**
+     * @param string $dir
+     */
     public function unpackPluginArchive($archive, $dir)
     {
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -120,6 +126,9 @@ 
         }
     }
 
+    /**
+     * @param string $dir
+     */
     public function checkPluginArchiveContent($dir, array $config_cache = array())
     {
         try {
@@ -161,6 +170,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -178,6 +190,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -197,6 +212,9 @@ 
         return $this->app['config']['plugin_realdir'].'/'.$name;
     }
 
+    /**
+     * @param string $d
+     */
     public function createPluginDir($d)
     {
         $b = @mkdir($d);
@@ -256,6 +274,9 @@ 
         return $p;
     }
 
+    /**
+     * @param string $method
+     */
     public function callPluginManagerMethod($meta, $method)
     {
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';

src/Eccube/Command/GeneratorCommand/AbstractPluginGenerator.php

Doc Comments +2 added lines, -2 removed lines

@@ -348,7 +348,7 @@ 
      * @param array $metadatas
      * @param array $fsList
      * @param $pluginCode
-     * @param $codePath
+     * @param string $codePath
      */
     protected function generateMigration(array $metadatas, array &$fsList = array(), $pluginCode, $codePath)
     {
@@ -373,7 +373,7 @@ 
      *
      * @param $pluginCode
      * @param array $metadatas
-     * @return mixed|string
+     * @return string
      */
     protected function makeMigration($pluginCode, array $metadatas)
     {

src/Eccube/Command/PluginCommand.php

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\Question;
-use Symfony\Component\Validator\Constraints as Assert;
 
 class PluginCommand extends \Knp\Command\Command
 {

src/Eccube/Controller/Admin/Product/CsvImportController.php

Doc Comments +12 added lines

@@ -590,6 +590,8 @@ 
     /**
      * 登録、更新時のエラー画面表示
      *
+     * @param Application $app
+     * @param string $twig
      */
     protected function render($app, $form, $headers, $twig)
     {
@@ -621,6 +623,7 @@ 
      * アップロードされたCSVファイルの行ごとの処理
      *
      * @param $formFile
+     * @param Application $app
      * @return CsvImportService
      */
     protected function getImportData($app, $formFile)
@@ -666,6 +669,7 @@ 
 
     /**
      * 商品画像の削除、登録
+     * @param CsvImportService $data
      */
     protected function createProductImage($row, Product $Product, $data)
     {
@@ -710,6 +714,8 @@ 
 
     /**
      * 商品カテゴリの削除、登録
+     * @param Application $app
+     * @param CsvImportService $data
      */
     protected function createProductCategory($row, Product $Product, $app, $data)
     {
@@ -809,6 +815,8 @@ 
 
     /**
      * 商品規格分類1、商品規格分類2がnullとなる商品規格情報を作成
+     * @param Application $app
+     * @param CsvImportService $data
      */
     protected function createProductClass($row, Product $Product, $app, $data, $ClassCategory1 = null, $ClassCategory2 = null)
     {
@@ -950,6 +958,8 @@ 
 
     /**
      * 商品規格情報を更新
+     * @param Application $app
+     * @param CsvImportService $data
      */
     protected function updateProductClass($row, Product $Product, ProductClass $ProductClass, $app, $data)
     {
@@ -1096,6 +1106,7 @@ 
     /**
      * 登録、更新時のエラー画面表示
      *
+     * @param string $message
      */
     protected function addErrors($message)
     {
@@ -1170,6 +1181,7 @@ 
      * ProductCategory作成
      * @param \Eccube\Entity\Product $Product
      * @param \Eccube\Entity\Category $Category
+     * @param integer $rank
      * @return ProductCategory
      */
     private function makeProductCategory($Product, $Category, $rank)

src/Eccube/Controller/Admin/Product/ProductClassController.php

Doc Comments +5 added lines

@@ -531,6 +531,9 @@ 
     /**
      * 登録、更新時のエラー画面表示
      *
+     * @param Application $app
+     * @param boolean $not_product_class
+     * @param \Symfony\Component\Form\FormInterface $classForm
      */
     protected function render($app, $Product, $ProductClass, $not_product_class, $classForm, $error = null)
     {
@@ -582,6 +585,7 @@ 
 
     /**
      * 規格1と規格2を組み合わせた商品規格を作成
+     * @param Application $app
      */
     private function createProductClasses($app, Product $Product, ClassName $ClassName1 = null, ClassName $ClassName2 = null)
     {
@@ -669,6 +673,7 @@ 
      *
      * @param $productClassDest コピー先となる商品規格
      * @param $productClassOrig コピー元となる商品規格
+     * @param Application $app
      */
     private function setDefualtProductClass($app, $productClassDest, $productClassOrig) {
         $productClassDest->setDeliveryDate($productClassOrig->getDeliveryDate());