Nnx\JmsSerializerModule\Serializer\JmsSerializerAbstractFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	canCreateServiceWithName()	0	4	1
B	createServiceWithName()	0	31	2

<?php
/**
 * @link    https://github.com/nnx-framework/jms-serializer-module
 * @author  Malofeykin Andrey  <and-rey2@yandex.ru>
 */
namespace Nnx\JmsSerializerModule\Serializer;

use Nnx\ModuleOptions\ModuleOptionsPluginManagerInterface;
use Zend\Serializer\Adapter\AdapterInterface;
use Zend\ServiceManager\AbstractFactoryInterface;
use Zend\ServiceManager\AbstractPluginManager;
use Zend\ServiceManager\ServiceLocatorInterface;
use Nnx\JmsSerializerModule\Options\ModuleOptions;

/**
 * Class JmsSerializerAbstractFactory
 *
 * @package Nnx\JmsSerializerModule\Serializer
 */
class JmsSerializerAbstractFactory implements AbstractFactoryInterface
{
    /**
     * @inheritdoc
     *
     * @param ServiceLocatorInterface $serviceLocator
     * @param                         $name
     * @param                         $requestedName
     *
     * @return bool|void
     */
    public function canCreateServiceWithName(ServiceLocatorInterface $serviceLocator, $name, $requestedName)
    {
        return 0 === strpos($requestedName, 'nnxJmsSerializer.serializers.');
    }

    /**
     * @inheritdoc
     *
     * @param ServiceLocatorInterface $serviceLocator
     * @param                         $name
     * @param                         $requestedName
     *
     * @return AdapterInterface
     * @throws \Nnx\JmsSerializerModule\Options\Exception\InvalidArgumentException
     * @throws \Zend\ServiceManager\Exception\ServiceNotFoundException
     */
    public function createServiceWithName(ServiceLocatorInterface $serviceLocator, $name, $requestedName)
    {
        $appServiceLocator = $serviceLocator instanceof AbstractPluginManager ? $serviceLocator->getServiceLocator() : $serviceLocator;

        $jmsSerializerName = substr($requestedName, 29);

        /** @var  ModuleOptionsPluginManagerInterface $moduleOptionsManager */
        $moduleOptionsManager = $appServiceLocator->get(ModuleOptionsPluginManagerInterface::class);

        /** @var ModuleOptions $moduleOptions */
        $moduleOptions = $moduleOptionsManager->get(ModuleOptions::class);

        $serializerConfig = $moduleOptions->getSerializer($jmsSerializerName);

        $options = $serializerConfig->getOptions();
        $serializer = $serviceLocator->get(

The expression $serviceLocator->get($serializerConfig->getName(), array('metadataFactory' => $options->getMetadataFactory(), 'handlerRegistry' => $options->getHandlerRegistry(), 'objectConstructor' => $options->getObjectConstructor(), 'serializationVisitors' => $options->getSerializationVisitors(), 'deserializationVisitors' => $options->getDeserializationVisitors(), 'eventDispatcher' => $options->getEventDispatcher(), 'typeParser' => $options->getTypeParser())); of type object|array adds the type array to the return on line 76 which is incompatible with the return type documented by Nnx\JmsSerializerModule\Serializer\JmsSerializerAbstractFactory::createServiceWithName of type Zend\Serializer\Adapter\AdapterInterface.

            $serializerConfig->getName(),
            [

The call to ServiceLocatorInterface::get() has too many arguments starting with array('metadataFactory' => $options->getMetadataFactory(), 'handlerRegistry' => $options->getHandlerRegistry(), 'objectConstructor' => $options->getObjectConstructor(), 'serializationVisitors' => $options->getSerializationVisitors(), 'deserializationVisitors' => $options->getDeserializationVisitors(), 'eventDispatcher' => $options->getEventDispatcher(), 'typeParser' => $options->getTypeParser()).

                'metadataFactory' => $options->getMetadataFactory(),
                'handlerRegistry' => $options->getHandlerRegistry(),
                'objectConstructor' => $options->getObjectConstructor(),
                'serializationVisitors' => $options->getSerializationVisitors(),
                'deserializationVisitors' => $options->getDeserializationVisitors(),
                'eventDispatcher'  => $options->getEventDispatcher(),
                'typeParser' => $options->getTypeParser()
            ]
        );


        return $serializer;
    }
}