Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | View Code Duplication | class InsertElement extends AbstractDiffElement implements InsertedElementInterface |
|
|
|||
17 | { |
||
18 | /** |
||
19 | * Возвращает добавленный элемент |
||
20 | * |
||
21 | * @var ElementInterface |
||
22 | */ |
||
23 | private $insertedElement; |
||
24 | |||
25 | /** |
||
26 | * Возвращает добавленный элемент (нет в форме которую сравнивают, но есть в форме с которой сравнивают) |
||
27 | * |
||
28 | * @return ElementInterface |
||
29 | */ |
||
30 | public function getInsertedElement() |
||
34 | |||
35 | /** |
||
36 | * InsertElement constructor. |
||
37 | * |
||
38 | * @param DiffElementBuilder $diffBuilder |
||
39 | */ |
||
40 | public function __construct(DiffElementBuilder $diffBuilder) |
||
46 | |||
47 | /** |
||
48 | * Определяет является ли diff для коллекции или для элемента формы |
||
49 | * |
||
50 | * @return bool |
||
51 | */ |
||
52 | public function isCollection() |
||
56 | |||
57 | /** |
||
58 | * Определяет какое действие было соверешенно с элементом (элемент был добавлен, изменен, удален) |
||
59 | * |
||
60 | * @return bool |
||
61 | */ |
||
62 | public function getMode() |
||
66 | } |
||
67 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.