Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | View Code Duplication | class InsertCollection extends AbstractDiffElement implements InsertedElementInterface |
|
|
|||
18 | { |
||
19 | /** |
||
20 | * Добавленная коллекция |
||
21 | * |
||
22 | * @var Collection |
||
23 | */ |
||
24 | private $insertedCollection; |
||
25 | |||
26 | /** |
||
27 | * Элементы добавленной коллекции |
||
28 | * |
||
29 | * @var InsertElement[] |
||
30 | */ |
||
31 | private $insertedElements = []; |
||
32 | |||
33 | /** |
||
34 | * Возвращает элементы добавленной коллекции |
||
35 | * |
||
36 | * @return InsertElement[] |
||
37 | */ |
||
38 | public function getInsertedElements() |
||
42 | /** |
||
43 | * Возвращает добавленную коллекцию (нет в форме которую сравнивают, но есть в форме с которой сравнивают) |
||
44 | * |
||
45 | * @return Collection |
||
46 | */ |
||
47 | public function getInsertedCollection() |
||
51 | |||
52 | /** |
||
53 | * InsertElement constructor. |
||
54 | * |
||
55 | * @param DiffElementBuilder $diffBuilder |
||
56 | */ |
||
57 | public function __construct(DiffElementBuilder $diffBuilder) |
||
63 | |||
64 | |||
65 | /** |
||
66 | * Определяет является ли diff для коллекции или для элемента формы |
||
67 | * |
||
68 | * @return bool |
||
69 | */ |
||
70 | public function isCollection() |
||
74 | |||
75 | |||
76 | /** |
||
77 | * Определяет какое действие было соверешенно с элементом (элемент был добавлен, изменен, удален) |
||
78 | * |
||
79 | * @return bool |
||
80 | */ |
||
81 | public function getMode() |
||
85 | } |
||
86 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.