ExecutorController::runExecutorAction() - Code Metrics - Inspection of "Добавлен менеджер плагинов для работы с инициалайз..." - nnx-framework/doctrine-fixture-module - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 14e4a6...854686 )

by Андрей

created 2016-04-26 16:01 UTC

ExecutorController::runExecutorAction() A

↳ Parent: ExecutorController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	1
nc	1
nop	0

<?php
/**
 * @link    https://github.com/nnx-framework/doctrine-fixture-module
 * @author  Malofeykin Andrey  <[email protected]>
 */
namespace Nnx\DoctrineFixtureModule\Controller;

use Nnx\DoctrineFixtureModule\Executor\FixtureExecutorManagerInterface;
use Nnx\DoctrineFixtureModule\Utils\ManagerRegistryProviderInterface;
use Zend\Mvc\Controller\AbstractConsoleController;
use Zend\Console\Request as ConsoleRequest;

/**
 * Class ExecutorController
 *
 * @package Nnx\DoctrineFixtureModule\Entity
 *
 */
class ExecutorController extends AbstractConsoleController
{
    /**
     * Провайдер для получения ManagerRegistry
     *
     * @var ManagerRegistryProviderInterface
     */
    protected $managerRegistryProvider;

    /**
     * Менеджер для получения Executor'ов
     *
     * @var FixtureExecutorManagerInterface
     */
    protected $fixtureExecutorManager;

    /**
     * Разрешенные методы
     *
     * @var array
     */
    protected $allowedMethod = [
        'import',
        'purge'
    ];

    /**
     * ExecutorController constructor.
     *
     * @param ManagerRegistryProviderInterface $managerRegistryProvider
     * @param FixtureExecutorManagerInterface  $fixtureExecutorManager
     */
    public function __construct(ManagerRegistryProviderInterface $managerRegistryProvider, FixtureExecutorManagerInterface $fixtureExecutorManager)
    {
        $this->setManagerRegistryProvider($managerRegistryProvider);
        $this->setFixtureExecutorManager($fixtureExecutorManager);
    }

    /**
     *
     *
     */
    public function executeFixtureAction()
    {
        $request = $this->getRequest();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }


    /**
     *
     *
     * @throws \Nnx\DoctrineFixtureModule\Controller\Exception\RuntimeException
     */
    public function runExecutorAction()
    {
        $request = $this->getRequest();
        if (!$request instanceof ConsoleRequest) {
            $errMsg = 'Request is not console';
            throw new Exception\RuntimeException($errMsg);
        }

        $executorName = $request->getParam('executorName', null);
        if (null === $executorName) {
            $errMsg = 'Executor name is not defined';
            throw new Exception\RuntimeException($errMsg);
        }
        $method       = $request->getParam('method', null);
        if (null === $method) {
            $errMsg = 'Executor method not defined';
            throw new Exception\RuntimeException($errMsg);
        }
        $normalizeMethod = strtolower($method);
        if (!in_array($normalizeMethod, $this->allowedMethod, true)) {
            $errMsg = sprintf('Invalid executor method %s', $method);
            throw new Exception\RuntimeException($errMsg);
        }

        $objectManager = $request->getParam('object-manager', null);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $executor = $this->getFixtureExecutorManager()->get($executorName);

        switch ($method) {
            case 'import': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B": //right
        doSomething();
        break;
}
                $executor->import();
                break;
            }
            case 'purge': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B": //right
        doSomething();
        break;
}
                $executor->purge();
                break;
            }
        }
    }

    /**
     * Возвращает провайдер для получения ManagerRegistry
     *
     * @return ManagerRegistryProviderInterface
     */
    public function getManagerRegistryProvider()
    {
        return $this->managerRegistryProvider;
    }

    /**
     * Устанавливает провайдер для получения ManagerRegistry
     *
     * @param ManagerRegistryProviderInterface $managerRegistryProvider
     *
     * @return $this
     */
    public function setManagerRegistryProvider(ManagerRegistryProviderInterface $managerRegistryProvider)
    {
        $this->managerRegistryProvider = $managerRegistryProvider;

        return $this;
    }

    /**
     * Возвращает менеджер для получения Executor'ов
     *
     * @return FixtureExecutorManagerInterface
     */
    public function getFixtureExecutorManager()
    {
        return $this->fixtureExecutorManager;
    }

    /**
     * Устанавливает менеджер для получения Executor'ов
     *
     * @param FixtureExecutorManagerInterface $fixtureExecutorManager
     *
     * @return $this
     */
    public function setFixtureExecutorManager($fixtureExecutorManager)
    {
        $this->fixtureExecutorManager = $fixtureExecutorManager;

        return $this;
    }
}


1			<?php
2			/**
3			* @link https://github.com/nnx-framework/doctrine-fixture-module
4			* @author Malofeykin Andrey <[email protected]>
5			*/
6			namespace Nnx\DoctrineFixtureModule\Controller;
7
8			use Nnx\DoctrineFixtureModule\Executor\FixtureExecutorManagerInterface;
9			use Nnx\DoctrineFixtureModule\Utils\ManagerRegistryProviderInterface;
10			use Zend\Mvc\Controller\AbstractConsoleController;
11			use Zend\Console\Request as ConsoleRequest;
12
13			/**
14			* Class ExecutorController
15			*
16			* @package Nnx\DoctrineFixtureModule\Entity
17			*
18			*/
19			class ExecutorController extends AbstractConsoleController
20			{
21			/**
22			* Провайдер для получения ManagerRegistry
23			*
24			* @var ManagerRegistryProviderInterface
25			*/
26			protected $managerRegistryProvider;
27
28			/**
29			* Менеджер для получения Executor'ов
30			*
31			* @var FixtureExecutorManagerInterface
32			*/
33			protected $fixtureExecutorManager;
34
35			/**
36			* Разрешенные методы
37			*
38			* @var array
39			*/
40			protected $allowedMethod = [
41			'import',
42			'purge'
43			];
44
45			/**
46			* ExecutorController constructor.
47			*
48			* @param ManagerRegistryProviderInterface $managerRegistryProvider
49			* @param FixtureExecutorManagerInterface $fixtureExecutorManager
50			*/
51			public function __construct(ManagerRegistryProviderInterface $managerRegistryProvider, FixtureExecutorManagerInterface $fixtureExecutorManager)
52			{
53			$this->setManagerRegistryProvider($managerRegistryProvider);
54			$this->setFixtureExecutorManager($fixtureExecutorManager);
55			}
56
57			/**
58			*
59			*
60			*/
61			public function executeFixtureAction()
62			{
63			$request = $this->getRequest();
			0 ignored issues – show Unused Code introduced 2016-04-26 16:04 UTC by Report Bug Copy Issue Report `$request` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
64			}
65
66
67			/**
68			*
69			*
70			* @throws \Nnx\DoctrineFixtureModule\Controller\Exception\RuntimeException
71			*/
72			public function runExecutorAction()
73			{
74			$request = $this->getRequest();
75			if (!$request instanceof ConsoleRequest) {
76			$errMsg = 'Request is not console';
77			throw new Exception\RuntimeException($errMsg);
78			}
79
80			$executorName = $request->getParam('executorName', null);
81			if (null === $executorName) {
82			$errMsg = 'Executor name is not defined';
83			throw new Exception\RuntimeException($errMsg);
84			}
85			$method = $request->getParam('method', null);
86			if (null === $method) {
87			$errMsg = 'Executor method not defined';
88			throw new Exception\RuntimeException($errMsg);
89			}
90			$normalizeMethod = strtolower($method);
91			if (!in_array($normalizeMethod, $this->allowedMethod, true)) {
92			$errMsg = sprintf('Invalid executor method %s', $method);
93			throw new Exception\RuntimeException($errMsg);
94			}
95
96			$objectManager = $request->getParam('object-manager', null);
			0 ignored issues – show Unused Code introduced 2016-04-26 16:04 UTC by Report Bug Copy Issue Report `$objectManager` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
97
98			$executor = $this->getFixtureExecutorManager()->get($executorName);
99
100			switch ($method) {
101			case 'import': {
			0 ignored issues – show Coding Style introduced 2016-04-26 16:04 UTC by Report Bug Copy Issue Report CASE statements must be defined using a colon As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
102			$executor->import();
103			break;
104			}
105			case 'purge': {
			0 ignored issues – show Coding Style introduced 2016-04-26 16:04 UTC by Report Bug Copy Issue Report CASE statements must be defined using a colon As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
106			$executor->purge();
107			break;
108			}
109			}
110			}
111
112			/**
113			* Возвращает провайдер для получения ManagerRegistry
114			*
115			* @return ManagerRegistryProviderInterface
116			*/
117			public function getManagerRegistryProvider()
118			{
119			return $this->managerRegistryProvider;
120			}
121
122			/**
123			* Устанавливает провайдер для получения ManagerRegistry
124			*
125			* @param ManagerRegistryProviderInterface $managerRegistryProvider
126			*
127			* @return $this
128			*/
129			public function setManagerRegistryProvider(ManagerRegistryProviderInterface $managerRegistryProvider)
130			{
131			$this->managerRegistryProvider = $managerRegistryProvider;
132
133			return $this;
134			}
135
136			/**
137			* Возвращает менеджер для получения Executor'ов
138			*
139			* @return FixtureExecutorManagerInterface
140			*/
141			public function getFixtureExecutorManager()
142			{
143			return $this->fixtureExecutorManager;
144			}
145
146			/**
147			* Устанавливает менеджер для получения Executor'ов
148			*
149			* @param FixtureExecutorManagerInterface $fixtureExecutorManager
150			*
151			* @return $this
152			*/
153			public function setFixtureExecutorManager($fixtureExecutorManager)
154			{
155			$this->fixtureExecutorManager = $fixtureExecutorManager;
156
157			return $this;
158			}
159			}
160

nnx-framework / doctrine-fixture-module

Push — dev ( 14e4a6...854686 )

ExecutorController::runExecutorAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like