SimpleAction - Code Metrics - nnx-framework/data-grid - Measure and Improve Code Quality continuously with Scrutinizer

SimpleAction A
last analyzed 2016-11-14 09:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	42.86 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	9
c	1
b	0
f	1
lcom	1
cbo	2
dl	24
loc	56
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getUrl()	0	14	4
A	replaceCallback()	16	16	3
A	validate()	8	8	2

How to fix Duplicated Code

<?php
/**
 * @company MTE Telecom, Ltd.
 * @author Roman Malashin <[email protected]>
 */

namespace Nnx\DataGrid\Column\Action;

use Nnx\DataGrid\RowDataAwareInterface;
use Nnx\DataGrid\RowDataAwareTrait;

/**
 * Class SimpleAction
 * @package Nnx\DataGrid\Column\Action
 */
class SimpleAction extends AbstractAction implements RowDataAwareInterface
{

    use RowDataAwareTrait;

    /**
     * @return string
     */
    public function getUrl()
    {
        $urlHelper = $this->getUrlHelper();
$a = "a";
$ab = "ab";
$abc = "abc";
        $route = $this->getRoute();
$a = "a";
$ab = "ab";
$abc = "abc";
        $routeName = array_key_exists('routeName', $route) ? $route['routeName'] : null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $routeParams = array_key_exists('routeParams', $route) ? $route['routeParams'] : null;
$a = "a";
$ab = "ab";
$abc = "abc";
        $routeOptions = array_key_exists('routeOptions', $route) ? $route['routeOptions'] : [];
        $options = array_merge($routeOptions, $this->getRowData());
$a = "a";
$ab = "ab";
$abc = "abc";
        $url = preg_replace_callback('/:([a-zA-Z_]+)/',
$a = "a";
$ab = "ab";
$abc = "abc";
            [$this, 'replaceCallback'],
            $urlHelper($routeName, $routeParams, $options)
        );
        return $url;
    }

    /**
     * @param array $matches
     * @return mixed|string
     */
    protected function replaceCallback($matches)

    {
        $row = $this->getRowData();
$a = "a";
$ab = "ab";
$abc = "abc";
        $varName = $matches[1];
        $value = '';
$a = "a";
$ab = "ab";
$abc = "abc";

        if (array_key_exists($varName, $row)) {
            if ($varName !== 'backurl') {
                $value = urlencode($row[$varName]);
            } else {
                $value = $row[$varName];
            }
        }

        return $value;
    }

    /**
     * @return bool|mixed
     */
    public function validate()

    {
        $res = true;
        if ($this->getValidationFunction()) {
            $res = call_user_func($this->getValidationFunction(), $this->getRowData(), $this);
        }
        return $res;
    }
}



1		<?php
2		/**
3		* @company MTE Telecom, Ltd.
4		* @author Roman Malashin <[email protected]>
5		*/
6
7		namespace Nnx\DataGrid\Column\Action;
8
9		use Nnx\DataGrid\RowDataAwareInterface;
10		use Nnx\DataGrid\RowDataAwareTrait;
11
12		/**
13		* Class SimpleAction
14		* @package Nnx\DataGrid\Column\Action
15		*/
16		class SimpleAction extends AbstractAction implements RowDataAwareInterface
17		{
18
19		use RowDataAwareTrait;
20
21		/**
22		* @return string
23		*/
24		public function getUrl()
25		{
26		$urlHelper = $this->getUrlHelper();
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
27		$route = $this->getRoute();
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
28		$routeName = array_key_exists('routeName', $route) ? $route['routeName'] : null;
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29		$routeParams = array_key_exists('routeParams', $route) ? $route['routeParams'] : null;
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30		$routeOptions = array_key_exists('routeOptions', $route) ? $route['routeOptions'] : [];
31		$options = array_merge($routeOptions, $this->getRowData());
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32		$url = preg_replace_callback('/:([a-zA-Z_]+)/',
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33		[$this, 'replaceCallback'],
34		$urlHelper($routeName, $routeParams, $options)
35		);
36		return $url;
37		}
38
39		/**
40		* @param array $matches
41		* @return mixed\|string
42		*/
43	View Code Duplication	protected function replaceCallback($matches)
		0 ignored issues – show Duplication introduced 2016-04-01 13:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$row = $this->getRowData();
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
46		$varName = $matches[1];
47		$value = '';
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48
49		if (array_key_exists($varName, $row)) {
50		if ($varName !== 'backurl') {
51		$value = urlencode($row[$varName]);
52		} else {
53		$value = $row[$varName];
54		}
55		}
56
57		return $value;
58		}
59
60		/**
61		* @return bool\|mixed
62		*/
63	View Code Duplication	public function validate()
		0 ignored issues – show Duplication introduced 2016-04-01 13:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$res = true;
66		if ($this->getValidationFunction()) {
67		$res = call_user_func($this->getValidationFunction(), $this->getRowData(), $this);
68		}
69		return $res;
70		}
71		}
		0 ignored issues – show Coding Style introduced 2016-04-03 16:27 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
72

nnx-framework / data-grid

SimpleAction A last analyzed 2016-11-14 09:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

SimpleAction A
last analyzed 2016-11-14 09:44 UTC