Nnx\Container\EntryNameResolver\ResolverByModuleContextMapFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	34
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	createService()	23	23	2

<?php
/**
 * @link    https://github.com/nnx-framework/container
 * @author  Malofeykin Andrey  <and-rey2@yandex.ru>
 */
namespace Nnx\Container\EntryNameResolver;

use Zend\ServiceManager\AbstractPluginManager;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use Nnx\ModuleOptions\ModuleOptionsPluginManagerInterface;
use Nnx\Container\Options\ModuleOptions;
use Nnx\EntryNameResolver\ResolverByModuleContextMap as BaseResolverByModuleContextMap;


/**
 * Class ResolverByModuleContextMapFactory
 *
 * @package Nnx\Container\EntryNameResolver
 */
class ResolverByModuleContextMapFactory implements FactoryInterface

This class seems to be duplicated in your project.

{
    /**
     * @inheritdoc
     *
     * @param ServiceLocatorInterface $serviceLocator
     *
     * @return ResolverByModuleContextMap
     * @throws \Zend\ServiceManager\Exception\ServiceNotFoundException
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $appServiceLocator = $serviceLocator;
        if ($serviceLocator instanceof AbstractPluginManager) {
            $appServiceLocator = $serviceLocator->getServiceLocator();
        }

        /** @var ModuleOptionsPluginManagerInterface $moduleOptionsPluginManager */
        $moduleOptionsPluginManager = $appServiceLocator->get(ModuleOptionsPluginManagerInterface::class);

        /** @var ModuleOptions $moduleOptions */
        $moduleOptions = $moduleOptionsPluginManager->get(ModuleOptions::class);
        $contextMap = $moduleOptions->getContextMap();

        $creationOptions = [
            'contextMap' => $contextMap,
            'className' => ResolverByModuleContextMap::class
        ];

        $entryNameResolverChain = $serviceLocator->get(BaseResolverByModuleContextMap::class, $creationOptions);

The call to ServiceLocatorInterface::get() has too many arguments starting with $creationOptions.

The expression $serviceLocator->get(\Nnx\EntryNameResolver\ResolverByModuleContextMap::class, $creationOptions); of type object|array adds the type array to the return on line 52 which is incompatible with the return type documented by Nnx\Container\EntryNameResolver\ResolverByModuleContextMapFactory::createService of type Nnx\Container\EntryNameResolver\ResolverByModuleContextMap.

        return $entryNameResolverChain;
    }
}