Gojira\Jira\Response\TransitionResponse

Complexity

Total Complexity

12

Size/Duplication

Total Lines	95
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	render()	19	19	6
B	renderListTransitions()	32	32	4
A	renderDoTransition()	23	23	2

<?php
/**
 * Copyright © 2017 Toan Nguyen. All rights reserved.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gojira\Jira\Response;

use Gojira\Api\Response\BaseResponse;
use Gojira\Api\Response\ResponseInterface;
use Symfony\Component\Console\Helper\TableCell;

/**
 * Render result for JIRA REST /transitions
 *
 * @package Gojira\Jira\Response
 * @author  Toan Nguyen <me@nntoan.com>
 */
class TransitionResponse extends IssueResponse implements ResponseInterface

This class seems to be duplicated in your project.

{
    /**
     * {@inheritdoc}
     */
    public function render($type = null)
    {
        switch ($type) {
            case 'issue:transit:get':
                $result = $this->renderListTransitions();
                break;
            case 'issue:transit:start':
            case 'issue:transit:stop':
            case 'issue:transit:review':
            case 'issue:transit:done':
                $result = $this->renderDoTransition();
                break;
            default:
                $result = $this->renderNothing();

Are you sure the assignment to $result is correct as $this->renderNothing() (which targets Gojira\Api\Response\BaseResponse::renderNothing()) seems to always return null.

                break;
        }

        return $result;
    }

    /**
     * Returns list of worklogs in a JIRA ticket
     * - Command: worklog:show (['worklog', 'wlog:s'])
     *
     * @return array
     */
    protected function renderListTransitions()
    {
        $rows = [];

        if ($this->response[self::TOTAL] === 0) {
            $rows[] = [new TableCell('No work yet logged.', ['colspan' => 5])];
        }

        $transitions = $this->response[self::TRANSITIONS];
        $totalTransitions = count($transitions);
        for ($counter = 0; $counter < $totalTransitions; $counter++) {
            $transitionId = $transitions[$counter][self::ID];
            $transitionName = $transitions[$counter][self::NAME];
            $author = $transitions[$counter][self::AUTHOR][self::DISPLAY_NAME];
            $timeSpent = $transitions[$counter][self::TIME_SPENT];
            $comment = $transitions[$counter][self::COMMENT];

            if (strlen($comment) > 50) {
                $comment = substr($comment, 0, 47) . '...';
            }

            $rows[] = [
                $transitionId,
                $transitionName,
                $author,
                $timeSpent,
                $comment
            ];
        }

        return $rows;
    }

    /**
     * Returns worklog data after added/updated in a JIRA ticket
     * - Command: worklog:add (['worklogadd', 'wlog:a'])
     * - Command: worklog:update (['worklogupdate', 'wlog:u'])
     *
     * @return array
     */
    protected function renderDoTransition()
    {
        $rows = [];
        $worklogId = $this->response[self::ID];
        $startDate = $this->response[self::CREATED];
        $author = $this->response[self::AUTHOR][self::DISPLAY_NAME];
        $timeSpent = $this->response[self::TIME_SPENT];
        $comment = $this->response[self::COMMENT];

        if (strlen($comment) > 50) {
            $comment = substr($comment, 0, 47) . '...';
        }

        $rows[] = [
            $worklogId,
            $startDate,
            $author,
            $timeSpent,
            $comment
        ];

        return $rows;
    }
}