Placeholder::render() - Code Metrics - Inspection of "Merge pull request #15 from nntoan/gorira" - nntoan/Gojira - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a7df58...69cda4 )

by Toan

created 2017-08-25 12:17 UTC

Placeholder::render() A

↳ Parent: Placeholder

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	2
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Copyright © 2017 Toan Nguyen. All rights reserved.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gojira\Framework\Phrase\Renderer;

use Gojira\Framework\Phrase\RendererInterface;

/**
 * Placeholder renderer
 * __('format %1 %2 %3', $var1, $var2, $var3)
 *
 * @package Gojira\Framework\Phrase\Renderer
 * @author  Toan Nguyen <[email protected]>
 */
class Placeholder implements RendererInterface
{
    /**
     * Render source text
     *
     * @param array $source
     * @param array $arguments
     * @return string
     */
    public function render(array $source, array $arguments)
    {
        $text = end($source);

        if ($arguments) {

            $placeholders = array_map([$this, 'keyToPlaceholder'], array_keys($arguments));
            $pairs = array_combine($placeholders, $arguments);
            $text = strtr($text, $pairs);
        }

        return $text;
    }

    /**
     * Get key to placeholder
     *
     * @param string|int $key
     * @return string
     */
    private function keyToPlaceholder($key)
    {
        return '%' . (is_int($key) ? strval($key + 1) : $key);
    }
}


1			<?php
2			/**
3			* Copyright © 2017 Toan Nguyen. All rights reserved.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8
9			namespace Gojira\Framework\Phrase\Renderer;
10
11			use Gojira\Framework\Phrase\RendererInterface;
12
13			/**
14			* Placeholder renderer
15			* __('format %1 %2 %3', $var1, $var2, $var3)
16			*
17			* @package Gojira\Framework\Phrase\Renderer
18			* @author Toan Nguyen <[email protected]>
19			*/
20			class Placeholder implements RendererInterface
21			{
22			/**
23			* Render source text
24			*
25			* @param array $source
26			* @param array $arguments
27			* @return string
28			*/
29			public function render(array $source, array $arguments)
30			{
31			$text = end($source);
32
33			if ($arguments) {
			0 ignored issues – show Bug Best Practice introduced 2017-07-31 14:38 UTC by Report Bug Copy Issue Report The expression `$arguments` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
34			$placeholders = array_map([$this, 'keyToPlaceholder'], array_keys($arguments));
35			$pairs = array_combine($placeholders, $arguments);
36			$text = strtr($text, $pairs);
37			}
38
39			return $text;
40			}
41
42			/**
43			* Get key to placeholder
44			*
45			* @param string\|int $key
46			* @return string
47			*/
48			private function keyToPlaceholder($key)
49			{
50			return '%' . (is_int($key) ? strval($key + 1) : $key);
51			}
52			}
53

nntoan / Gojira

Push — master ( a7df58...69cda4 )

Placeholder::render() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like