TransitionResponse - Code Metrics - nntoan/Gojira - Measure and Improve Code Quality continuously with Scrutinizer

TransitionResponse A
last analyzed 2017-08-25 12:41 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	95
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	95
loc	95
rs	10
c	0
b	0
f	0
wmc	12
lcom	1
cbo	2

3 Methods

Rating	Name	Duplication	Size	Complexity
B	render()	19	19	6
B	renderListTransitions()	32	32	4
A	renderDoTransition()	23	23	2

How to fix Duplicated Code

<?php
/**
 * Copyright © 2017 Toan Nguyen. All rights reserved.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gojira\Jira\Response;

use Gojira\Api\Response\BaseResponse;
use Gojira\Api\Response\ResponseInterface;
use Symfony\Component\Console\Helper\TableCell;

/**
 * Render result for JIRA REST /transitions
 *
 * @package Gojira\Jira\Response
 * @author  Toan Nguyen <[email protected]>
 */
class TransitionResponse extends IssueResponse implements ResponseInterface
{
    /**
     * {@inheritdoc}
     */
    public function render($type = null)
    {
        switch ($type) {
            case 'issue:transit:get':
                $result = $this->renderListTransitions();
                break;
            case 'issue:transit:start':
            case 'issue:transit:stop':
            case 'issue:transit:review':
            case 'issue:transit:done':
                $result = $this->renderDoTransition();
                break;
            default:
                $result = $this->renderNothing();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                break;
        }

        return $result;
    }

    /**
     * Returns list of worklogs in a JIRA ticket
     * - Command: worklog:show (['worklog', 'wlog:s'])
     *
     * @return array
     */
    protected function renderListTransitions()
    {
        $rows = [];

        if ($this->response[self::TOTAL] === 0) {
            $rows[] = [new TableCell('No work yet logged.', ['colspan' => 5])];
        }

        $transitions = $this->response[self::TRANSITIONS];
        $totalTransitions = count($transitions);
        for ($counter = 0; $counter < $totalTransitions; $counter++) {
            $transitionId = $transitions[$counter][self::ID];
            $transitionName = $transitions[$counter][self::NAME];
            $author = $transitions[$counter][self::AUTHOR][self::DISPLAY_NAME];
            $timeSpent = $transitions[$counter][self::TIME_SPENT];
            $comment = $transitions[$counter][self::COMMENT];

            if (strlen($comment) > 50) {
                $comment = substr($comment, 0, 47) . '...';
            }

            $rows[] = [
                $transitionId,
                $transitionName,
                $author,
                $timeSpent,
                $comment
            ];
        }

        return $rows;
    }

    /**
     * Returns worklog data after added/updated in a JIRA ticket
     * - Command: worklog:add (['worklogadd', 'wlog:a'])
     * - Command: worklog:update (['worklogupdate', 'wlog:u'])
     *
     * @return array
     */
    protected function renderDoTransition()
    {
        $rows = [];
        $worklogId = $this->response[self::ID];
        $startDate = $this->response[self::CREATED];
        $author = $this->response[self::AUTHOR][self::DISPLAY_NAME];
        $timeSpent = $this->response[self::TIME_SPENT];
        $comment = $this->response[self::COMMENT];

        if (strlen($comment) > 50) {
            $comment = substr($comment, 0, 47) . '...';
        }

        $rows[] = [
            $worklogId,
            $startDate,
            $author,
            $timeSpent,
            $comment
        ];

        return $rows;
    }
}


1		<?php
2		/**
3		* Copyright © 2017 Toan Nguyen. All rights reserved.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8
9		namespace Gojira\Jira\Response;
10
11		use Gojira\Api\Response\BaseResponse;
12		use Gojira\Api\Response\ResponseInterface;
13		use Symfony\Component\Console\Helper\TableCell;
14
15		/**
16		* Render result for JIRA REST /transitions
17		*
18		* @package Gojira\Jira\Response
19		* @author Toan Nguyen <[email protected]>
20		*/
21	View Code Duplication	class TransitionResponse extends IssueResponse implements ResponseInterface
22		{
23		/**
24		* {@inheritdoc}
25		*/
26		public function render($type = null)
27		{
28		switch ($type) {
29		case 'issue:transit:get':
30		$result = $this->renderListTransitions();
31		break;
32		case 'issue:transit:start':
33		case 'issue:transit:stop':
34		case 'issue:transit:review':
35		case 'issue:transit:done':
36		$result = $this->renderDoTransition();
37		break;
38		default:
39		$result = $this->renderNothing();
		0 ignored issues – show Bug introduced 2017-08-25 12:00 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `$this->renderNothing()` (which targets `Gojira\Api\Response\BaseResponse::renderNothing()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
40		break;
41		}
42
43		return $result;
44		}
45
46		/**
47		* Returns list of worklogs in a JIRA ticket
48		* - Command: worklog:show (['worklog', 'wlog:s'])
49		*
50		* @return array
51		*/
52		protected function renderListTransitions()
53		{
54		$rows = [];
55
56		if ($this->response[self::TOTAL] === 0) {
57		$rows[] = [new TableCell('No work yet logged.', ['colspan' => 5])];
58		}
59
60		$transitions = $this->response[self::TRANSITIONS];
61		$totalTransitions = count($transitions);
62		for ($counter = 0; $counter < $totalTransitions; $counter++) {
63		$transitionId = $transitions[$counter][self::ID];
64		$transitionName = $transitions[$counter][self::NAME];
65		$author = $transitions[$counter][self::AUTHOR][self::DISPLAY_NAME];
66		$timeSpent = $transitions[$counter][self::TIME_SPENT];
67		$comment = $transitions[$counter][self::COMMENT];
68
69		if (strlen($comment) > 50) {
70		$comment = substr($comment, 0, 47) . '...';
71		}
72
73		$rows[] = [
74		$transitionId,
75		$transitionName,
76		$author,
77		$timeSpent,
78		$comment
79		];
80		}
81
82		return $rows;
83		}
84
85		/**
86		* Returns worklog data after added/updated in a JIRA ticket
87		* - Command: worklog:add (['worklogadd', 'wlog:a'])
88		* - Command: worklog:update (['worklogupdate', 'wlog:u'])
89		*
90		* @return array
91		*/
92		protected function renderDoTransition()
93		{
94		$rows = [];
95		$worklogId = $this->response[self::ID];
96		$startDate = $this->response[self::CREATED];
97		$author = $this->response[self::AUTHOR][self::DISPLAY_NAME];
98		$timeSpent = $this->response[self::TIME_SPENT];
99		$comment = $this->response[self::COMMENT];
100
101		if (strlen($comment) > 50) {
102		$comment = substr($comment, 0, 47) . '...';
103		}
104
105		$rows[] = [
106		$worklogId,
107		$startDate,
108		$author,
109		$timeSpent,
110		$comment
111		];
112
113		return $rows;
114		}
115		}
116

nntoan / Gojira

TransitionResponse A last analyzed 2017-08-25 12:41 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

TransitionResponse A
last analyzed 2017-08-25 12:41 UTC