Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 19 | class Options extends DataObject implements OptionsInterface |
||
| 20 | { |
||
| 21 | /** |
||
| 22 | * Overwrite data in the object. |
||
| 23 | * |
||
| 24 | * The $key parameter can be string or array. |
||
| 25 | * If $key is string, the attribute value will be overwritten by $value |
||
| 26 | * |
||
| 27 | * If $key is an array, it will overwrite all the data in the object. |
||
| 28 | * |
||
| 29 | * @param string|array $key |
||
| 30 | * @param mixed $value |
||
| 31 | * |
||
| 32 | * @return $this |
||
| 33 | */ |
||
| 34 | View Code Duplication | public function setData($key, $value = null) |
|
| 44 | |||
| 45 | /** |
||
| 46 | * Init default option items |
||
| 47 | * |
||
| 48 | * @return array |
||
| 49 | */ |
||
| 50 | public function initDefaultOptionItems() |
||
| 76 | } |
||
| 77 |