Issues in BaseTerm.php (master) - Issues in master - nkostadinov/yii2-taxonomy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (68)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

components/terms/BaseTerm.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Created by PhpStorm.
 * User: Nikola nb
 * Date: 19.10.2014
 * Time: 11:35 ч.
 */

namespace nkostadinov\taxonomy\components\terms;

use nkostadinov\taxonomy\components\interfaces\ITaxonomyTermInterface;
use nkostadinov\taxonomy\models\TaxonomyDef;
use nkostadinov\taxonomy\models\TaxonomyTerms;
use Yii;
use yii\base\Exception;
use yii\base\BaseObject;
use yii\db\Connection;
use yii\db\Query;
use yii\helpers\ArrayHelper;

abstract class BaseTerm extends BaseObject implements ITaxonomyTermInterface
{
    public $migrationPath = '@app/migrations';

    public $id;
    public $name; //the name of the term
    public $data_table;
    public $ref_table;
    public $is_multi = false;
    public $created_at;
    public $total_count;
    public $migration;

    public abstract function addTerm($object_id, $params);

    public function removeTerm($object_id, $params = [])
    {
        if(empty($params)) {
            $params = $this->getTerms($object_id);
        }

        foreach($params as $item) {

            $term = $this->getTaxonomyTerm($item);
            $data['term_id'] = $term->id;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $data['object_id'] = $object_id;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

            $query = new Query();
            if ($query->from($this->table)->where($data)->exists($this->getDb())) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->getDb()->createCommand()->delete($this->table, $data)->execute();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

                $term->updateCounters(['total_count' => -1]);

                Taxonomydef::updateAllCounters(['total_count' => -1], [ 'id' => $this->id ]);
            }
        }
    }

    public function getTerms($object_id = null, $name = [])
    {
        $query = TaxonomyTerms::find()
            ->select('term')
            ->where(['taxonomy_id' => $this->id])
            ->andFilterWhere(['taxonomy_terms.term' => $name]);

        if ($object_id) {
            $query->innerJoin($this->table, $this->table . '.term_id = taxonomy_terms.id')
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                  ->onCondition("$this->table.object_id = $object_id");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        
        return ArrayHelper::getColumn($query->all(), 'term');
    }

    public function setTerms($object_id, $params = [])
    {
        Yii::$app->db->transaction(function() use ($object_id, $params) {
            $this->removeTerm($object_id);
            $this->addTerm($object_id, $params);
        });
    }

    public function isInstalled()
    {
        return Yii::$app->db->getTableSchema($this->getTable(), true) !== null;
    }

    public function install()
    {
        return $this->createMigration();
    }

    public function uninstall()
    {
        //drop the data table
        //$this->getDb()->createCommand()->dropTable($this->getTable())->execute();
        //delete the term itself
        $model = TaxonomyDef::findOne($this->id);
        $model->delete();
    }

    /**
     * Return the db connection component.
     *
     * @return Connection
     */
    public static function getDb()
    {
        return Yii::$app->db;
    }

    public function canInstall() {
        if(!$this->getTable())
            return 'Missing "table" property';
        return true;
    }

    public function getTaxonomyTerm($name, $create = true)
    {
        $term = TaxonomyTerms::findOne(['term'=>$name, 'taxonomy_id' => $this->id]);
        if($create and !isset($term)) {

            $term = new TaxonomyTerms();
            $term->taxonomy_id = $this->id;
            $term->term = $name;
            $term->total_count = 0;
            $term->save();
        }
        
        return $term;
    }

    public function getRefTableName()
    {
        if(strpos($this->refTable, '\\') === FALSE) //not an AR class but a table name
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $this->refTable;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        else
            return call_user_func([$this->refTable, 'tableName']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getTable()
    {
        return $this->data_table;
    }

    public function getRefTable()
    {
        return $this->ref_table;
    }

    public function getMigrationFile()
    {
        if (!preg_match('/^\w+$/', $this->name)) {
            throw new Exception('The migration name should contain letters, digits and/or underscore characters only.');
        }
        $name = 'm' . gmdate('ymd_His') . '_' . $this->name;
        return $name;
    }

    public function createMigration()
    {

        $name = $this->getMigrationFile();
        $file = Yii::getAlias($this->migrationPath . DIRECTORY_SEPARATOR . $name . '.php');

        //$data = get_object_vars($this);
        $data = [];
        $data['name'] = $this->name;
        $data['class'] = get_class($this);
        $data['data_table'] = $this->data_table;
        $data['ref_table'] = $this->getRefTableName();
        $data['migration'] = $name;

        $this->migration = $name;
        $content = Yii::$app->getView()->renderFile(Yii::getAlias($this->templateFile), [ 'data' => $data ]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        file_put_contents($file, $content);
        return $name;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: Nikola nb
5		* Date: 19.10.2014
6		* Time: 11:35 ч.
7		*/
8
9		namespace nkostadinov\taxonomy\components\terms;
10
11		use nkostadinov\taxonomy\components\interfaces\ITaxonomyTermInterface;
12		use nkostadinov\taxonomy\models\TaxonomyDef;
13		use nkostadinov\taxonomy\models\TaxonomyTerms;
14		use Yii;
15		use yii\base\Exception;
16		use yii\base\BaseObject;
17		use yii\db\Connection;
18		use yii\db\Query;
19		use yii\helpers\ArrayHelper;
20
21		abstract class BaseTerm extends BaseObject implements ITaxonomyTermInterface
22		{
23		public $migrationPath = '@app/migrations';
24
25		public $id;
26		public $name; //the name of the term
27		public $data_table;
28		public $ref_table;
29		public $is_multi = false;
30		public $created_at;
31		public $total_count;
32		public $migration;
33
34		public abstract function addTerm($object_id, $params);
35
36		public function removeTerm($object_id, $params = [])
37		{
38		if(empty($params)) {
39		$params = $this->getTerms($object_id);
40		}
41
42	View Code Duplication	foreach($params as $item) {
		0 ignored issues – show Duplication introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		$term = $this->getTaxonomyTerm($item);
44		$data['term_id'] = $term->id;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
45		$data['object_id'] = $object_id;
		0 ignored issues – show Bug introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$data` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
46
47		$query = new Query();
48		if ($query->from($this->table)->where($data)->exists($this->getDb())) {
		0 ignored issues – show Documentation introduced 2016-10-21 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `table` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49		$this->getDb()->createCommand()->delete($this->table, $data)->execute();
		0 ignored issues – show Documentation introduced 2016-10-21 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `table` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50
51		$term->updateCounters(['total_count' => -1]);
		0 ignored issues – show Bug introduced 2018-10-05 08:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `updateCounters()` does not exist on `yii\db\ActiveRecordInterface`. Did you maybe mean `update()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
52		Taxonomydef::updateAllCounters(['total_count' => -1], [ 'id' => $this->id ]);
53		}
54		}
55		}
56
57		public function getTerms($object_id = null, $name = [])
58		{
59		$query = TaxonomyTerms::find()
60		->select('term')
61		->where(['taxonomy_id' => $this->id])
62		->andFilterWhere(['taxonomy_terms.term' => $name]);
63
64		if ($object_id) {
65		$query->innerJoin($this->table, $this->table . '.term_id = taxonomy_terms.id')
		0 ignored issues – show Documentation introduced 2016-11-24 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `table` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
66		->onCondition("$this->table.object_id = $object_id");
		0 ignored issues – show Documentation introduced 2016-11-24 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `table` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
67		}
68
69		return ArrayHelper::getColumn($query->all(), 'term');
70		}
71
72		public function setTerms($object_id, $params = [])
73		{
74		Yii::$app->db->transaction(function() use ($object_id, $params) {
75		$this->removeTerm($object_id);
76		$this->addTerm($object_id, $params);
77		});
78		}
79
80		public function isInstalled()
81		{
82		return Yii::$app->db->getTableSchema($this->getTable(), true) !== null;
83		}
84
85		public function install()
86		{
87		return $this->createMigration();
88		}
89
90		public function uninstall()
91		{
92		//drop the data table
93		//$this->getDb()->createCommand()->dropTable($this->getTable())->execute();
94		//delete the term itself
95		$model = TaxonomyDef::findOne($this->id);
96		$model->delete();
97		}
98
99		/**
100		* Return the db connection component.
101		*
102		* @return Connection
103		*/
104		public static function getDb()
105		{
106		return Yii::$app->db;
107		}
108
109		public function canInstall() {
110		if(!$this->getTable())
111		return 'Missing "table" property';
112		return true;
113		}
114
115		public function getTaxonomyTerm($name, $create = true)
116		{
117		$term = TaxonomyTerms::findOne(['term'=>$name, 'taxonomy_id' => $this->id]);
118	View Code Duplication	if($create and !isset($term)) {
		0 ignored issues – show Duplication introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		$term = new TaxonomyTerms();
120		$term->taxonomy_id = $this->id;
121		$term->term = $name;
122		$term->total_count = 0;
123		$term->save();
124		}
125
126		return $term;
127		}
128
129		public function getRefTableName()
130		{
131		if(strpos($this->refTable, '\\') === FALSE) //not an AR class but a table name
		0 ignored issues – show Documentation introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `refTable` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
132		return $this->refTable;
		0 ignored issues – show Documentation introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `refTable` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
133		else
134		return call_user_func([$this->refTable, 'tableName']);
		0 ignored issues – show Documentation introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `refTable` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
135		}
136
137		public function getTable()
138		{
139		return $this->data_table;
140		}
141
142		public function getRefTable()
143		{
144		return $this->ref_table;
145		}
146
147		public function getMigrationFile()
148		{
149		if (!preg_match('/^\w+$/', $this->name)) {
150		throw new Exception('The migration name should contain letters, digits and/or underscore characters only.');
151		}
152		$name = 'm' . gmdate('ymd_His') . '_' . $this->name;
153		return $name;
154		}
155
156		public function createMigration()
157		{
158
159		$name = $this->getMigrationFile();
160		$file = Yii::getAlias($this->migrationPath . DIRECTORY_SEPARATOR . $name . '.php');
161
162		//$data = get_object_vars($this);
163		$data = [];
164		$data['name'] = $this->name;
165		$data['class'] = get_class($this);
166		$data['data_table'] = $this->data_table;
167		$data['ref_table'] = $this->getRefTableName();
168		$data['migration'] = $name;
169
170		$this->migration = $name;
171		$content = Yii::$app->getView()->renderFile(Yii::getAlias($this->templateFile), [ 'data' => $data ]);
		0 ignored issues – show Documentation introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `templateFile` does not exist on `object<nkostadinov\taxon...ponents\terms\BaseTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
172		file_put_contents($file, $content);
173		return $name;
174		}
175		}

nkostadinov / yii2-taxonomy

Issues (68)

Security Analysis not enabled

components/terms/BaseTerm.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like