nkostadinov\taxonomy\components\terms\BaseTerm

Complexity

Total Complexity

23

Size/Duplication

Total Lines	155
Duplicated Lines	13.55 %

Coupling/Cohesion

Components	2
Dependencies	10

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
	addTerm()	0	1	?
A	removeTerm()	13	20	4
A	getTerms()	0	14	2
A	setTerms()	0	7	1
A	isInstalled()	0	4	1
A	install()	0	4	1
A	uninstall()	0	8	1
A	getDb()	0	4	1
A	canInstall()	0	5	2
A	getTaxonomyTerm()	8	13	3
A	getRefTableName()	0	7	2
A	getTable()	0	4	1
A	getRefTable()	0	4	1
A	getMigrationFile()	0	8	2
A	createMigration()	0	19	1

<?php
/**
 * Created by PhpStorm.
 * User: Nikola nb
 * Date: 19.10.2014
 * Time: 11:35 ч.
 */

namespace nkostadinov\taxonomy\components\terms;

use nkostadinov\taxonomy\components\interfaces\ITaxonomyTermInterface;
use nkostadinov\taxonomy\models\TaxonomyDef;
use nkostadinov\taxonomy\models\TaxonomyTerms;
use Yii;
use yii\base\Exception;
use yii\base\Object;
use yii\db\Connection;
use yii\db\Query;
use yii\helpers\ArrayHelper;

abstract class BaseTerm extends Object implements ITaxonomyTermInterface
{
    public $migrationPath = '@app/migrations';

    public $id;
    public $name; //the name of the term
    public $data_table;
    public $ref_table;
    public $is_multi = false;
    public $created_at;
    public $total_count;
    public $migration;

    public abstract function addTerm($object_id, $params);

The abstract declaration must precede the visibility declaration

    public function removeTerm($object_id, $params = [])
    {
        if(empty($params)) {
            $params = $this->getTerms($object_id);
        }

        foreach($params as $item) {

This code seems to be duplicated across your project.

            $term = $this->getTaxonomyTerm($item);
            $data['term_id'] = $term->id;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data['object_id'] = $object_id;

The variable $data does not seem to be defined for all execution paths leading up to this point.

            $query = new Query();
            if ($query->from($this->table)->where($data)->exists($this->getDb())) {

The property table does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

                $this->getDb()->createCommand()->delete($this->table, $data)->execute();

The property table does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

                $term->updateCounters(['total_count' => -1]);
                Taxonomydef::updateAllCounters(['total_count' => -1], [ 'id' => $this->id ]);
            }
        }
    }

    public function getTerms($object_id = null, $name = [])
    {
        $query = TaxonomyTerms::find()
            ->select('term')
            ->where(['taxonomy_id' => $this->id])
            ->andFilterWhere(['taxonomy_terms.term' => $name]);

        if ($object_id) {
            $query->innerJoin($this->table, $this->table . '.term_id = taxonomy_terms.id')

The property table does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

                  ->onCondition("$this->table.object_id = $object_id");

The property table does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

        }
        
        return ArrayHelper::getColumn($query->all(), 'term');
    }

    public function setTerms($object_id, $params = [])
    {
        Yii::$app->db->transaction(function() use ($object_id, $params) {
            $this->removeTerm($object_id);
            $this->addTerm($object_id, $params);
        });
    }

    public function isInstalled()
    {
        return Yii::$app->db->getTableSchema($this->getTable(), true) !== null;
    }

    public function install()
    {
        return $this->createMigration();
    }

    public function uninstall()
    {
        //drop the data table
        //$this->getDb()->createCommand()->dropTable($this->getTable())->execute();

79% of this comment could be valid code. Did you maybe forget this after debugging?

        //delete the term itself
        $model = TaxonomyDef::findOne($this->id);
        $model->delete();
    }

    /**
     * Return the db connection component.
     *
     * @return Connection
     */
    public static function getDb()
    {
        return Yii::$app->db;
    }

    public function canInstall() {
        if(!$this->getTable())
            return 'Missing "table" property';
        return true;
    }

    public function getTaxonomyTerm($name, $create = true)
    {
        $term = TaxonomyTerms::findOne(['term'=>$name, 'taxonomy_id' => $this->id]);
        if($create and !isset($term))

This code seems to be duplicated across your project.

Using logical operators such as and instead of && is generally not recommended.

        {
            $term = new TaxonomyTerms();
            $term->taxonomy_id = $this->id;
            $term->term = $name;
            $term->total_count = 0;
            $term->save();
        }
        return $term;
    }

    public function getRefTableName()
    {
        if(strpos($this->refTable, '\\') === FALSE) //not an AR class but a table name

The property refTable does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

            return $this->refTable;

The property refTable does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

        else
            return call_user_func([$this->refTable, 'tableName']);

The property refTable does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    public function getTable()
    {
        return $this->data_table;
    }

    public function getRefTable()
    {
        return $this->ref_table;
    }

    public function getMigrationFile()
    {
        if (!preg_match('/^\w+$/', $this->name)) {
            throw new Exception('The migration name should contain letters, digits and/or underscore characters only.');
        }
        $name = 'm' . gmdate('ymd_His') . '_' . $this->name;
        return $name;
    }

    public function createMigration()
    {

        $name = $this->getMigrationFile();
        $file = Yii::getAlias($this->migrationPath . DIRECTORY_SEPARATOR . $name . '.php');

        //$data = get_object_vars($this);

56% of this comment could be valid code. Did you maybe forget this after debugging?

        $data = [];
        $data['name'] = $this->name;
        $data['class'] = get_class($this);
        $data['data_table'] = $this->data_table;
        $data['ref_table'] = $this->getRefTableName();
        $data['migration'] = $name;

        $this->migration = $name;
        $content = Yii::$app->getView()->renderFile(Yii::getAlias($this->templateFile), [ 'data' => $data ]);

The property templateFile does not exist on object<nkostadinov\taxonomy\components\terms\BaseTerm>. Since you implemented __get, maybe consider adding a @property annotation.

        file_put_contents($file, $content);
        return $name;
    }
}