TagTerm::addTerm() - Code Metrics - nkostadinov/yii2-taxonomy - Measure and Improve Code Quality continuously with Scrutinizer

TagTerm::addTerm() A
last analyzed 2018-10-05 08:13 UTC

↳ Parent: TagTerm

Complexity

Conditions	4
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.552
c	0
b	0
f	0
cc	4
nc	7
nop	2

<?php
/**
 * User: Nikola nb
 * Date: 19.10.2014
 * Time: 11:41 ч.
 */

namespace nkostadinov\taxonomy\components\terms;

use Exception;
use nkostadinov\taxonomy\models\TaxonomyDef;
use yii\db\Query;

class TagTerm extends BaseTerm
{
    public $templateFile = '@nkostadinov/taxonomy/migrations/template/tag.php';

    public function addTerm($object_id, $params)
    {
        foreach($params as $item) {
            $term = $this->getTaxonomyTerm($item);
            $data['term_id'] = $term->id;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $data['object_id'] = $object_id;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

            $query = new Query();
            if (!$query->from($this->table)->where($data)->exists($this->getDb())) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $transaction = $this->getDb()->beginTransaction();
                try {
                    $this->getDb()->createCommand()->insert($this->table, $data)->execute();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

                    $term->updateCounters(['total_count' => 1]);

                    TaxonomyDef::updateAllCounters(['total_count' => 1], [ 'id' => $this->id ]);

                    $transaction->commit();
                } catch (Exception $e) {
                    $transaction->rollBack();
                }
            }
        }
    }
}


1			<?php
2			/**
3			* User: Nikola nb
4			* Date: 19.10.2014
5			* Time: 11:41 ч.
6			*/
7
8			namespace nkostadinov\taxonomy\components\terms;
9
10			use Exception;
11			use nkostadinov\taxonomy\models\TaxonomyDef;
12			use yii\db\Query;
13
14			class TagTerm extends BaseTerm
15			{
16			public $templateFile = '@nkostadinov/taxonomy/migrations/template/tag.php';
17
18			public function addTerm($object_id, $params)
19			{
20			foreach($params as $item) {
21			$term = $this->getTaxonomyTerm($item);
22			$data['term_id'] = $term->id;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
23			$data['object_id'] = $object_id;
			0 ignored issues – show Bug introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report The variable `$data` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
24
25			$query = new Query();
26			if (!$query->from($this->table)->where($data)->exists($this->getDb())) {
			0 ignored issues – show Documentation introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report The property `table` does not exist on `object<nkostadinov\taxon...mponents\terms\TagTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27			$transaction = $this->getDb()->beginTransaction();
28			try {
29			$this->getDb()->createCommand()->insert($this->table, $data)->execute();
			0 ignored issues – show Documentation introduced 2016-05-26 13:53 UTC by Report Bug Copy Issue Report The property `table` does not exist on `object<nkostadinov\taxon...mponents\terms\TagTerm>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
30
31			$term->updateCounters(['total_count' => 1]);
			0 ignored issues – show Bug introduced 2018-10-05 08:00 UTC by Report Bug Copy Issue Report The method `updateCounters()` does not exist on `yii\db\ActiveRecordInterface`. Did you maybe mean `update()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
32			TaxonomyDef::updateAllCounters(['total_count' => 1], [ 'id' => $this->id ]);
33
34			$transaction->commit();
35			} catch (Exception $e) {
36			$transaction->rollBack();
37			}
38			}
39			}
40			}
41			}
42

nkostadinov / yii2-taxonomy

TagTerm::addTerm() A last analyzed 2018-10-05 08:13 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

TagTerm::addTerm() A
last analyzed 2018-10-05 08:13 UTC