Hosts::add() - Code Metrics - Inspection of "Feature add webmaster support" - nixsolutions/yandex-php-library - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#162)

unknown

created 2016-08-04 14:56 UTC

Hosts::add() A

↳ Parent: Hosts

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	7
c	1
b	0
f	1
nc	1
nop	1
dl	0
loc	13
ccs	0
cts	9
cp	0
crap	2
rs	9.4285

<?php
namespace Yandex\Webmaster\Models;

use Yandex\Common\ObjectModel;

/**
 * Class Hosts
 *
 * @package Yandex\Webmaster\Models
 */
class Hosts extends ObjectModel
{
    /**
     * @var array $collection a collection of Host objects
     */
    protected $collection = [];

    /**
     * @var array $mappingClasses
     */
    protected $mappingClasses = [];

    /**
     * @var array $propNameMap
     */
    protected $propNameMap = [];

    /**
     * Hosts constructor.
     *
     * @param \SimpleXMLIterator $data
     */
    public function __construct(\SimpleXMLIterator $data)
    {
        for ($data->rewind(); $data->valid(); $data->next()) {
            $this->add($data->current());
        }

        return $this;

    }

    /**
     * Add item
     *
     * @param \SimpleXMLIterator $hostXmlNode
     * @return $this
     */
    public function add(\SimpleXMLIterator $hostXmlNode)
    {
        $host = new Host($hostXmlNode);

        $hostPathArray = explode('/', parse_url($host->getHref(), PHP_URL_PATH));
        $hostId = array_pop($hostPathArray);

        $host->setId($hostId);

        $this->collection[] = $host;

        return $this;
    }

    /**
     * Get items
     *
     * @return array
     */
    public function getAll()
    {
        return $this->collection;
    }
}


1			<?php
2			namespace Yandex\Webmaster\Models;
3
4			use Yandex\Common\ObjectModel;
5
6			/**
7			* Class Hosts
8			*
9			* @package Yandex\Webmaster\Models
10			*/
11			class Hosts extends ObjectModel
12			{
13			/**
14			* @var array $collection a collection of Host objects
15			*/
16			protected $collection = [];
17
18			/**
19			* @var array $mappingClasses
20			*/
21			protected $mappingClasses = [];
22
23			/**
24			* @var array $propNameMap
25			*/
26			protected $propNameMap = [];
27
28			/**
29			* Hosts constructor.
30			*
31			* @param \SimpleXMLIterator $data
32			*/
33			public function __construct(\SimpleXMLIterator $data)
34			{
35			for ($data->rewind(); $data->valid(); $data->next()) {
36			$this->add($data->current());
37			}
38
39			return $this;
			0 ignored issues – show Bug introduced 2016-08-04 13:50 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
40			}
41
42			/**
43			* Add item
44			*
45			* @param \SimpleXMLIterator $hostXmlNode
46			* @return $this
47			*/
48			public function add(\SimpleXMLIterator $hostXmlNode)
49			{
50			$host = new Host($hostXmlNode);
51
52			$hostPathArray = explode('/', parse_url($host->getHref(), PHP_URL_PATH));
53			$hostId = array_pop($hostPathArray);
54
55			$host->setId($hostId);
56
57			$this->collection[] = $host;
58
59			return $this;
60			}
61
62			/**
63			* Get items
64			*
65			* @return array
66			*/
67			public function getAll()
68			{
69			return $this->collection;
70			}
71			}
72

nixsolutions / yandex-php-library

Pull Request — master (#162)

Hosts::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like