Issues in index.php - All Issues - Inspection of "Merge pull request #200 from spytz/SafeBrowsing_Re..." - nixsolutions/yandex-php-library - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1dc1a5...f8d9f6 )

by Anton

created 2017-04-13 17:28 UTC

examples/DataSync/index.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
$settings = require_once '../settings.php';
use Yandex\DataSync\DataSyncClient;
use Yandex\Common\Exception\ForbiddenException;

$errorMessage = false;

// Is auth
if (isset($_COOKIE['yaAccessToken']) && isset($_COOKIE['yaClientId'])) {
    $dataSync = new DataSyncClient($_COOKIE['yaAccessToken']);
    $context  = DataSyncClient::CONTEXT_USER;
    //Устанавливаем Контекст базы данных (app или user)
    $dataSync->setContext($context);

    try {

        if (isset($_REQUEST['action'])) {
            if ($_REQUEST['action'] === 'createDb' && isset($_REQUEST['databaseId']) && $_REQUEST['databaseId']) {
                //Создание базы данных
                //@see https://tech.yandex.ru/datasync/http/doc/tasks/add-database-docpage/
                $dataSync->createDatabase($_REQUEST['databaseId']);
            } elseif ($_REQUEST['action'] === 'deleteDb' && isset($_REQUEST['databaseId']) && $_REQUEST['databaseId']) {
                //Удаление базы данных
                //@see https://tech.yandex.ru/datasync/http/doc/tasks/delete-database-docpage/
                $dataSync->deleteDatabase($_REQUEST['databaseId']);
            }
        }

        //Получение ответа со списком баз данных
        //@see https://tech.yandex.ru/datasync/http/doc/tasks/get-databases-docpage/
        $databasesResponse = $dataSync->getDatabases();
        //Баз данных
        $databases = $databasesResponse->getItems()->getAll();
    } catch (ForbiddenException $ex) {
        $errorMessage = $ex->getMessage();
        $errorMessage .= '<p>Возможно, у приложения нет прав на доступ к ресурсу. Попробуйте '
            . '<a href="' . rtrim(str_replace($_SERVER['DOCUMENT_ROOT'], '', __DIR__), "/") . "/../OAuth/" .
            '">авторизироваться</a> и повторить.</p>';
    } catch (Exception $ex) {
        $errorMessage = $ex->getMessage();
    }
}
?>
<!doctype html>
<html lang="en-US">
<head>
    <meta charset="UTF-8">
    <title>Yandex PHP Library: DataSync Demo</title>
    <link rel="stylesheet" href="//yandex.st/bootstrap/3.0.0/css/bootstrap.min.css">
    <link href="//netdna.bootstrapcdn.com/font-awesome/3.2.1/css/font-awesome.css" rel="stylesheet">
    <link rel="stylesheet" href="/examples/Disk/css/style.css">
</head>
<body>
<div class="container">
    <div class="jumbotron">
        <h2><span class="glyphicon glyphicon-shopping-cart"></span> Пример работы с Яндекс DataSync HTTP API</h2>
    </div>
    <ol class="breadcrumb">
        <li><a href="/examples">Examples</a></li>
        <li class="active">DataSync</li>
    </ol>
    <?php
    if (!isset($_COOKIE['yaAccessToken']) || !isset($_COOKIE['yaClientId'])) {
        ?>
        <div class="alert alert-info">
            Для просмотра этой страници вам необходимо авторизироваться.
            <a id="goToAuth"
               href="<?php echo rtrim(str_replace($_SERVER['DOCUMENT_ROOT'], '', __DIR__), "/") . '/../OAuth/' ?>"
               class="alert-link">Перейти на страницу авторизации</a>.
        </div>
    <?php
    } elseif ($errorMessage) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
        ?>
        <div class="alert alert-danger">
            <?= $errorMessage ?>
        </div>
    <?php
    } elseif (isset($databases)) {
        ?>
        <div>
            <h3>Базы данных:</h3>
            <table id="accountTable" class="table table-striped table-bordered table-hover">
                <thead>
                <tr>
                    <td>Идентификатор</td>
                    <td>Название</td>
                    <td>Номер ревизии</td>
                    <td>Количество записей</td>
                    <td>Дата и время модификации</td>
                    <td>Дата и время создания</td>
                    <td>Размер</td>
                    <td>Действия</td>
                </tr>
                </thead>
                <tbody>
                <?php
                foreach ($databases as $database) {
                    ?>
                    <tr>
                        <td>
                            <a href="database.php?databaseId=<?= $database->getDatabaseId() ?>">
                                <?= $database->getDatabaseId() ?>
                            </a>
                        </td>
                        <td><?= $database->getTitle() ?></td>
                        <td><?= $database->getRevision() ?></td>
                        <td><?= $database->getRecordsCount() ?></td>
                        <td><?= $database->getModified() ?></td>
                        <td><?= $database->getCreated() ?></td>
                        <td><?= $database->getSize() ?></td>
                        <td>
                            <a href="index.php?action=deleteDb&databaseId=<?= $database->getDatabaseId() ?>">
                                <button type="button" class="btn btn-danger">Удалить</button>
                            </a>
                        </td>
                    </tr>
                <?php
                }
                ?>
                </tbody>
            </table>
            <button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#createDbModal">
                Создать новую БД
            </button>
        </div>

        <!-- Modal -->
        <div class="modal fade" id="createDbModal" tabindex="-1" role="dialog" aria-labelledby="myModalLabel">
            <div class="modal-dialog" role="document">
                <div class="modal-content">
                    <form class="form-horizontal" action="index.php" method="post">
                        <div class="modal-header">
                            <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span
                                    aria-hidden="true">&times;</span></button>
                            <h4 class="modal-title" id="myModalLabel">Создать новую БД</h4>
                        </div>
                        <div class="modal-body">
                            <div class="form-group">
                                <label for="inputDatabaseId" class="col-sm-4 control-label">Идентификатор БД</label>

                                <div class="col-sm-8">
                                    <input type="text" class="form-control" id="inputDatabaseId" name="databaseId"
                                           placeholder="Идентификатор БД">
                                    <input type="hidden" name="action" value="createDb">
                                </div>
                            </div>
                        </div>
                        <div class="modal-footer">
                            <button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
                            <button type="submit" class="btn btn-primary">Save changes</button>
                        </div>
                    </form>
                </div>
            </div>
        </div>

    <?php
    }
    ?>
    <script src="http://yandex.st/jquery/2.0.3/jquery.min.js"></script>
    <script src="http://yandex.st/jquery/cookie/1.0/jquery.cookie.min.js"></script>
    <script src="//maxcdn.bootstrapcdn.com/bootstrap/3.2.0/js/bootstrap.min.js"></script>
    <script>
        $(function () {
            $('#goToAuth').click(function (e) {
                $.cookie('back', location.href, {expires: 256, path: '/'});
            });
        });
    </script>
</body>
</html>


1			<?php
2			$settings = require_once '../settings.php';
3			use Yandex\DataSync\DataSyncClient;
4			use Yandex\Common\Exception\ForbiddenException;
5
6			$errorMessage = false;
7
8			// Is auth
9			if (isset($_COOKIE['yaAccessToken']) && isset($_COOKIE['yaClientId'])) {
10			$dataSync = new DataSyncClient($_COOKIE['yaAccessToken']);
11			$context = DataSyncClient::CONTEXT_USER;
12			//Устанавливаем Контекст базы данных (app или user)
13			$dataSync->setContext($context);
14
15			try {
16
17			if (isset($_REQUEST['action'])) {
18			if ($_REQUEST['action'] === 'createDb' && isset($_REQUEST['databaseId']) && $_REQUEST['databaseId']) {
19			//Создание базы данных
20			//@see https://tech.yandex.ru/datasync/http/doc/tasks/add-database-docpage/
21			$dataSync->createDatabase($_REQUEST['databaseId']);
22			} elseif ($_REQUEST['action'] === 'deleteDb' && isset($_REQUEST['databaseId']) && $_REQUEST['databaseId']) {
23			//Удаление базы данных
24			//@see https://tech.yandex.ru/datasync/http/doc/tasks/delete-database-docpage/
25			$dataSync->deleteDatabase($_REQUEST['databaseId']);
26			}
27			}
28
29			//Получение ответа со списком баз данных
30			//@see https://tech.yandex.ru/datasync/http/doc/tasks/get-databases-docpage/
31			$databasesResponse = $dataSync->getDatabases();
32			//Баз данных
33			$databases = $databasesResponse->getItems()->getAll();
34			} catch (ForbiddenException $ex) {
35			$errorMessage = $ex->getMessage();
36			$errorMessage .= '<p>Возможно, у приложения нет прав на доступ к ресурсу. Попробуйте '
37			. '<a href="' . rtrim(str_replace($_SERVER['DOCUMENT_ROOT'], '', __DIR__), "/") . "/../OAuth/" .
38			'">авторизироваться</a> и повторить.</p>';
39			} catch (Exception $ex) {
40			$errorMessage = $ex->getMessage();
41			}
42			}
43			?>
44			<!doctype html>
45			<html lang="en-US">
46			<head>
47			<meta charset="UTF-8">
48			<title>Yandex PHP Library: DataSync Demo</title>
49			<link rel="stylesheet" href="//yandex.st/bootstrap/3.0.0/css/bootstrap.min.css">
50			<link href="//netdna.bootstrapcdn.com/font-awesome/3.2.1/css/font-awesome.css" rel="stylesheet">
51			<link rel="stylesheet" href="/examples/Disk/css/style.css">
52			</head>
53			<body>
54			<div class="container">
55			<div class="jumbotron">
56			<h2><span class="glyphicon glyphicon-shopping-cart"></span> Пример работы с Яндекс DataSync HTTP API</h2>
57			</div>
58			<ol class="breadcrumb">
59			<li><a href="/examples">Examples</a></li>
60			<li class="active">DataSync</li>
61			</ol>
62			<?php
63			if (!isset($_COOKIE['yaAccessToken']) \|\| !isset($_COOKIE['yaClientId'])) {
64			?>
65			<div class="alert alert-info">
66			Для просмотра этой страници вам необходимо авторизироваться.
67			<a id="goToAuth"
68			href="<?php echo rtrim(str_replace($_SERVER['DOCUMENT_ROOT'], '', __DIR__), "/") . '/../OAuth/' ?>"
69			class="alert-link">Перейти на страницу авторизации</a>.
70			</div>
71			<?php
72			} elseif ($errorMessage) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-10 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$errorMessage` of type `false\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
73			?>
74			<div class="alert alert-danger">
75			<?= $errorMessage ?>
76			</div>
77			<?php
78			} elseif (isset($databases)) {
79			?>
80			<div>
81			<h3>Базы данных:</h3>
82			<table id="accountTable" class="table table-striped table-bordered table-hover">
83			<thead>
84			<tr>
85			<td>Идентификатор</td>
86			<td>Название</td>
87			<td>Номер ревизии</td>
88			<td>Количество записей</td>
89			<td>Дата и время модификации</td>
90			<td>Дата и время создания</td>
91			<td>Размер</td>
92			<td>Действия</td>
93			</tr>
94			</thead>
95			<tbody>
96			<?php
97			foreach ($databases as $database) {
98			?>
99			<tr>
100			<td>
101			<a href="database.php?databaseId=<?= $database->getDatabaseId() ?>">
102			<?= $database->getDatabaseId() ?>
103			</a>
104			</td>
105			<td><?= $database->getTitle() ?></td>
106			<td><?= $database->getRevision() ?></td>
107			<td><?= $database->getRecordsCount() ?></td>
108			<td><?= $database->getModified() ?></td>
109			<td><?= $database->getCreated() ?></td>
110			<td><?= $database->getSize() ?></td>
111			<td>
112			<a href="index.php?action=deleteDb&databaseId=<?= $database->getDatabaseId() ?>">
113			<button type="button" class="btn btn-danger">Удалить</button>
114			</a>
115			</td>
116			</tr>
117			<?php
118			}
119			?>
120			</tbody>
121			</table>
122			<button type="button" class="btn btn-primary btn-lg" data-toggle="modal" data-target="#createDbModal">
123			Создать новую БД
124			</button>
125			</div>
126
127			<!-- Modal -->
128			<div class="modal fade" id="createDbModal" tabindex="-1" role="dialog" aria-labelledby="myModalLabel">
129			<div class="modal-dialog" role="document">
130			<div class="modal-content">
131			<form class="form-horizontal" action="index.php" method="post">
132			<div class="modal-header">
133			<button type="button" class="close" data-dismiss="modal" aria-label="Close"><span
134			aria-hidden="true">×</span></button>
135			<h4 class="modal-title" id="myModalLabel">Создать новую БД</h4>
136			</div>
137			<div class="modal-body">
138			<div class="form-group">
139			<label for="inputDatabaseId" class="col-sm-4 control-label">Идентификатор БД</label>
140
141			<div class="col-sm-8">
142			<input type="text" class="form-control" id="inputDatabaseId" name="databaseId"
143			placeholder="Идентификатор БД">
144			<input type="hidden" name="action" value="createDb">
145			</div>
146			</div>
147			</div>
148			<div class="modal-footer">
149			<button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
150			<button type="submit" class="btn btn-primary">Save changes</button>
151			</div>
152			</form>
153			</div>
154			</div>
155			</div>
156
157			<?php
158			}
159			?>
160			<script src="http://yandex.st/jquery/2.0.3/jquery.min.js"></script>
161			<script src="http://yandex.st/jquery/cookie/1.0/jquery.cookie.min.js"></script>
162			<script src="//maxcdn.bootstrapcdn.com/bootstrap/3.2.0/js/bootstrap.min.js"></script>
163			<script>
164			$(function () {
165			$('#goToAuth').click(function (e) {
166			$.cookie('back', location.href, {expires: 256, path: '/'});
167			});
168			});
169			</script>
170			</body>
171			</html>
172

nixsolutions / yandex-php-library

Push — master ( 1dc1a5...f8d9f6 )

examples/DataSync/index.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like