Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like DiskClient often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DiskClient, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
31 | class DiskClient extends AbstractServiceClient |
||
32 | { |
||
33 | const DECODE_TYPE_DEFAULT = self::DECODE_TYPE_XML; |
||
34 | |||
35 | /** |
||
36 | * @var string |
||
37 | */ |
||
38 | private $version = 'v1'; |
||
39 | |||
40 | /** |
||
41 | * @var string |
||
42 | */ |
||
43 | protected $serviceDomain = 'webdav.yandex.ru'; |
||
44 | |||
45 | /** |
||
46 | * @param string $version |
||
47 | * |
||
48 | * @return self |
||
49 | */ |
||
50 | 1 | public function setVersion($version) |
|
51 | { |
||
52 | 1 | $this->version = $version; |
|
53 | |||
54 | 1 | return $this; |
|
55 | } |
||
56 | |||
57 | /** |
||
58 | * @return string |
||
59 | */ |
||
60 | 2 | public function getVersion() |
|
61 | { |
||
62 | 2 | return $this->version; |
|
63 | } |
||
64 | |||
65 | /** |
||
66 | * @inheritdoc |
||
67 | */ |
||
68 | 2 | public function getServiceUrl($resource = '') |
|
69 | { |
||
70 | 2 | return parent::getServiceUrl($resource) . '/' . $this->version; |
|
71 | } |
||
72 | |||
73 | /** |
||
74 | * @param $path |
||
75 | * @return string |
||
76 | */ |
||
77 | 1 | public function getRequestUrl($path) |
|
78 | { |
||
79 | 1 | return parent::getServiceUrl() . $path; |
|
|
|||
80 | } |
||
81 | |||
82 | /** |
||
83 | * @param string $token access token |
||
84 | */ |
||
85 | 25 | public function __construct($token = '') |
|
86 | { |
||
87 | 25 | $this->setAccessToken($token); |
|
88 | 25 | } |
|
89 | |||
90 | /** |
||
91 | * Sends a request |
||
92 | * |
||
93 | * @param string $method HTTP method |
||
94 | * @param string|UriInterface $uri URI object or string. |
||
95 | * @param array $options Request options to apply. |
||
96 | * |
||
97 | * @throws \Exception|\GuzzleHttp\Exception\ClientException |
||
98 | * @return Response |
||
99 | */ |
||
100 | 20 | protected function sendRequest($method, $uri, array $options = []) |
|
101 | { |
||
102 | try { |
||
103 | 20 | $response = $this->getClient()->request($method, $uri, $options); |
|
104 | 20 | } catch (ClientException $ex) { |
|
105 | 2 | $result = $ex->getResponse(); |
|
106 | 2 | $code = $result->getStatusCode(); |
|
107 | 2 | $message = $result->getReasonPhrase(); |
|
108 | |||
109 | 2 | throw new DiskRequestException( |
|
110 | 2 | 'Service responded with error code: "' . $code . '" and message: "' . $message . '"', |
|
111 | $code |
||
112 | 2 | ); |
|
113 | } |
||
114 | |||
115 | 18 | return $response; |
|
116 | } |
||
117 | |||
118 | /** |
||
119 | * @param string $path |
||
120 | * @return bool |
||
121 | * |
||
122 | * @see https://tech.yandex.com/disk/doc/dg/reference/mkcol-docpage/ |
||
123 | */ |
||
124 | 1 | public function createDirectory($path = '') |
|
125 | { |
||
126 | 1 | return (bool) $this->sendRequest('MKCOL', $path); |
|
127 | } |
||
128 | |||
129 | /** |
||
130 | * @param string $path |
||
131 | * @param null $offset |
||
132 | * @param null $amount |
||
133 | * @return array |
||
134 | * |
||
135 | * @see https://tech.yandex.com/disk/doc/dg/reference/propfind_contains-request-docpage/ |
||
136 | */ |
||
137 | 2 | public function directoryContents($path = '', $offset = null, $amount = null) |
|
138 | { |
||
139 | 2 | $response = $this->sendRequest( |
|
140 | 2 | 'PROPFIND', |
|
141 | 2 | $path, |
|
142 | [ |
||
143 | 'headers' => [ |
||
144 | 'Depth' => '1' |
||
145 | 2 | ], |
|
146 | 'query' => [ |
||
147 | 2 | 'offset' => $offset, |
|
148 | 'amount' => $amount |
||
149 | 2 | ] |
|
150 | 2 | ] |
|
151 | 2 | ); |
|
152 | |||
153 | 1 | $decodedResponseBody = $this->getDecodedBody($response->getBody()); |
|
154 | |||
155 | 1 | $contents = []; |
|
156 | 1 | foreach ($decodedResponseBody->children('DAV:') as $element) { |
|
157 | 1 | array_push( |
|
158 | 1 | $contents, |
|
159 | [ |
||
160 | 1 | 'href' => $element->href->__toString(), |
|
161 | 1 | 'status' => $element->propstat->status->__toString(), |
|
162 | 1 | 'creationDate' => $element->propstat->prop->creationdate->__toString(), |
|
163 | 1 | 'lastModified' => $element->propstat->prop->getlastmodified->__toString(), |
|
164 | 1 | 'displayName' => $element->propstat->prop->displayname->__toString(), |
|
165 | 1 | 'contentLength' => $element->propstat->prop->getcontentlength->__toString(), |
|
166 | 1 | 'resourceType' => $element->propstat->prop->resourcetype->collection ? 'dir' : 'file', |
|
167 | 1 | 'contentType' => $element->propstat->prop->getcontenttype->__toString() |
|
168 | 1 | ] |
|
169 | 1 | ); |
|
170 | 1 | } |
|
171 | 1 | return $contents; |
|
172 | } |
||
173 | |||
174 | /** |
||
175 | * @return array |
||
176 | * |
||
177 | * @see https://tech.yandex.com/disk/doc/dg/reference/propfind_space-request-docpage/ |
||
178 | */ |
||
179 | 1 | public function diskSpaceInfo() |
|
180 | { |
||
181 | $body = '<?xml version="1.0" encoding="utf-8" ?><D:propfind xmlns:D="DAV:"> |
||
182 | 1 | <D:prop><D:quota-available-bytes/><D:quota-used-bytes/></D:prop></D:propfind>'; |
|
183 | |||
184 | 1 | $response = $this->sendRequest( |
|
185 | 1 | 'PROPFIND', |
|
186 | 1 | '/', |
|
187 | [ |
||
188 | 'headers' => [ |
||
189 | 'Depth' => '0' |
||
190 | 1 | ], |
|
191 | 'body' => $body |
||
192 | 1 | ] |
|
193 | 1 | ); |
|
194 | |||
195 | 1 | $decodedResponseBody = $this->getDecodedBody($response->getBody()); |
|
196 | |||
197 | 1 | $info = (array) $decodedResponseBody->children('DAV:')->response->propstat->prop; |
|
198 | return [ |
||
199 | 1 | 'usedBytes' => $info['quota-used-bytes'], |
|
200 | 1 | 'availableBytes' => $info['quota-available-bytes'] |
|
201 | 1 | ]; |
|
202 | } |
||
203 | |||
204 | /** |
||
205 | * @param string $path |
||
206 | * @param string $property |
||
207 | * @param string $value |
||
208 | * @param string $namespace |
||
209 | * @return bool |
||
210 | * |
||
211 | * @see https://tech.yandex.com/disk/doc/dg/reference/proppatch-docpage/ |
||
212 | */ |
||
213 | 3 | public function setProperty($path = '', $property = '', $value = '', $namespace = 'default:namespace') |
|
214 | { |
||
215 | 3 | if (!empty($property) && !empty($value)) { |
|
216 | $body = '<?xml version="1.0" encoding="utf-8" ?><propertyupdate xmlns="DAV:" xmlns:u="' |
||
217 | 2 | . $namespace . '"><set><prop><u:' . $property . '>' . $value . '</u:' |
|
218 | 2 | . $property . '></prop></set></propertyupdate>'; |
|
219 | |||
220 | 2 | $response = $this->sendRequest( |
|
221 | 2 | 'PROPPATCH', |
|
222 | 2 | $path, |
|
223 | [ |
||
224 | 'headers' => [ |
||
225 | 2 | 'Content-Length' => strlen($body), |
|
226 | 'Content-Type' => 'application/x-www-form-urlencoded' |
||
227 | 2 | ], |
|
228 | 'body' => $body |
||
229 | 2 | ] |
|
230 | 2 | ); |
|
231 | |||
232 | 2 | $decodedResponseBody = $this->getDecodedBody($response->getBody()); |
|
233 | |||
234 | 2 | $resultStatus = $decodedResponseBody->children('DAV:')->response->propstat->status; |
|
235 | 2 | if (strpos($resultStatus, '200 OK')) { |
|
236 | 1 | return true; |
|
237 | } |
||
238 | 1 | } |
|
239 | 2 | return false; |
|
240 | } |
||
241 | |||
242 | /** |
||
243 | * @param string $path |
||
244 | * @param string $property |
||
245 | * @param string $namespace |
||
246 | * @return string|false |
||
247 | * |
||
248 | * @see https://tech.yandex.com/disk/doc/dg/reference/propfind_property-request-docpage/ |
||
249 | */ |
||
250 | 3 | public function getProperty($path = '', $property = '', $namespace = 'default:namespace') |
|
251 | { |
||
252 | 3 | if (!empty($property)) { |
|
253 | $body = '<?xml version="1.0" encoding="utf-8" ?><propfind xmlns="DAV:"><prop><' . $property |
||
254 | 2 | . ' xmlns="' . $namespace . '"/></prop></propfind>'; |
|
255 | |||
256 | 2 | $response = $this->sendRequest( |
|
257 | 2 | 'PROPFIND', |
|
258 | 2 | $path, |
|
259 | [ |
||
260 | 'headers' => [ |
||
261 | 2 | 'Depth' => '1', |
|
262 | 2 | 'Content-Length' => strlen($body), |
|
263 | 'Content-Type' => 'application/x-www-form-urlencoded' |
||
264 | 2 | ], |
|
265 | 'body' => $body |
||
266 | 2 | ] |
|
267 | 2 | ); |
|
268 | |||
269 | 2 | $decodedResponseBody = $this->getDecodedBody($response->getBody()); |
|
270 | |||
271 | 2 | $resultStatus = $decodedResponseBody->children('DAV:')->response->propstat->status; |
|
272 | 2 | if (strpos($resultStatus, '200 OK')) { |
|
273 | 1 | return (string)$decodedResponseBody->children('DAV:')->response->propstat->prop->children(); |
|
274 | } |
||
275 | 1 | } |
|
276 | |||
277 | 2 | return false; |
|
278 | } |
||
279 | |||
280 | /** |
||
281 | * @return string |
||
282 | * @see https://tech.yandex.com/disk/doc/dg/reference/userinfo-docpage/ |
||
283 | */ |
||
284 | 1 | public function getLogin() |
|
285 | { |
||
286 | 1 | $response = $this->sendRequest( |
|
287 | 1 | 'GET', |
|
288 | '/?userinfo' |
||
289 | 1 | ); |
|
290 | 1 | $result = explode(":", $response->getBody()); |
|
291 | 1 | array_shift($result); |
|
292 | 1 | return implode(':', $result); |
|
293 | } |
||
294 | |||
295 | /** |
||
296 | * @param string $path |
||
297 | * @return array |
||
298 | * |
||
299 | * @see https://tech.yandex.com/disk/doc/dg/reference/get-docpage/ |
||
300 | */ |
||
301 | 1 | public function getFile($path = '') |
|
302 | { |
||
303 | 1 | $response = $this->sendRequest('GET', $path); |
|
304 | |||
305 | 1 | $result = []; |
|
306 | 1 | View Code Duplication | foreach ($response->getHeaders() as $key => $value) { |
307 | 1 | $result['headers'][strtolower($key)] = $value[0]; |
|
308 | 1 | } |
|
309 | 1 | $result['body'] = $response->getBody(); |
|
310 | 1 | return $result; |
|
311 | } |
||
312 | |||
313 | /** |
||
314 | * @param string $path |
||
315 | * @param string $destination |
||
316 | * @param string $name |
||
317 | * @return string|false |
||
318 | * |
||
319 | * @see https://tech.yandex.com/disk/doc/dg/reference/get-docpage/ |
||
320 | */ |
||
321 | 10 | public function downloadFile($path = '', $destination = '', $name = '') |
|
322 | { |
||
323 | 2 | $response = $this->sendRequest('GET', $path); |
|
324 | 2 | if ($name === '' && $response->getHeader('Content-Disposition') |
|
325 | 2 | && is_array($response->getHeader('Content-Disposition')) |
|
326 | 10 | && count($response->getHeader('Content-Disposition')) > 0 |
|
327 | 2 | ) { |
|
328 | 1 | $matchResults = []; |
|
329 | 1 | preg_match( |
|
330 | 1 | "/.*?filename=\"(.*?)\".*?/", |
|
331 | 1 | $response->getHeader('Content-Disposition')[0], |
|
332 | $matchResults |
||
333 | 1 | ); |
|
334 | 1 | $name = urldecode($matchResults[1]); |
|
335 | 1 | } |
|
336 | |||
337 | 2 | $file = $destination . $name; |
|
338 | |||
339 | 2 | $result = file_put_contents($file, $response->getBody()) ? $file : false; |
|
340 | |||
341 | 2 | return $result; |
|
342 | } |
||
343 | |||
344 | /** |
||
345 | * @param string $path |
||
346 | * @param array $file |
||
347 | * @param array $extraHeaders |
||
348 | * @return void |
||
349 | * |
||
350 | * @see https://tech.yandex.com/disk/doc/dg/reference/put-docpage/ |
||
351 | */ |
||
352 | 1 | public function uploadFile($path = '', $file = null, $extraHeaders = null) |
|
353 | { |
||
354 | 1 | if (file_exists($file['path'])) { |
|
355 | $headers = [ |
||
356 | 1 | 'Content-Length' => (string)$file['size'] |
|
357 | 1 | ]; |
|
358 | 1 | $finfo = finfo_open(FILEINFO_MIME); |
|
359 | 1 | $mime = finfo_file($finfo, $file['path']); |
|
360 | 1 | $parts = explode(";", $mime); |
|
361 | 1 | $headers['Content-Type'] = $parts[0]; |
|
362 | 1 | $headers['Etag'] = md5_file($file['path']); |
|
363 | 1 | $headers['Sha256'] = hash_file('sha256', $file['path']); |
|
364 | 1 | $headers = isset($extraHeaders) ? array_merge($headers, $extraHeaders) : $headers; |
|
365 | |||
366 | 1 | $this->sendRequest( |
|
367 | 1 | 'PUT', |
|
368 | 1 | $path . $file['name'], |
|
369 | [ |
||
370 | 1 | 'headers' => $headers, |
|
371 | 1 | 'body' => fopen($file['path'], 'rb'), |
|
372 | 'expect' => true |
||
373 | 1 | ] |
|
374 | 1 | ); |
|
375 | 1 | } |
|
376 | 1 | } |
|
377 | |||
378 | /** |
||
379 | * @param $path |
||
380 | * @param $size |
||
381 | * @return array |
||
382 | * |
||
383 | * @see https://tech.yandex.com/disk/doc/dg/reference/preview-docpage/ |
||
384 | */ |
||
385 | 1 | public function getImagePreview($path, $size) |
|
386 | { |
||
387 | 1 | $response = $this->sendRequest( |
|
388 | 1 | 'GET', |
|
389 | 1 | $path, |
|
390 | [ |
||
391 | 'query' => [ |
||
392 | 1 | 'preview' => '', |
|
393 | 'size' => $size |
||
394 | 1 | ] |
|
395 | 1 | ] |
|
396 | 1 | ); |
|
397 | |||
398 | 1 | $result = []; |
|
399 | 1 | View Code Duplication | foreach ($response->getHeaders() as $key => $value) { |
400 | 1 | $result['headers'][strtolower($key)] = $value[0]; |
|
401 | 1 | } |
|
402 | |||
403 | 1 | $result['body'] = $response->getBody(); |
|
404 | 1 | return $result; |
|
405 | } |
||
406 | |||
407 | /** |
||
408 | * @param string $target |
||
409 | * @param string $destination |
||
410 | * @return bool |
||
411 | * |
||
412 | * @see https://tech.yandex.com/disk/doc/dg/reference/copy-docpage/ |
||
413 | */ |
||
414 | 1 | public function copy($target = '', $destination = '') |
|
426 | |||
427 | /** |
||
428 | * @param string $path |
||
429 | * @param string $destination |
||
430 | * @return bool |
||
431 | * |
||
432 | * @see https://tech.yandex.com/disk/doc/dg/reference/move-docpage/ |
||
433 | */ |
||
434 | 1 | public function move($path = '', $destination = '') |
|
435 | { |
||
436 | 1 | return (bool) $this->sendRequest( |
|
437 | 1 | 'MOVE', |
|
438 | 1 | $path, |
|
439 | [ |
||
440 | 'headers' => [ |
||
441 | 'Destination' => $destination |
||
442 | 1 | ] |
|
443 | 1 | ] |
|
444 | 1 | ); |
|
445 | } |
||
446 | |||
447 | /** |
||
448 | * @param string $path |
||
449 | * @return bool |
||
450 | * |
||
451 | * @see https://tech.yandex.com/disk/doc/dg/reference/delete-docpage/ |
||
452 | */ |
||
453 | 1 | public function delete($path = '') |
|
457 | |||
458 | /** |
||
459 | * @param string $path |
||
460 | * @return string |
||
461 | * |
||
462 | * @see https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#publish-s_1 |
||
463 | * @see https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#publish-s |
||
464 | */ |
||
465 | 1 | public function startPublishing($path = '') |
|
466 | { |
||
467 | $body = '<propertyupdate xmlns="DAV:"><set><prop> |
||
468 | <public_url xmlns="urn:yandex:disk:meta">true</public_url> |
||
469 | 1 | </prop></set></propertyupdate>'; |
|
487 | |||
488 | /** |
||
489 | * @param string $path |
||
490 | * @return void |
||
491 | * |
||
492 | * @see @https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#unpublish |
||
493 | */ |
||
494 | 1 | public function stopPublishing($path = '') |
|
511 | |||
512 | /** |
||
513 | * @param string $path |
||
514 | * @return string|bool |
||
515 | * |
||
516 | * @see https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#unpublish_1 |
||
517 | */ |
||
518 | 1 | public function checkPublishing($path = '') |
|
539 | } |
||
540 |
This check looks for a call to a parent method whose name is different than the method from which it is called.
Consider the following code:
The
getFirstName()
method in theSon
calls the wrong method in the parent class.