nixsolutions /
yandex-php-library
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | View Code Duplication | class Condition extends Model |
|
|
|
|||
| 8 | { |
||
| 9 | |||
| 10 | protected $type = null; |
||
| 11 | |||
| 12 | protected $url = null; |
||
| 13 | |||
| 14 | protected $mappingClasses = []; |
||
| 15 | |||
| 16 | protected $propNameMap = []; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * Retrieve the type property |
||
| 20 | * |
||
| 21 | * @return string|null |
||
| 22 | */ |
||
| 23 | 5 | public function getType() |
|
| 27 | |||
| 28 | /** |
||
| 29 | * Set the type property |
||
| 30 | * |
||
| 31 | * @param string $type |
||
| 32 | * @return $this |
||
| 33 | */ |
||
| 34 | 1 | public function setType($type) |
|
| 35 | { |
||
| 36 | 1 | $this->type = $type; |
|
| 37 | 1 | return $this; |
|
| 38 | } |
||
| 39 | |||
| 40 | /** |
||
| 41 | * Retrieve the url property |
||
| 42 | * |
||
| 43 | * @return string|null |
||
| 44 | */ |
||
| 45 | 5 | public function getUrl() |
|
| 49 | |||
| 50 | /** |
||
| 51 | * Set the url property |
||
| 52 | * |
||
| 53 | * @param string $url |
||
| 54 | * @return $this |
||
| 55 | */ |
||
| 56 | 1 | public function setUrl($url) |
|
| 61 | } |
||
| 62 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.