nixsolutions /
yandex-php-library
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | View Code Duplication | class GetCountersResponse extends Model |
|
|
|
|||
| 9 | { |
||
| 10 | |||
| 11 | protected $counters = null; |
||
| 12 | |||
| 13 | protected $rows = null; |
||
| 14 | |||
| 15 | protected $mappingClasses = [ |
||
| 16 | 'counters' => 'Yandex\Metrica\Management\Models\Counters' |
||
| 17 | ]; |
||
| 18 | |||
| 19 | protected $propNameMap = []; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * Retrieve the counters property |
||
| 23 | * |
||
| 24 | * @return Counters|null |
||
| 25 | */ |
||
| 26 | 2 | public function getCounters() |
|
| 30 | |||
| 31 | /** |
||
| 32 | * Set the counters property |
||
| 33 | * |
||
| 34 | * @param Counters $counters |
||
| 35 | * @return $this |
||
| 36 | */ |
||
| 37 | 1 | public function setCounters($counters) |
|
| 38 | { |
||
| 39 | 1 | $this->counters = $counters; |
|
| 40 | 1 | return $this; |
|
| 41 | } |
||
| 42 | |||
| 43 | /** |
||
| 44 | * Retrieve the rows property |
||
| 45 | * |
||
| 46 | * @return int|null |
||
| 47 | */ |
||
| 48 | 2 | public function getRows() |
|
| 52 | |||
| 53 | /** |
||
| 54 | * Set the rows property |
||
| 55 | * |
||
| 56 | * @param int $rows |
||
| 57 | * @return $this |
||
| 58 | */ |
||
| 59 | 1 | public function setRows($rows) |
|
| 64 | } |
||
| 65 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.