OfferPhotos::add() - Code Metrics - Inspection of "Update README.md" - nixsolutions/yandex-php-library - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9f1d6e...bc3715 )

unknown

created 2020-06-11 13:50 UTC

OfferPhotos::add() A

↳ Parent: OfferPhotos

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	4
CRAP Score	4.5923

Importance

Changes

Metric	Value
dl	10
loc	10
ccs	4
cts	6
cp	0.6667
rs	9.9332
c	0
b	0
f	0
cc	4
nc	3
nop	1
crap	4.5923

<?php

namespace Yandex\Market\Content\Models;

use Yandex\Common\ObjectModel;
use Yandex\Market\Content\Models\OfferPhoto;

class OfferPhotos extends ObjectModel

{
    /**
     * Add photo to collection
     *
     * @param OfferPhoto|array $photo
     *
     * @return OfferPhotos
     */
    public function add($photo)
    {
        if (is_array($photo)) {
            $this->collection[] = new OfferPhoto($photo);
        } elseif (is_object($photo) && $photo instanceof OfferPhoto) {
            $this->collection[] = $photo;
        }

        return $this;
    }

    /**
     * Retrieve the collection property
     *
     * @return Photos|null
     */
    public function getAll()
    {
        return $this->collection;
    }
}


1			<?php
2
3			namespace Yandex\Market\Content\Models;
4
5			use Yandex\Common\ObjectModel;
6			use Yandex\Market\Content\Models\OfferPhoto;
7
8		View Code Duplication	class OfferPhotos extends ObjectModel
			0 ignored issues – show Duplication introduced 2016-01-09 22:55 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9			{
10			/**
11			* Add photo to collection
12			*
13			* @param OfferPhoto\|array $photo
14			*
15			* @return OfferPhotos
16			*/
17	4		public function add($photo)
18			{
19	4		if (is_array($photo)) {
20	4		$this->collection[] = new OfferPhoto($photo);
21			} elseif (is_object($photo) && $photo instanceof OfferPhoto) {
22			$this->collection[] = $photo;
23			}
24
25	4		return $this;
26			}
27
28			/**
29			* Retrieve the collection property
30			*
31			* @return Photos\|null
32			*/
33			public function getAll()
34			{
35			return $this->collection;
36			}
37			}
38

nixsolutions / yandex-php-library

Push — master ( 9f1d6e...bc3715 )

OfferPhotos::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like