Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like DiskClient often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DiskClient, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 31 | class DiskClient extends AbstractServiceClient |
||
| 32 | { |
||
| 33 | const DECODE_TYPE_DEFAULT = self::DECODE_TYPE_XML; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * @var string |
||
| 37 | */ |
||
| 38 | private $version = 'v1'; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var string |
||
| 42 | */ |
||
| 43 | protected $serviceDomain = 'webdav.yandex.ru'; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @param string $version |
||
| 47 | * |
||
| 48 | * @return self |
||
| 49 | */ |
||
| 50 | 1 | public function setVersion($version) |
|
| 56 | |||
| 57 | /** |
||
| 58 | * @return string |
||
| 59 | */ |
||
| 60 | 2 | public function getVersion() |
|
| 64 | |||
| 65 | /** |
||
| 66 | * @inheritdoc |
||
| 67 | */ |
||
| 68 | 2 | public function getServiceUrl($resource = '') |
|
| 72 | |||
| 73 | /** |
||
| 74 | * @param $path |
||
| 75 | * @return string |
||
| 76 | */ |
||
| 77 | 1 | public function getRequestUrl($path) |
|
| 81 | |||
| 82 | /** |
||
| 83 | * @param string $token access token |
||
| 84 | */ |
||
| 85 | 25 | public function __construct($token = '') |
|
| 89 | |||
| 90 | /** |
||
| 91 | * Sends a request |
||
| 92 | * |
||
| 93 | * @param string $method HTTP method |
||
| 94 | * @param string|UriInterface $uri URI object or string. |
||
| 95 | * @param array $options Request options to apply. |
||
| 96 | * |
||
| 97 | * @throws \Exception|\GuzzleHttp\Exception\ClientException |
||
| 98 | * @return Response |
||
| 99 | */ |
||
| 100 | 20 | protected function sendRequest($method, $uri, array $options = []) |
|
| 117 | |||
| 118 | /** |
||
| 119 | * @param string $path |
||
| 120 | * @return bool |
||
| 121 | * |
||
| 122 | * @see https://tech.yandex.com/disk/doc/dg/reference/mkcol-docpage/ |
||
| 123 | */ |
||
| 124 | 1 | public function createDirectory($path = '') |
|
| 128 | |||
| 129 | /** |
||
| 130 | * @param string $path |
||
| 131 | * @param null $offset |
||
| 132 | * @param null $amount |
||
| 133 | * @return array |
||
| 134 | * |
||
| 135 | * @see https://tech.yandex.com/disk/doc/dg/reference/propfind_contains-request-docpage/ |
||
| 136 | */ |
||
| 137 | 2 | public function directoryContents($path = '/', $offset = null, $amount = null, $depth = '1') |
|
| 138 | { |
||
| 139 | 2 | $response = $this->sendRequest( |
|
| 140 | 2 | 'PROPFIND', |
|
| 141 | 2 | $path, |
|
| 142 | [ |
||
| 143 | 'headers' => [ |
||
| 144 | 2 | 'Depth' => $depth |
|
| 145 | ], |
||
| 146 | 'query' => [ |
||
| 147 | 2 | 'offset' => $offset, |
|
| 148 | 2 | 'amount' => $amount |
|
| 149 | ] |
||
| 150 | ] |
||
| 151 | ); |
||
| 152 | |||
| 153 | 1 | $decodedResponseBody = $this->getDecodedBody($response->getBody()); |
|
| 154 | |||
| 155 | 1 | $contents = []; |
|
| 156 | 1 | foreach ($decodedResponseBody->children('DAV:') as $element) { |
|
| 157 | 1 | array_push( |
|
| 158 | 1 | $contents, |
|
| 159 | [ |
||
| 160 | 1 | 'href' => $element->href->__toString(), |
|
| 161 | 1 | 'status' => $element->propstat->status->__toString(), |
|
| 162 | 1 | 'creationDate' => $element->propstat->prop->creationdate->__toString(), |
|
| 163 | 1 | 'lastModified' => $element->propstat->prop->getlastmodified->__toString(), |
|
| 164 | 1 | 'displayName' => $element->propstat->prop->displayname->__toString(), |
|
| 165 | 1 | 'contentLength' => $element->propstat->prop->getcontentlength->__toString(), |
|
| 166 | 1 | 'resourceType' => $element->propstat->prop->resourcetype->collection ? 'dir' : 'file', |
|
| 167 | 1 | 'contentType' => $element->propstat->prop->getcontenttype->__toString() |
|
| 168 | ] |
||
| 169 | ); |
||
| 170 | } |
||
| 171 | 1 | return $contents; |
|
| 172 | } |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @return array |
||
| 176 | * |
||
| 177 | * @see https://tech.yandex.com/disk/doc/dg/reference/propfind_space-request-docpage/ |
||
| 178 | */ |
||
| 179 | 1 | public function diskSpaceInfo() |
|
| 203 | |||
| 204 | /** |
||
| 205 | * @param string $path |
||
| 206 | * @param string $property |
||
| 207 | * @param string $value |
||
| 208 | * @param string $namespace |
||
| 209 | * @return bool |
||
| 210 | * |
||
| 211 | * @see https://tech.yandex.com/disk/doc/dg/reference/proppatch-docpage/ |
||
| 212 | */ |
||
| 213 | 3 | public function setProperty($path = '', $property = '', $value = '', $namespace = 'default:namespace') |
|
| 241 | |||
| 242 | /** |
||
| 243 | * @param string $path |
||
| 244 | * @param string $property |
||
| 245 | * @param string $namespace |
||
| 246 | * @return string|false |
||
| 247 | * |
||
| 248 | * @see https://tech.yandex.com/disk/doc/dg/reference/propfind_property-request-docpage/ |
||
| 249 | */ |
||
| 250 | 3 | public function getProperty($path = '', $property = '', $namespace = 'default:namespace') |
|
| 279 | |||
| 280 | /** |
||
| 281 | * @return string |
||
| 282 | * @see https://tech.yandex.com/disk/doc/dg/reference/userinfo-docpage/ |
||
| 283 | */ |
||
| 284 | 1 | public function getLogin() |
|
| 294 | |||
| 295 | /** |
||
| 296 | * @param string $path |
||
| 297 | * @return array |
||
| 298 | * |
||
| 299 | * @see https://tech.yandex.com/disk/doc/dg/reference/get-docpage/ |
||
| 300 | */ |
||
| 301 | 1 | public function getFile($path = '') |
|
| 312 | |||
| 313 | /** |
||
| 314 | * @param string $path |
||
| 315 | * @param string $destination |
||
| 316 | * @param string $name |
||
| 317 | * @return string|false |
||
| 318 | * |
||
| 319 | * @see https://tech.yandex.com/disk/doc/dg/reference/get-docpage/ |
||
| 320 | */ |
||
| 321 | 2 | public function downloadFile($path = '', $destination = '', $name = '') |
|
| 343 | |||
| 344 | /** |
||
| 345 | * @param string $path |
||
| 346 | * @param array $file |
||
| 347 | * @param array $extraHeaders |
||
| 348 | * @return Response |
||
| 349 | * |
||
| 350 | * @see https://tech.yandex.com/disk/doc/dg/reference/put-docpage/ |
||
| 351 | */ |
||
| 352 | 1 | public function uploadFile($path = '', $file = null, $extraHeaders = null) |
|
| 377 | |||
| 378 | /** |
||
| 379 | * @param $path |
||
| 380 | * @param $size |
||
| 381 | * @return array |
||
| 382 | * |
||
| 383 | * @see https://tech.yandex.com/disk/doc/dg/reference/preview-docpage/ |
||
| 384 | */ |
||
| 385 | 1 | public function getImagePreview($path, $size) |
|
| 406 | |||
| 407 | /** |
||
| 408 | * @param string $target |
||
| 409 | * @param string $destination |
||
| 410 | * @return bool |
||
| 411 | * |
||
| 412 | * @see https://tech.yandex.com/disk/doc/dg/reference/copy-docpage/ |
||
| 413 | */ |
||
| 414 | 1 | public function copy($target = '', $destination = '') |
|
| 426 | |||
| 427 | /** |
||
| 428 | * @param string $path |
||
| 429 | * @param string $destination |
||
| 430 | * @return bool |
||
| 431 | * |
||
| 432 | * @see https://tech.yandex.com/disk/doc/dg/reference/move-docpage/ |
||
| 433 | */ |
||
| 434 | 1 | public function move($path = '', $destination = '') |
|
| 446 | |||
| 447 | /** |
||
| 448 | * @param string $path |
||
| 449 | * @return bool |
||
| 450 | * |
||
| 451 | * @see https://tech.yandex.com/disk/doc/dg/reference/delete-docpage/ |
||
| 452 | */ |
||
| 453 | 1 | public function delete($path = '') |
|
| 457 | |||
| 458 | /** |
||
| 459 | * @param string $path |
||
| 460 | * @return string |
||
| 461 | * |
||
| 462 | * @see https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#publish-s_1 |
||
| 463 | * @see https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#publish-s |
||
| 464 | */ |
||
| 465 | 1 | public function startPublishing($path = '') |
|
| 487 | |||
| 488 | /** |
||
| 489 | * @param string $path |
||
| 490 | * @return void |
||
| 491 | * |
||
| 492 | * @see @https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#unpublish |
||
| 493 | */ |
||
| 494 | 1 | public function stopPublishing($path = '') |
|
| 511 | |||
| 512 | /** |
||
| 513 | * @param string $path |
||
| 514 | * @return string|bool |
||
| 515 | * |
||
| 516 | * @see https://tech.yandex.com/disk/doc/dg/reference/publish-docpage/#unpublish_1 |
||
| 517 | */ |
||
| 518 | 1 | public function checkPublishing($path = '') |
|
| 539 | } |
||
| 540 |
This check looks for a call to a parent method whose name is different than the method from which it is called.
Consider the following code:
The
getFirstName()method in theSoncalls the wrong method in the parent class.