EntrustSetupTables::up() - Code Metrics - Inspection of "Add tests to project" - nixsolutions/laravel-api-boilerplate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by alexfloppy

created 2017-04-07 16:00 UTC

EntrustSetupTables::up() A

↳ Parent: EntrustSetupTables

Complexity

Conditions	1
Paths	1

Size

Total Lines	58
Code Lines	41

Duplication

Lines	48
Ratio	82.76 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	48
loc	58
rs	9.639
cc	1
eloc	41
nc	1
nop	0

How to fix Long Method

<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;

class EntrustSetupTables extends Migration
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the migrations.
     *
     * @return  void
     */
    public function up()
    {
        // Create table for storing roles
        Schema::create('roles', function (Blueprint $table) {

            $table->increments('id');
            $table->string('name')->unique();
            $table->string('display_name')->nullable();
            $table->string('description')->nullable();
            $table->timestamps();
        });

        // Create table for associating roles to users (Many-to-Many)
        Schema::create('role_user', function (Blueprint $table) {

            $table->integer('user_id')->unsigned();
            $table->integer('role_id')->unsigned();

            $table->foreign('user_id')
                ->references('id')
                ->on('users')
                ->onUpdate('cascade')
                ->onDelete('cascade');
            $table->foreign('role_id')
                ->references('id')
                ->on('roles')
                ->onUpdate('cascade')
                ->onDelete('cascade');

            $table->primary(['user_id', 'role_id']);
        });

        // Create table for storing permissions
        Schema::create('permissions', function (Blueprint $table) {

            $table->increments('id');
            $table->string('name')->unique();
            $table->string('display_name')->nullable();
            $table->string('description')->nullable();
            $table->timestamps();
        });

        // Create table for associating permissions to roles (Many-to-Many)
        Schema::create('permission_role', function (Blueprint $table) {

            $table->integer('permission_id')->unsigned();
            $table->integer('role_id')->unsigned();

            $table->foreign('permission_id')
                ->references('id')
                ->on('permissions')
                ->onUpdate('cascade')
                ->onDelete('cascade');
            $table->foreign('role_id')
                ->references('id')
                ->on('roles')
                ->onUpdate('cascade')
                ->onDelete('cascade');

            $table->primary(['permission_id', 'role_id']);
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return  void
     */
    public function down()
    {
        Schema::drop('permission_role');
        Schema::drop('permissions');
        Schema::drop('role_user');
        Schema::drop('roles');
    }
}


1		<?php
2
3		use Illuminate\Database\Migrations\Migration;
4		use Illuminate\Database\Schema\Blueprint;
5
6		class EntrustSetupTables extends Migration
		0 ignored issues – show Coding Style Compatibility introduced 2017-04-07 16:08 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		/**
9		* Run the migrations.
10		*
11		* @return void
12		*/
13		public function up()
14		{
15		// Create table for storing roles
16	View Code Duplication	Schema::create('roles', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2017-04-07 16:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		$table->increments('id');
18		$table->string('name')->unique();
19		$table->string('display_name')->nullable();
20		$table->string('description')->nullable();
21		$table->timestamps();
22		});
23
24		// Create table for associating roles to users (Many-to-Many)
25	View Code Duplication	Schema::create('role_user', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2017-04-07 16:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		$table->integer('user_id')->unsigned();
27		$table->integer('role_id')->unsigned();
28
29		$table->foreign('user_id')
30		->references('id')
31		->on('users')
32		->onUpdate('cascade')
33		->onDelete('cascade');
34		$table->foreign('role_id')
35		->references('id')
36		->on('roles')
37		->onUpdate('cascade')
38		->onDelete('cascade');
39
40		$table->primary(['user_id', 'role_id']);
41		});
42
43		// Create table for storing permissions
44	View Code Duplication	Schema::create('permissions', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2017-04-07 16:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		$table->increments('id');
46		$table->string('name')->unique();
47		$table->string('display_name')->nullable();
48		$table->string('description')->nullable();
49		$table->timestamps();
50		});
51
52		// Create table for associating permissions to roles (Many-to-Many)
53	View Code Duplication	Schema::create('permission_role', function (Blueprint $table) {
		0 ignored issues – show Duplication introduced 2017-04-07 16:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		$table->integer('permission_id')->unsigned();
55		$table->integer('role_id')->unsigned();
56
57		$table->foreign('permission_id')
58		->references('id')
59		->on('permissions')
60		->onUpdate('cascade')
61		->onDelete('cascade');
62		$table->foreign('role_id')
63		->references('id')
64		->on('roles')
65		->onUpdate('cascade')
66		->onDelete('cascade');
67
68		$table->primary(['permission_id', 'role_id']);
69		});
70		}
71
72		/**
73		* Reverse the migrations.
74		*
75		* @return void
76		*/
77		public function down()
78		{
79		Schema::drop('permission_role');
80		Schema::drop('permissions');
81		Schema::drop('role_user');
82		Schema::drop('roles');
83		}
84		}
85

nixsolutions / laravel-api-boilerplate

Pull Request — master (#10)

EntrustSetupTables::up() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like