App\Http\Middleware\StartSession

Complexity

Total Complexity

5

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getSession()	0	7	1
A	getSessionId()	0	4	1
A	handle()	0	8	2

<?php

namespace App\Http\Middleware;

use Illuminate\Contracts\Auth\Guard;
use Illuminate\Session\SessionManager;
use Illuminate\Http\Request;
use Closure;

/**
 * Class StartSession
 * @package App\Http\Middleware
 */
class StartSession extends \Illuminate\Session\Middleware\StartSession
{
    /**
     * @var Guard
     */
    protected $auth;

    /**
     * Create a new session middleware.
     * StartSession constructor.
     * @param SessionManager $manager
     * @param Guard $auth
     */
    public function __construct(SessionManager $manager, Guard $auth)
    {
        parent::__construct($manager);
        $this->manager = $manager;
        $this->auth = $auth;
    }

    /**
     * @inheritdoc
     */
    public function getSession(Request $request)
    {
        $session = $this->manager->driver();
        $session->setId($this->getSessionId($request, $session));

The call to StartSession::getSessionId() has too many arguments starting with $session.

        return $session;
    }

    /**
     * @param Request $request
     * @return mixed
     */
    protected function getSessionId(Request $request)
    {
        return $this->auth->getSession($request);

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Guard as the method getSession() does only exist in the following implementations of said interface: Illuminate\Auth\SessionGuard.

    }

    /**
     * Handle an incoming request, but skip OPTIONS method
     *
     * @inheritdoc
     */
    public function handle($request, Closure $next)
    {
        if ($request->isMethod('options')) {
            return $next($request);
        }

        return parent::handle($request, $next);
    }
}