FacebookController - Code Metrics - nixsolutions/ggf - Measure and Improve Code Quality continuously with Scrutinizer

FacebookController A
last analyzed 2017-03-03 15:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	5
dl	0
loc	30
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	token()	0	23	2

<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Input;
use Illuminate\Support\Facades\Log;
use App\Auth\Guard;

// add other classes you plan to use, e.g.:
// use Facebook\FacebookRequest;
// use Facebook\GraphUser;
// use Facebook\FacebookRequestException;

/**
 * Class FacebookController
 *
 * @package App\Http\Controllers\Auth
 */
class FacebookController extends Controller
{
    /**
     * @param Guard $auth
     * @return \Illuminate\Contracts\Routing\ResponseFactory|\Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function token(Guard $auth)
    {
        try {
            $accessToken = $auth->facebookAuth(Input::get('code'));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

            return response()->json([
                'user' => [
                    'name' => Auth::user()->name,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    'facebookId' => Auth::user()->facebookId,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    'id' => Auth::user()->id
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                ],
                'token_type' => 'bearer',
                'access_token' => $accessToken
            ]);
        } catch (\Exception $e) {
            Log::error(
                'Exception occured, code: ' . $e->getCode()
                . ' with message: ' . $e->getMessage()
            );
        }

        return response('Bad request.', 400);
    }
}


FacebookController A
last analyzed 2017-03-03 15:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Http\Controllers\Auth;
4
5			use App\Http\Controllers\Controller;
6			use Illuminate\Support\Facades\Auth;
7			use Illuminate\Support\Facades\Input;
8			use Illuminate\Support\Facades\Log;
9			use App\Auth\Guard;
10
11			// add other classes you plan to use, e.g.:
12			// use Facebook\FacebookRequest;
13			// use Facebook\GraphUser;
14			// use Facebook\FacebookRequestException;
15
16			/**
17			* Class FacebookController
18			*
19			* @package App\Http\Controllers\Auth
20			*/
21			class FacebookController extends Controller
22			{
23			/**
24			* @param Guard $auth
25			* @return \Illuminate\Contracts\Routing\ResponseFactory\|\Illuminate\Http\JsonResponse\|\Symfony\Component\HttpFoundation\Response
26			*/
27			public function token(Guard $auth)
28			{
29			try {
30			$accessToken = $auth->facebookAuth(Input::get('code'));
			0 ignored issues – show Bug introduced 2016-12-02 12:04 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$accessToken` is correct as `$auth->facebookAuth(\Ill...des\Input::get('code'))` (which targets `App\Auth\Guard::facebookAuth()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
31
32			return response()->json([
33			'user' => [
34			'name' => Auth::user()->name,
			0 ignored issues – show Bug introduced 2017-03-02 15:43 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
35			'facebookId' => Auth::user()->facebookId,
			0 ignored issues – show Bug introduced 2017-03-02 15:43 UTC by Report Bug Copy Issue Report Accessing `facebookId` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
36			'id' => Auth::user()->id
			0 ignored issues – show Bug introduced 2017-03-02 15:43 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37			],
38			'token_type' => 'bearer',
39			'access_token' => $accessToken
40			]);
41			} catch (\Exception $e) {
42			Log::error(
43			'Exception occured, code: ' . $e->getCode()
44			. ' with message: ' . $e->getMessage()
45			);
46			}
47
48			return response('Bad request.', 400);
49			}
50			}
51

nixsolutions / ggf

FacebookController A last analyzed 2017-03-03 15:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

FacebookController A
last analyzed 2017-03-03 15:36 UTC