App\Http\Controllers\API\TeamMemberController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	140
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	catalogue()	0	6	1
A	assign()	0	14	1
A	remove()	0	4	1
A	search()	0	19	1

<?php

namespace App\Http\Controllers\API;

use App\Http\Requests\Team\AssignTeamMember;
use App\Http\Requests\Team\RemoveTeamMember;
use App\Member;
use App\TeamMember;
use App\Transformers\TeamMemberSearchTransformer;
use App\Transformers\TeamMemberTransformer;
use Illuminate\Support\Facades\Input;

/**
 * Class TeamMemberController
 * @package App\Http\Controllers\API
 */
class TeamMemberController extends Controller
{
    /**
     * @SWG\Get(
     *     tags={"Team"},
     *     path="/api/v1/teamMembers",
     *     description="Returns all members of specified team from tournament",
     *     operationId="catalogue",
     *     produces={"application/json"},
     *     @SWG\Parameter(
     *         description="Tournament-team id",
     *         in="query",
     *         name="tournamentTeamId",
     *         required=true,
     *         type="integer"
     *     ),
     *     @SWG\Response(
     *     response="200",
     *     description="Successfully get list of team members"
     *     )
     * )
     */
    public function catalogue()
    {
        $collection = TeamMember::with('Member')->where(['tournamentTeamId' => Input::get('tournamentTeamId')]);

The method where does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        return $this->response->collection($collection->get(), new TeamMemberTransformer(), 'teamMembers');
    }

    /**
     * @SWG\Post(
     *     tags={"Team"},
     *     path="/api/v1/teamMembers",
     *     description="Create new member to specified team",
     *     operationId="assign",
     *     produces={"application/json"},
     *     @SWG\Parameter(
     *         description="Tournament-team id",
     *         in="query",
     *         name="teamMember[teamId]",
     *         required=true,
     *         type="integer"
     *     ),
     *     @SWG\Parameter(
     *         description="Member id",
     *         in="query",
     *         name="teamMember[memberId]",
     *         required=true,
     *         type="integer"
     *     ),
     *     @SWG\Response(
     *     response="200",
     *     description="Successfully add member to team"
     *     )
     * )
     * @param AssignTeamMember $request
     * @return array
     */
    public function assign(AssignTeamMember $request)
    {
        $input = $request->input('teamMember');

        $attributes = [
            'memberId' => array_get($input, 'memberId'),

It seems like $input defined by $request->input('teamMember') on line 77 can also be of type string; however, array_get() does only seem to accept object<ArrayAccess>|array, maybe add an additional type check?

            'tournamentTeamId' => array_get($input, 'teamId'),

It seems like $input defined by $request->input('teamMember') on line 77 can also be of type string; however, array_get() does only seem to accept object<ArrayAccess>|array, maybe add an additional type check?

        ];

        TeamMember::create($attributes);

The method create() does not exist on App\TeamMember. Did you maybe mean created()?

        $teamMember = TeamMember::where($attributes)->get();

        return $this->response->collection($teamMember, new TeamMemberTransformer(), 'teamMembers');
    }

    /**
     * @SWG\Delete(
     *     tags={"Team"},
     *     path="/api/v1/teamMembers/{teamMemberId}",
     *     description="Remove member from specified team",
     *     operationId="remove",
     *     produces={"application/json"},
     *     @SWG\Parameter(
     *         description="Member id",
     *         in="path",
     *         name="teamMemberId",
     *         required=true,
     *         type="integer"
     *     ),
     *     @SWG\Response(
     *     response="200",
     *     description="Successfully remove member from team"
     *     )
     * )
     * @param $teamMemberId
     * @return
     */
    public function remove($teamMemberId)
    {
        return TeamMember::where(['memberId' => $teamMemberId])->delete();
    }

    /**
     * @SWG\Get(
     *     tags={"Team"},
     *     path="/api/v1/teamMembers/search",
     *     description="Returns members we search from database",
     *     operationId="search",
     *     produces={"application/json"},
     *     @SWG\Parameter(
     *         description="Tournament id",
     *         in="query",
     *         name="tournamentId",
     *         required=true,
     *         type="integer"
     *     ),
     *     @SWG\Response(
     *     response="200",
     *     description="Successfully get members we search"
     *     )
     * )
     */
    public function search()
    {
        $tournamentId = Input::get('tournamentId');
        $collection = Member::with(['teamMembers', 'tournamentTeams'])->get();

The method get does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        $collection = $collection->filter(function ($member) use ($tournamentId) {
            $team = $member->tournamentTeams->first(function ($tournamentTeam) use ($tournamentId) {
                return $tournamentTeam->tournamentId == $tournamentId;
            });

            return null === $team;
        });

        return $this->response->collection(
            $collection,
            new TeamMemberSearchTransformer(),
            'members'
        );
    }
}