Issues in Loader.php (master) - Issues in master - nirjharlo/complete-google-seo-scan - Measure and Improve Code Quality continuously with Scrutinizer

Issues (206)

Plugin/Loader.php (4 issues)

Labels

Severity

<?php
namespace NirjharLo\Cgss;

if ( ! defined( 'ABSPATH' ) ) exit;


use \NirjharLo\Cgss\Lib\Script;

use \NirjharLo\Cgss\Lib\Action\Scan;
use \NirjharLo\Cgss\Lib\Action\Insight;

use \NirjharLo\Cgss\Models\Insight as InsightModel;

use \NirjharLo\Cgss\Src\Db;
use \NirjharLo\Cgss\Src\Install;
use \NirjharLo\Cgss\Src\Settings;


final class Loader {

	/**
	 * Plugin Instance.
	 *
	 * @var PLUGIN_BUILD the PLUGIN Instance
	 */
	protected static $instance;


	/**
	 * Main Plugin Instance.
	 *
	 * @return PLUGIN_BUILD
	 */
	public static function instance() {

		if ( is_null( self::$instance ) ) {
			self::$instance = new self();

			self::$instance->init();
		}

		return self::$instance;
	}

	public function installation() {

			$install = new Install();
			$install->textDomin = 'cgss';
			$install->phpVerAllowed = '5.4';
			$install->pluginPageLinks = array(
											array(
												'slug' => home_url().'/wp-admin/admin.php?page=seo-scan',
												'label' => __( 'Dashboard', 'cgss' )
											),
										);
			$install->execute();
	}


	public function db_install() {

			$db = new Db();
			$db->table = 'cgss_insight';
			$db->sql = "ID mediumint(9) NOT NULL AUTO_INCREMENT,
						item varchar(256) NOT NULL,
						remark varchar(512) NOT NULL,
						UNIQUE KEY ID (ID)";
			$db->build();

			$insert_data = $this->insert_prelim_data();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
	}


	public function db_uninstall() {

		$tableName = 'cgss_insight';

		global $wpdb;
		$wpdb->query( "DROP TABLE IF EXISTS {$wpdb->prefix}$tableName" );
	}


        public function insert_prelim_data() {

                $model = new InsightModel();

                if ($model->count() === 0) {

                $init_insight = array(
                                __('Score','cgss'),
                                __('Snippet','cgss'),
                                __('Text','cgss'),
                                __('Links','cgss'),
                                __('Keywords','cgss'),
                                __('Images','cgss'),
                                __('Responsive','cgss'),
                                __('Speed','cgss'),
                                __('Social','cgss')
                        );
                $no_data = __( 'No scan reports are available yet', 'cgss' );
                foreach ($init_insight as $key => $value) {
                        $model->insert($value, $no_data, $key + 1);
                }
                }
        }


	//Include scripts
	public function scripts() {

		new Script();
	}



	//Include settings pages
	public function settings() {

		new Settings();
	}



	// Add custom insight action
	public function insight() {

		new Insight();
	}



	// Add custom insight action
	public function scan() {

		new Scan();
	}


	public function init() {

		register_activation_hook( CGSS_FILE, array( $this, 'db_install' ) );
		register_uninstall_hook( CGSS_FILE, array( 'BUILD', 'db_uninstall' ) ); //$this won't work here.

		add_action('init', array($this, 'installation'));

		$this->scripts();
		$this->settings();

		// Add custom actions, defined in settings
		add_action( 'cgss_scan', array( $this, 'scan' ) );
		add_action( 'cgss_fetch_insight', array( $this, 'insight' ) );
	}
} ?>



1			<?php
2			namespace NirjharLo\Cgss;
3
4			if ( ! defined( 'ABSPATH' ) ) exit;
5
6
7			use \NirjharLo\Cgss\Lib\Script;
8
9			use \NirjharLo\Cgss\Lib\Action\Scan;
10			use \NirjharLo\Cgss\Lib\Action\Insight;
11
12			use \NirjharLo\Cgss\Models\Insight as InsightModel;
13
14			use \NirjharLo\Cgss\Src\Db;
15			use \NirjharLo\Cgss\Src\Install;
16			use \NirjharLo\Cgss\Src\Settings;
17
18
19			final class Loader {
20
21			/**
22			* Plugin Instance.
23			*
24			* @var PLUGIN_BUILD the PLUGIN Instance
25			*/
26			protected static $instance;
27
28
29			/**
30			* Main Plugin Instance.
31			*
32			* @return PLUGIN_BUILD
33			*/
34			public static function instance() {
35
36			if ( is_null( self::$instance ) ) {
37			self::$instance = new self();
			0 ignored issues – show Documentation Bug introduced 2021-12-17 13:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new self()` of type `NirjharLo\Cgss\Loader` is incompatible with the declared type `NirjharLo\Cgss\PLUGIN_BUILD` of property `$instance`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
38			self::$instance->init();
39			}
40
41			return self::$instance;
42			}
43
44			public function installation() {
45
46			$install = new Install();
47			$install->textDomin = 'cgss';
48			$install->phpVerAllowed = '5.4';
49			$install->pluginPageLinks = array(
50			array(
51			'slug' => home_url().'/wp-admin/admin.php?page=seo-scan',
52			'label' => __( 'Dashboard', 'cgss' )
53			),
54			);
55			$install->execute();
56			}
57
58
59			public function db_install() {
60
61			$db = new Db();
62			$db->table = 'cgss_insight';
63			$db->sql = "ID mediumint(9) NOT NULL AUTO_INCREMENT,
64			item varchar(256) NOT NULL,
65			remark varchar(512) NOT NULL,
66			UNIQUE KEY ID (ID)";
67			$db->build();
68
69			$insert_data = $this->insert_prelim_data();
			0 ignored issues – show Unused Code introduced 2018-06-04 12:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$insert_data` is dead and can be removed. Loading history... Bug introduced 2021-12-17 13:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$insert_data` is correct as `$this->insert_prelim_data()` targeting `NirjharLo\Cgss\Loader::insert_prelim_data()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
70			}
71
72
73			public function db_uninstall() {
74
75			$tableName = 'cgss_insight';
76
77			global $wpdb;
78			$wpdb->query( "DROP TABLE IF EXISTS {$wpdb->prefix}$tableName" );
79			}
80
81
82			public function insert_prelim_data() {
83
84			$model = new InsightModel();
85
86			if ($model->count() === 0) {
87
88			$init_insight = array(
89			__('Score','cgss'),
90			__('Snippet','cgss'),
91			__('Text','cgss'),
92			__('Links','cgss'),
93			__('Keywords','cgss'),
94			__('Images','cgss'),
95			__('Responsive','cgss'),
96			__('Speed','cgss'),
97			__('Social','cgss')
98			);
99			$no_data = __( 'No scan reports are available yet', 'cgss' );
100			foreach ($init_insight as $key => $value) {
101			$model->insert($value, $no_data, $key + 1);
102			}
103			}
104			}
105
106
107			//Include scripts
108			public function scripts() {
109
110			new Script();
111			}
112
113
114
115			//Include settings pages
116			public function settings() {
117
118			new Settings();
119			}
120
121
122
123			// Add custom insight action
124			public function insight() {
125
126			new Insight();
127			}
128
129
130
131			// Add custom insight action
132			public function scan() {
133
134			new Scan();
135			}
136
137
138			public function init() {
139
140			register_activation_hook( CGSS_FILE, array( $this, 'db_install' ) );
141			register_uninstall_hook( CGSS_FILE, array( 'BUILD', 'db_uninstall' ) ); //$this won't work here.
142
143			add_action('init', array($this, 'installation'));
144
145			$this->scripts();
146			$this->settings();
147
148			// Add custom actions, defined in settings
149			add_action( 'cgss_scan', array( $this, 'scan' ) );
150			add_action( 'cgss_fetch_insight', array( $this, 'insight' ) );
151			}
152			} ?>
			0 ignored issues – show Best Practice introduced 2018-06-04 12:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
153

nirjharlo / complete-google-seo-scan

Issues (206)

Plugin/Loader.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like