Issues in autoload.php - Fixed Issues - Inspection of "Pattern n restructure" - nirjharlo/complete-google-seo-scan - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by Nirjhar

created 2021-12-17 13:22 UTC

autoload.php (2 issues)

Labels

Bug 2

Severity

<?php
if ( ! defined( 'ABSPATH' ) ) exit;

//Main plugin object to define the plugin
if ( ! class_exists( 'CGSS_BUILD' ) ) {

	final class CGSS_BUILD {



		public function installation() {

			if (class_exists('CGSS_INSTALL')) {

				$install = new CGSS_INSTALL();
				$install->textDomin = 'cgss';
				$install->phpVerAllowed = '5.4';
				$install->pluginPageLinks = array(
												array(
													'slug' => home_url().'/wp-admin/admin.php?page=seo-scan',
													'label' => __( 'Dashboard', 'cgss' )
												),
											);
				$install->execute();
			}
		}


		public function db_install() {

			if ( class_exists( 'CGSS_DB' ) ) {
				$db = new CGSS_DB();
				$db->table = 'cgss_insight';
				$db->sql = "ID mediumint(9) NOT NULL AUTO_INCREMENT,
							item varchar(256) NOT NULL,
							remark varchar(512) NOT NULL,
							UNIQUE KEY ID (ID)";
				$db->build();

				$insert_data = $this->insert_prelim_data();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
			}
		}


		public function db_uninstall() {

			$tableName = 'cgss_insight';

			global $wpdb;
			$wpdb->query( "DROP TABLE IF EXISTS {$wpdb->prefix}$tableName" );
		}


		public function insert_prelim_data() {

			global $wpdb;

			$result = $wpdb->get_results("SELECT * from {$wpdb->prefix}cgss_insight");
    		if(count($result) == 0) {

			$init_insight = array(
					__('Score','cgss'),
					__('Snippet','cgss'),
					__('Text','cgss'),
					__('Links','cgss'),
					__('Keywords','cgss'),
					__('Images','cgss'),
					__('Responsive','cgss'),
					__('Speed','cgss'),
					__('Social','cgss')
				);
			$no_data = __( 'No scan reports are available yet', 'cgss' );
			foreach ($init_insight as $key => $value) {
				$sql = $wpdb->prepare(
					"INSERT INTO {$wpdb->prefix}cgss_insight ( ID, item, remark ) VALUES ( %d, %s, %s )", ($key+1), $value, $no_data
					);
				$query = $wpdb->query($sql);
			}
			}
		}


		//Include scripts
		public function scripts() {

			if ( class_exists( 'CGSS_SCRIPT' ) ) new CGSS_SCRIPT();
		}



		//Include settings pages
		public function settings() {

			if ( class_exists( 'CGSS_SETTINGS' ) ) new CGSS_SETTINGS();
		}



		// Add custom insight action
		public function insight() {

			if ( class_exists( 'CGSS_INSIGHT' ) ) new CGSS_INSIGHT();
		}



		// Add custom insight action
		public function scan() {

			if ( class_exists( 'CGSS_SCAN' ) ) new CGSS_SCAN();
		}



		//Add files for crawling as external resource
		public function vendor() {

			require_once ('vendor/lib/tags.php');
			require_once ('vendor/lib/text.php');
			require_once ('vendor/lib/keywords.php');
			require_once ('vendor/lib/social.php');
			require_once ('vendor/lib/server.php');
			require_once ('vendor/lib/design.php');
			require_once ('vendor/lib/score.php');
			require_once ('vendor/crawl.php');
		}



		//Add functionality files
		public function functionality() {

			require_once ('src/db.php');
			require_once ('src/install.php');
			require_once ('src/settings.php');
		}



		//Call the dependency files
		public function helpers() {

			if ( ! class_exists( 'WP_List_Table' ) ) {
    			require_once( ABSPATH . 'wp-admin/includes/screen.php' );

    			require_once( ABSPATH . 'wp-admin/includes/class-wp-list-table.php' );
			}

			require_once ('lib/table.php');
			require_once ('lib/overview-table.php');
			require_once ('lib/script.php');

			require_once ('lib/action/scan.php');
			require_once ('lib/action/insight.php');
		}



		public function __construct() {

			$this->vendor();
			$this->helpers();
			$this->functionality();

			register_activation_hook( CGSS_FILE, array( $this, 'db_install' ) );
			register_uninstall_hook( CGSS_FILE, array( 'CGSS_BUILD', 'db_uninstall' ) ); //$this won't work here.

			add_action('init', array($this, 'installation'));

			$this->scripts();
			$this->settings();

			// Add custom actions, defined in settings
			add_action( 'cgss_scan', array( $this, 'scan' ) );
			add_action( 'cgss_fetch_insight', array( $this, 'insight' ) );
		}
	}
} ?>


1			<?php
2			if ( ! defined( 'ABSPATH' ) ) exit;
3
4			//Main plugin object to define the plugin
5			if ( ! class_exists( 'CGSS_BUILD' ) ) {
6
7			final class CGSS_BUILD {
8
9
10
11			public function installation() {
12
13			if (class_exists('CGSS_INSTALL')) {
14
15			$install = new CGSS_INSTALL();
16			$install->textDomin = 'cgss';
17			$install->phpVerAllowed = '5.4';
18			$install->pluginPageLinks = array(
19			array(
20			'slug' => home_url().'/wp-admin/admin.php?page=seo-scan',
21			'label' => __( 'Dashboard', 'cgss' )
22			),
23			);
24			$install->execute();
25			}
26			}
27
28
29			public function db_install() {
30
31			if ( class_exists( 'CGSS_DB' ) ) {
32			$db = new CGSS_DB();
33			$db->table = 'cgss_insight';
34			$db->sql = "ID mediumint(9) NOT NULL AUTO_INCREMENT,
35			item varchar(256) NOT NULL,
36			remark varchar(512) NOT NULL,
37			UNIQUE KEY ID (ID)";
38			$db->build();
39
40			$insert_data = $this->insert_prelim_data();
			0 ignored issues – show Bug introduced 2018-06-04 12:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$insert_data` is correct as `$this->insert_prelim_data()` targeting `CGSS_BUILD::insert_prelim_data()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
41			}
42			}
43
44
45			public function db_uninstall() {
46
47			$tableName = 'cgss_insight';
48
49			global $wpdb;
50			$wpdb->query( "DROP TABLE IF EXISTS {$wpdb->prefix}$tableName" );
51			}
52
53
54			public function insert_prelim_data() {
55
56			global $wpdb;
57
58			$result = $wpdb->get_results("SELECT * from {$wpdb->prefix}cgss_insight");
59			if(count($result) == 0) {
60
61			$init_insight = array(
62			__('Score','cgss'),
63			__('Snippet','cgss'),
64			__('Text','cgss'),
65			__('Links','cgss'),
66			__('Keywords','cgss'),
67			__('Images','cgss'),
68			__('Responsive','cgss'),
69			__('Speed','cgss'),
70			__('Social','cgss')
71			);
72			$no_data = __( 'No scan reports are available yet', 'cgss' );
73			foreach ($init_insight as $key => $value) {
74			$sql = $wpdb->prepare(
75			"INSERT INTO {$wpdb->prefix}cgss_insight ( ID, item, remark ) VALUES ( %d, %s, %s )", ($key+1), $value, $no_data
76			);
77			$query = $wpdb->query($sql);
78			}
79			}
80			}
81
82
83			//Include scripts
84			public function scripts() {
85
86			if ( class_exists( 'CGSS_SCRIPT' ) ) new CGSS_SCRIPT();
87			}
88
89
90
91			//Include settings pages
92			public function settings() {
93
94			if ( class_exists( 'CGSS_SETTINGS' ) ) new CGSS_SETTINGS();
95			}
96
97
98
99			// Add custom insight action
100			public function insight() {
101
102			if ( class_exists( 'CGSS_INSIGHT' ) ) new CGSS_INSIGHT();
103			}
104
105
106
107			// Add custom insight action
108			public function scan() {
109
110			if ( class_exists( 'CGSS_SCAN' ) ) new CGSS_SCAN();
111			}
112
113
114
115			//Add files for crawling as external resource
116			public function vendor() {
117
118			require_once ('vendor/lib/tags.php');
119			require_once ('vendor/lib/text.php');
120			require_once ('vendor/lib/keywords.php');
121			require_once ('vendor/lib/social.php');
122			require_once ('vendor/lib/server.php');
123			require_once ('vendor/lib/design.php');
124			require_once ('vendor/lib/score.php');
125			require_once ('vendor/crawl.php');
126			}
127
128
129
130			//Add functionality files
131			public function functionality() {
132
133			require_once ('src/db.php');
134			require_once ('src/install.php');
135			require_once ('src/settings.php');
136			}
137
138
139
140			//Call the dependency files
141			public function helpers() {
142
143			if ( ! class_exists( 'WP_List_Table' ) ) {
144			require_once( ABSPATH . 'wp-admin/includes/screen.php' );
			0 ignored issues – show Bug introduced 2018-06-04 12:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `ABSPATH` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
145			require_once( ABSPATH . 'wp-admin/includes/class-wp-list-table.php' );
146			}
147
148			require_once ('lib/table.php');
149			require_once ('lib/overview-table.php');
150			require_once ('lib/script.php');
151
152			require_once ('lib/action/scan.php');
153			require_once ('lib/action/insight.php');
154			}
155
156
157
158			public function __construct() {
159
160			$this->vendor();
161			$this->helpers();
162			$this->functionality();
163
164			register_activation_hook( CGSS_FILE, array( $this, 'db_install' ) );
165			register_uninstall_hook( CGSS_FILE, array( 'CGSS_BUILD', 'db_uninstall' ) ); //$this won't work here.
166
167			add_action('init', array($this, 'installation'));
168
169			$this->scripts();
170			$this->settings();
171
172			// Add custom actions, defined in settings
173			add_action( 'cgss_scan', array( $this, 'scan' ) );
174			add_action( 'cgss_fetch_insight', array( $this, 'insight' ) );
175			}
176			}
177			} ?>
178

nirjharlo / complete-google-seo-scan

Pull Request — master (#2)

autoload.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like