SendMessageRequest::getUrlPath() - Code Metrics - ninjacto/ortc-php - Measure and Improve Code Quality continuously with Scrutinizer

SendMessageRequest::getUrlPath() A
last analyzed 2016-11-13 10:16 UTC

↳ Parent: SendMessageRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

namespace ninjacto\OrtcPhp\Models\Requests;

use ninjacto\OrtcPhp\Handlers\OrtcResponseHandler;
use ninjacto\OrtcPhp\Handlers\SendMessageResponseHandler;

class SendMessageRequest extends OrtcRequest
{
    /**
     * authentication token.
     *
     * @var string
     */
    private $authToken;

    /**
     * channel name.
     *
     * @var string
     */
    private $channelName;

    /**
     * message.
     *
     * @var string
     */
    private $message;

    /**
     * get url path (not base url).
     *
     * @return string
     */
    public function getUrlPath()
    {
        return $this->getOrtcConfig()->getSendPath();
    }

    /**
     * is post request or get request?
     *
     * @return bool
     */
    public function isPost()
    {
        return true;
    }

    /**
     * get post body.
     *
     * @return array
     */
    public function getPostData()
    {
        $chunks = $this->makeChunks();

        $postData = [];

        foreach ($chunks as $chunk) {
            $postData[] = [
                'AK' => $this->getOrtcConfig()->getApplicationKey(),
                'PK' => $this->getOrtcConfig()->getPrivateKey(),
                'AT' => $this->getAuthToken(),
                'C'  => $this->getChannelName(),
                'M'  => $chunk,
            ];
        }

        return $postData;
    }

    /**
     * split the message into chunks.
     *
     * @return array
     */
    protected function makeChunks()
    {
        $maxSize = $this->getOrtcConfig()->getMaxChunkSize();

        $chunks = str_split($this->getMessage(), $maxSize);
        $numberOfParts = count($chunks);

        $randomString = substr(sha1(rand(1, 10)), -8);

        for ($i = 0; $i < count($chunks); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $preString = strtr(
                $this->getOrtcConfig()->getPreMessageString(),
                [
                    '{RANDOM}'      => $randomString,
                    '{PART}'        => $i + 1,
                    '{TOTAL_PARTS}' => $numberOfParts,
                ]
            );

            $chunks[$i] = $preString . $chunks[$i];
        }

        return $chunks;
    }

    /**
     * @return string
     */
    public function getMessage()
    {
        return $this->message;
    }

    /**
     * @param string $message
     *
     * @return $this
     */
    public function setMessage($message)
    {
        $this->message = $message;

        return $this;
    }

    /**
     * @return string
     */
    public function getAuthToken()
    {
        return $this->authToken;
    }

    /**
     * @param string $authToken
     *
     * @return $this
     */
    public function setAuthToken($authToken)
    {
        $this->authToken = $authToken;

        return $this;
    }

    /**
     * @return string
     */
    public function getChannelName()
    {
        return $this->channelName;
    }

    /**
     * @param string $channelName
     *
     * @return $this
     */
    public function setChannelName($channelName)
    {
        $this->channelName = $channelName;

        return $this;
    }

    /**
     * get response handler.
     *
     * @return OrtcResponseHandler
     */
    public function getResponseHandler()
    {
        return new SendMessageResponseHandler();
    }
}


1		<?php
2
3		namespace ninjacto\OrtcPhp\Models\Requests;
4
5		use ninjacto\OrtcPhp\Handlers\OrtcResponseHandler;
6		use ninjacto\OrtcPhp\Handlers\SendMessageResponseHandler;
7
8		class SendMessageRequest extends OrtcRequest
9		{
10		/**
11		* authentication token.
12		*
13		* @var string
14		*/
15		private $authToken;
16
17		/**
18		* channel name.
19		*
20		* @var string
21		*/
22		private $channelName;
23
24		/**
25		* message.
26		*
27		* @var string
28		*/
29		private $message;
30
31		/**
32		* get url path (not base url).
33		*
34		* @return string
35		*/
36	1	public function getUrlPath()
37		{
38	1	return $this->getOrtcConfig()->getSendPath();
39		}
40
41		/**
42		* is post request or get request?
43		*
44		* @return bool
45		*/
46	1	public function isPost()
47		{
48	1	return true;
49		}
50
51		/**
52		* get post body.
53		*
54		* @return array
55		*/
56	1	public function getPostData()
57		{
58	1	$chunks = $this->makeChunks();
59
60	1	$postData = [];
61
62	1	foreach ($chunks as $chunk) {
63	1	$postData[] = [
64	1	'AK' => $this->getOrtcConfig()->getApplicationKey(),
65	1	'PK' => $this->getOrtcConfig()->getPrivateKey(),
66	1	'AT' => $this->getAuthToken(),
67	1	'C' => $this->getChannelName(),
68	1	'M' => $chunk,
69		];
70	1	}
71
72	1	return $postData;
73		}
74
75		/**
76		* split the message into chunks.
77		*
78		* @return array
79		*/
80	1	protected function makeChunks()
81		{
82	1	$maxSize = $this->getOrtcConfig()->getMaxChunkSize();
83
84	1	$chunks = str_split($this->getMessage(), $maxSize);
85	1	$numberOfParts = count($chunks);
86
87	1	$randomString = substr(sha1(rand(1, 10)), -8);
88
89	1	for ($i = 0; $i < count($chunks); $i++) {
		0 ignored issues – show Performance Best Practice introduced 2016-11-10 11:24 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
90	1	$preString = strtr(
91	1	$this->getOrtcConfig()->getPreMessageString(),
92		[
93	1	'{RANDOM}' => $randomString,
94	1	'{PART}' => $i + 1,
95	1	'{TOTAL_PARTS}' => $numberOfParts,
96		]
97	1	);
98
99	1	$chunks[$i] = $preString . $chunks[$i];
100	1	}
101
102	1	return $chunks;
103		}
104
105		/**
106		* @return string
107		*/
108	2	public function getMessage()
109		{
110	2	return $this->message;
111		}
112
113		/**
114		* @param string $message
115		*
116		* @return $this
117		*/
118	2	public function setMessage($message)
119		{
120	2	$this->message = $message;
121
122	2	return $this;
123		}
124
125		/**
126		* @return string
127		*/
128	2	public function getAuthToken()
129		{
130	2	return $this->authToken;
131		}
132
133		/**
134		* @param string $authToken
135		*
136		* @return $this
137		*/
138	2	public function setAuthToken($authToken)
139		{
140	2	$this->authToken = $authToken;
141
142	2	return $this;
143		}
144
145		/**
146		* @return string
147		*/
148	2	public function getChannelName()
149		{
150	2	return $this->channelName;
151		}
152
153		/**
154		* @param string $channelName
155		*
156		* @return $this
157		*/
158	2	public function setChannelName($channelName)
159		{
160	2	$this->channelName = $channelName;
161
162	2	return $this;
163		}
164
165		/**
166		* get response handler.
167		*
168		* @return OrtcResponseHandler
169		*/
170	1	public function getResponseHandler()
171		{
172	1	return new SendMessageResponseHandler();
173		}
174		}
175

ninjacto / ortc-php

SendMessageRequest::getUrlPath() A last analyzed 2016-11-13 10:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

SendMessageRequest::getUrlPath() A
last analyzed 2016-11-13 10:16 UTC