WidthCollection::get() - Code Metrics - Inspection of "Fixes + updated readme." - nimmneun/onesheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da315f...8e06d5 )

by Stefan

created 2016-08-15 05:29 UTC

WidthCollection::get() A

↳ Parent: WidthCollection

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	10
ccs	5
cts	6
cp	0.8333
rs	9.4285
cc	3
eloc	6
nc	3
nop	2
crap	3.0416

<?php

namespace OneSheet\Width;

/**
 * Class WidthCollection
 *
 * @package OneSheet
 */
class WidthCollection
{
    /**
     * Array containing character widths for each font & size.
     *
     * @var array
     */
    private static $widths = array();

    /**
     * Create character width map for each font.
     */
    public function __construct()
    {
        self::loadWidthsFromCsv(dirname(__FILE__) . '/widths.csv');
//        self::loadAdditionalWidths();

    }

    /**
     * Dirty way to allow developers to load character widths that
     * are not yet included.
     *
     * @param string $csvPath
     */
    public static function loadWidthsFromCsv($csvPath)
    {
        foreach (file($csvPath) as $line) {
            if ($line[0] == 'f') continue;
            $widths = explode(',', trim($line));
            if (count(range(33, 126)) + 3 == count($widths)) {
                $fontName = array_shift($widths);
                $fontSize = array_shift($widths);
                $boldMulti = array_shift($widths);
                self::$widths[$fontName][$fontSize] = array_combine(array_map('chr', range(33, 126)), $widths);
                self::$widths[$fontName][$fontSize] += array('bold' => $boldMulti);
            }
        }
    }

//    Testing additional character widths ... fixed types.

//    private static function loadAdditionalWidths()
//    {
//        $hiragana = array('ぁ','あ','ぃ','い','ぅ','う','ぇ','え','ぉ','お','か','が','き','ぎ','く','ぐ','け','げ','こ','ご','さ','ざ','し','じ','す','ず','せ','ぜ','そ','ぞ','た','だ','ち','ぢ','っ','つ','づ','て','で','と','ど','な','に','ぬ','ね','の','は','ば','ぱ','ひ','び','ぴ','ふ','ぶ','ぷ','へ','べ','ぺ','ほ','ぼ','ぽ','ま','み','む','め','も','ゃ','や','ゅ','ゆ','ょ','よ','ら','り','る','れ','ろ','ゎ','わ','ゐ','ゑ','を','ん','ゔ','ゕ','ゖ');
//        foreach (self::$widths as &$width) {
//            $width[9] += array_combine($hiragana, array_fill(0, count($hiragana), 1.76));
//            $width[10] += array_combine($hiragana, array_fill(0, count($hiragana), 2.06));
//            $width[11] += array_combine($hiragana, array_fill(0, count($hiragana), 2.35));
//            $width[12] += array_combine($hiragana, array_fill(0, count($hiragana), 2.35));
//            $width[13] += array_combine($hiragana, array_fill(0, count($hiragana), 2.65));
//            $width[14] += array_combine($hiragana, array_fill(0, count($hiragana), 2.94));
//            $width[15] += array_combine($hiragana, array_fill(0, count($hiragana), 2.94));
//        }
//    }

    /**
     * Return character widths for given font name.
     *
     * @param string $fontName
     * @param int    $fontSize
     * @return array
     */
    public function get($fontName, $fontSize)
    {
        if (isset(self::$widths[$fontName][$fontSize])) {
            return self::$widths[$fontName][$fontSize];
        } elseif (isset(self::$widths['Calibri'][$fontSize])) {
            return self::$widths['Calibri'][$fontSize];
        }

        return self::$widths['Calibri'][11];
    }
}


1		<?php
2
3		namespace OneSheet\Width;
4
5		/**
6		* Class WidthCollection
7		*
8		* @package OneSheet
9		*/
10		class WidthCollection
11		{
12		/**
13		* Array containing character widths for each font & size.
14		*
15		* @var array
16		*/
17		private static $widths = array();
18
19		/**
20		* Create character width map for each font.
21		*/
22	6	public function __construct()
23		{
24	6	self::loadWidthsFromCsv(dirname(__FILE__) . '/widths.csv');
25		// self::loadAdditionalWidths();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-15 05:33 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26	6	}
27
28		/**
29		* Dirty way to allow developers to load character widths that
30		* are not yet included.
31		*
32		* @param string $csvPath
33		*/
34	6	public static function loadWidthsFromCsv($csvPath)
35		{
36	6	foreach (file($csvPath) as $line) {
37	6	if ($line[0] == 'f') continue;
38	6	$widths = explode(',', trim($line));
39	6	if (count(range(33, 126)) + 3 == count($widths)) {
40	6	$fontName = array_shift($widths);
41	6	$fontSize = array_shift($widths);
42	6	$boldMulti = array_shift($widths);
43	6	self::$widths[$fontName][$fontSize] = array_combine(array_map('chr', range(33, 126)), $widths);
44	6	self::$widths[$fontName][$fontSize] += array('bold' => $boldMulti);
45	6	}
46	6	}
47	6	}
48
49		// Testing additional character widths ... fixed types.
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-15 05:26 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50		// private static function loadAdditionalWidths()
51		// {
52		// $hiragana = array('ぁ','あ','ぃ','い','ぅ','う','ぇ','え','ぉ','お','か','が','き','ぎ','く','ぐ','け','げ','こ','ご','さ','ざ','し','じ','す','ず','せ','ぜ','そ','ぞ','た','だ','ち','ぢ','っ','つ','づ','て','で','と','ど','な','に','ぬ','ね','の','は','ば','ぱ','ひ','び','ぴ','ふ','ぶ','ぷ','へ','べ','ぺ','ほ','ぼ','ぽ','ま','み','む','め','も','ゃ','や','ゅ','ゆ','ょ','よ','ら','り','る','れ','ろ','ゎ','わ','ゐ','ゑ','を','ん','ゔ','ゕ','ゖ');
53		// foreach (self::$widths as &$width) {
54		// $width[9] += array_combine($hiragana, array_fill(0, count($hiragana), 1.76));
55		// $width[10] += array_combine($hiragana, array_fill(0, count($hiragana), 2.06));
56		// $width[11] += array_combine($hiragana, array_fill(0, count($hiragana), 2.35));
57		// $width[12] += array_combine($hiragana, array_fill(0, count($hiragana), 2.35));
58		// $width[13] += array_combine($hiragana, array_fill(0, count($hiragana), 2.65));
59		// $width[14] += array_combine($hiragana, array_fill(0, count($hiragana), 2.94));
60		// $width[15] += array_combine($hiragana, array_fill(0, count($hiragana), 2.94));
61		// }
62		// }
63
64		/**
65		* Return character widths for given font name.
66		*
67		* @param string $fontName
68		* @param int $fontSize
69		* @return array
70		*/
71	4	public function get($fontName, $fontSize)
72		{
73	4	if (isset(self::$widths[$fontName][$fontSize])) {
74	4	return self::$widths[$fontName][$fontSize];
75	1	} elseif (isset(self::$widths['Calibri'][$fontSize])) {
76	1	return self::$widths['Calibri'][$fontSize];
77		}
78
79		return self::$widths['Calibri'][11];
80		}
81		}
82

nimmneun / onesheet

Push — master ( da315f...8e06d5 )

WidthCollection::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like