Database::executeStatement() - Code Metrics - Inspection of "3.0.0.18" - nilsteampassnet/TeamPass - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bda737...e0ed8e )

by Nils

created 2022-05-25 09:46 UTC

Database::executeStatement() A

↳ Parent: Database

Complexity

Conditions	4
Paths	7

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	10
c	1
b	0
f	0
nc	7
nop	2
dl	0
loc	18
rs	9.9332

<?php
/**
 * Teampass - a collaborative passwords manager.
 * ---
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 * ---
 *
 * @project   Teampass API
 *
 * @file      Database.php
 * ---
 *
 * @author    Nils Laumaillé ([email protected])
 *
 * @copyright 2009-2022 Teampass.net
 *
 * @license   https://spdx.org/licenses/GPL-3.0-only.html#licenseText GPL-3.0
 * ---
 *
 * @see       https://www.teampass.net
 */
class Database
{
    protected $connection = null;
 
    public function __construct()
    {
        try {
            $this->connection = new mysqli(DB_HOST, DB_USER, DB_PASSWD_CLEAR, DB_NAME);

            if ( mysqli_connect_errno()) {
                throw new Exception("Could not connect to database.");   
            }
        } catch (Exception $e) {
            throw new Exception($e->getMessage());   
        }           
    }
 
    public function select($query = "" , $params = [])
    {
        try {
            $stmt = $this->executeStatement( $query , $params );
            $result = $stmt->get_result()->fetch_all(MYSQLI_ASSOC);               
            $stmt->close();
 
            return $result;
        } catch(Exception $e) {
            throw New Exception( $e->getMessage() );
        }
        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
 
    private function executeStatement($query = "" , $params = [])
    {
        try {
            $stmt = $this->connection->prepare( $query );
 
            if($stmt === false) {
                throw New Exception("Unable to do prepared statement: " . $query);
            }
 
            if( $params ) {
                $stmt->bind_param($params[0], $params[1]);
            }
 
            $stmt->execute();
 
            return $stmt;
        } catch(Exception $e) {
            throw New Exception( $e->getMessage() );
        }   
    }
}

1			<?php
2			/**
3			* Teampass - a collaborative passwords manager.
4			* ---
5			* This library is distributed in the hope that it will be useful,
6			* but WITHOUT ANY WARRANTY; without even the implied warranty of
7			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
8			* ---
9			*
10			* @project Teampass API
11			*
12			* @file Database.php
13			* ---
14			*
15			* @author Nils Laumaillé ([email protected])
16			*
17			* @copyright 2009-2022 Teampass.net
18			*
19			* @license https://spdx.org/licenses/GPL-3.0-only.html#licenseText GPL-3.0
20			* ---
21			*
22			* @see https://www.teampass.net
23			*/
24			class Database
25			{
26			protected $connection = null;
27
28			public function __construct()
29			{
30			try {
31			$this->connection = new mysqli(DB_HOST, DB_USER, DB_PASSWD_CLEAR, DB_NAME);
32
33			if ( mysqli_connect_errno()) {
34			throw new Exception("Could not connect to database.");
35			}
36			} catch (Exception $e) {
37			throw new Exception($e->getMessage());
38			}
39			}
40
41			public function select($query = "" , $params = [])
42			{
43			try {
44			$stmt = $this->executeStatement( $query , $params );
45			$result = $stmt->get_result()->fetch_all(MYSQLI_ASSOC);
46			$stmt->close();
47
48			return $result;
49			} catch(Exception $e) {
50			throw New Exception( $e->getMessage() );
51			}
52			return false;
			0 ignored issues – show Unused Code introduced 2022-05-25 09:55 UTC by Report Bug Copy Issue Report `return false` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
53			}
54
55			private function executeStatement($query = "" , $params = [])
56			{
57			try {
58			$stmt = $this->connection->prepare( $query );
59
60			if($stmt === false) {
61			throw New Exception("Unable to do prepared statement: " . $query);
62			}
63
64			if( $params ) {
65			$stmt->bind_param($params[0], $params[1]);
66			}
67
68			$stmt->execute();
69
70			return $stmt;
71			} catch(Exception $e) {
72			throw New Exception( $e->getMessage() );
73			}
74			}
75			}

nilsteampassnet / TeamPass

Push — master ( bda737...e0ed8e )

Database::executeStatement() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like