nilsteampassnet / TeamPass

api/Controller/Api/BaseController.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
         $requestUri = $request->getRequestUri();
 
         $uri = parse_url($requestUri, PHP_URL_PATH);
-        $uri = explode( '/', $uri );
+        $uri = explode('/', $uri);
         return $this->sanitizeUrl(array_slice($uri, ((int) array_search('index.php', $uri) + 1)));
     }
 
@@ -74,7 +74,7 @@ 
     {
         $filters = [];
         $array_size = count($array);
-        for ($i=0; $i < $array_size; $i++) {
+        for ($i = 0; $i < $array_size; $i++) {
             array_push($filters, 'trim|escape');
         }
         
@@ -92,7 +92,7 @@ 
      * @param mixed  $data
      * @param string $httpHeader
      */
-    protected function sendOutput($data, $httpHeaders=array()): void
+    protected function sendOutput($data, $httpHeaders = array()): void
     {
         header_remove('Set-Cookie');
 

api/inc/jwt_utils.php

Indentation +50 added lines, -50 removed lines

@@ -37,45 +37,45 @@ 
  * @return boolean
  */
 function is_jwt_valid($jwt) {
-	try {
-		$decoded = (array) JWT::decode($jwt, new Key(DB_PASSWD, 'HS256'));
+    try {
+        $decoded = (array) JWT::decode($jwt, new Key(DB_PASSWD, 'HS256'));
 
-		// Check if expiration is reached
-		if ($decoded['exp'] - time() < 0) {
-			return false;
-		}
+        // Check if expiration is reached
+        if ($decoded['exp'] - time() < 0) {
+            return false;
+        }
 /*
 		$decoded1 = JWT::decode($jwt, new Key(DB_PASSWD, 'HS256'), $headers = new stdClass());
 		print_r($headers);
 */
 
-		return true;
-	} catch (InvalidArgumentException $e) {
-		// provided key/key-array is empty or malformed.
-		return false;
-	} catch (DomainException $e) {
-		// provided algorithm is unsupported OR
-		// provided key is invalid OR
-		// unknown error thrown in openSSL or libsodium OR
-		// libsodium is required but not available.
-		return false;
-	} catch (SignatureInvalidException $e) {
-		// provided JWT signature verification failed.
-		return false;
-	} catch (BeforeValidException $e) {
-		// provided JWT is trying to be used before "nbf" claim OR
-		// provided JWT is trying to be used before "iat" claim.
-		return false;
-	} catch (ExpiredException $e) {
-		// provided JWT is trying to be used after "exp" claim.
-		return false;
-	} catch (UnexpectedValueException $e) {
-		// provided JWT is malformed OR
-		// provided JWT is missing an algorithm / using an unsupported algorithm OR
-		// provided JWT algorithm does not match provided key OR
-		// provided key ID in key/key-array is empty or invalid.
-		return false;
-	}
+        return true;
+    } catch (InvalidArgumentException $e) {
+        // provided key/key-array is empty or malformed.
+        return false;
+    } catch (DomainException $e) {
+        // provided algorithm is unsupported OR
+        // provided key is invalid OR
+        // unknown error thrown in openSSL or libsodium OR
+        // libsodium is required but not available.
+        return false;
+    } catch (SignatureInvalidException $e) {
+        // provided JWT signature verification failed.
+        return false;
+    } catch (BeforeValidException $e) {
+        // provided JWT is trying to be used before "nbf" claim OR
+        // provided JWT is trying to be used before "iat" claim.
+        return false;
+    } catch (ExpiredException $e) {
+        // provided JWT is trying to be used after "exp" claim.
+        return false;
+    } catch (UnexpectedValueException $e) {
+        // provided JWT is malformed OR
+        // provided JWT is missing an algorithm / using an unsupported algorithm OR
+        // provided JWT algorithm does not match provided key OR
+        // provided key ID in key/key-array is empty or invalid.
+        return false;
+    }
 }
 
 function base64url_encode($data) {
@@ -84,23 +84,23 @@ 
 
 function get_authorization_header()
 {
-	$request = symfonyRequest::createFromGlobals();
-	$authorizationHeader = $request->headers->get('Authorization');
-	$headers = null;
+    $request = symfonyRequest::createFromGlobals();
+    $authorizationHeader = $request->headers->get('Authorization');
+    $headers = null;
 	
-	if (null !== $authorizationHeader) {
-		$headers = trim($authorizationHeader);
-	} else if (function_exists('apache_request_headers') === true) {
-		$requestHeaders = (array) apache_request_headers();
-		// Server-side fix for bug in old Android versions (a nice side-effect of this fix means we don't care about capitalization for Authorization)
-		$requestHeaders = array_combine(array_map('ucwords', array_keys($requestHeaders)), array_values($requestHeaders));
-		//print_r($requestHeaders);
-		if (isset($requestHeaders['Authorization']) === true) {
-			$headers = trim($requestHeaders['Authorization']);
-		}
-	}
+    if (null !== $authorizationHeader) {
+        $headers = trim($authorizationHeader);
+    } else if (function_exists('apache_request_headers') === true) {
+        $requestHeaders = (array) apache_request_headers();
+        // Server-side fix for bug in old Android versions (a nice side-effect of this fix means we don't care about capitalization for Authorization)
+        $requestHeaders = array_combine(array_map('ucwords', array_keys($requestHeaders)), array_values($requestHeaders));
+        //print_r($requestHeaders);
+        if (isset($requestHeaders['Authorization']) === true) {
+            $headers = trim($requestHeaders['Authorization']);
+        }
+    }
 	
-	return $headers;
+    return $headers;
 }
 
 function get_bearer_token() {
@@ -117,8 +117,8 @@ 
 
 function get_bearer_data($jwt) {
     // split the jwt
-	$tokenParts = explode('.', $jwt);
-	$payload = base64_decode($tokenParts[1]);
+    $tokenParts = explode('.', $jwt);
+    $payload = base64_decode($tokenParts[1]);
 	
     // HEADER: Get the access token from the header
     if (empty($payload) === false) {

api/Controller/Api/FolderController.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
                     $arrFolders = $folderModel->getFoldersInfo(explode(",", $userData['folders_list']));
                     $responseData = json_encode($arrFolders);
                 } catch (Error $e) {
-                    $strErrorDesc = $e->getMessage() . ' Something went wrong! Please contact support.3';
+                    $strErrorDesc = $e->getMessage().' Something went wrong! Please contact support.3';
                     $strErrorHeader = 'HTTP/1.1 500 Internal Server Error';
                 }
             }
@@ -121,7 +121,7 @@ 
                         
                         $responseData = json_encode($arrFolder);
                     } catch (Error $e) {
-                        $strErrorDesc = $e->getMessage() . ' Something went wrong! Please contact support.1';
+                        $strErrorDesc = $e->getMessage().' Something went wrong! Please contact support.1';
                         $strErrorHeader = 'HTTP/1.1 500 Internal Server Error';
                     }
                 }

scripts/background_tasks___items_handler.php

Braces +12 added lines, -4 removed lines

@@ -86,7 +86,9 @@ 
 
 if (DB::count() > 0) {
     // handle tasks inside this process
-    if (WIP === true) error_log("Process in progress: ".$process_to_perform['increment_id']);
+    if (WIP === true) {
+        error_log("Process in progress: ".$process_to_perform['increment_id']);
+    }
     handleTask(
         $process_to_perform['increment_id'],
         json_decode($process_to_perform['arguments'], true),
@@ -103,7 +105,9 @@ 
     );
     
     if (DB::count() > 0) {
-        if (WIP === true) error_log("New process ta start: ".$process_to_perform['increment_id']);
+        if (WIP === true) {
+            error_log("New process ta start: ".$process_to_perform['increment_id']);
+        }
         // update DB - started_at
         DB::update(
             prefixTable('background_tasks'),
@@ -306,7 +310,9 @@ 
     if ($args['step'] === 'create_users_files_key') {
         // Loop on all files for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
+        }
         foreach($args['files_keys'] as $file) {
             storeUsersShareKey(
                 prefixTable('sharekeys_items'),
@@ -323,7 +329,9 @@ 
     } elseif ($args['step'] === 'create_users_fields_key') {
         // Loop on all encrypted fields for this item
         // and encrypt them for each user
-        if (WIP === true) provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        if (WIP === true) {
+            provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
+        }
         foreach($args['fields_keys'] as $field) {
             storeUsersShareKey(
                 prefixTable('sharekeys_fields'),

Spacing +13 added lines, -13 removed lines

@@ -78,7 +78,7 @@ 
 DB::debugmode(false);
 $process_to_perform = DB::queryfirstrow(
     'SELECT *
-    FROM ' . prefixTable('background_tasks') . '
+    FROM ' . prefixTable('background_tasks').'
     WHERE is_in_progress = %i AND process_type IN ("item_copy", "new_item", "update_item", "item_update_create_keys")
     ORDER BY increment_id ASC',
     1
@@ -96,7 +96,7 @@ 
     // search for next process to handle
     $process_to_perform = DB::queryfirstrow(
         'SELECT *
-        FROM ' . prefixTable('background_tasks') . '
+        FROM ' . prefixTable('background_tasks').'
         WHERE is_in_progress = %i AND (finished_at = "" OR finished_at IS NULL) AND process_type IN ("item_copy", "new_item", "update_item", "item_update_create_keys")
         ORDER BY increment_id ASC',
         0
@@ -114,7 +114,7 @@ 
             $process_to_perform['increment_id']
         );
 
-        provideLog('[PROCESS][#'. $process_to_perform['increment_id'].'][START]', $SETTINGS);
+        provideLog('[PROCESS][#'.$process_to_perform['increment_id'].'][START]', $SETTINGS);
         handleTask(
             $process_to_perform['increment_id'],
             json_decode($process_to_perform['arguments'], true),
@@ -136,7 +136,7 @@ 
 // launch a new iterative process
 $process_to_perform = DB::queryfirstrow(
     'SELECT *
-    FROM ' . prefixTable('background_tasks') . '
+    FROM ' . prefixTable('background_tasks').'
     WHERE is_in_progress = %i AND process_type IN ("item_copy", "new_item", "update_item", "item_update_create_keys")
     ORDER BY increment_id DESC',
     1
@@ -159,10 +159,10 @@ 
  */
 function handleTask(int $processId, array $ProcessArguments, array $SETTINGS, int $itemId = null): bool
 {
-    provideLog('[PROCESS][#'. $processId.'][START]', $SETTINGS);
+    provideLog('[PROCESS][#'.$processId.'][START]', $SETTINGS);
     $task_to_perform = DB::queryfirstrow(
         'SELECT *
-        FROM ' . prefixTable('background_subtasks') . '
+        FROM ' . prefixTable('background_subtasks').'
         WHERE task_id = %i AND finished_at IS NULL
         ORDER BY increment_id ASC',
         $processId
@@ -177,7 +177,7 @@ 
         if ((int) $task_to_perform['sub_task_in_progress'] === 0) {
             // handle next task
             $args = json_decode($task_to_perform['task'], true);
-            provideLog('[TASK][#'. $task_to_perform['increment_id'].'][START]Task '.$args['step'], $SETTINGS);
+            provideLog('[TASK][#'.$task_to_perform['increment_id'].'][START]Task '.$args['step'], $SETTINGS);
 
             // flag as in progress
             DB::update(
@@ -219,7 +219,7 @@ 
             DB::update(
                 prefixTable('background_subtasks'),
                 array(
-                    'sub_task_in_progress' => 0,    // flag sub task is no more in prgoress
+                    'sub_task_in_progress' => 0, // flag sub task is no more in prgoress
                     'task' => json_encode(["status" => "Done"]),
                     'is_in_progress' => -1,
                     'finished_at' => time(),
@@ -234,7 +234,7 @@ 
             // are all tasks done?
             DB::query(
                 'SELECT *
-                FROM ' . prefixTable('background_subtasks') . '
+                FROM ' . prefixTable('background_subtasks').'
                 WHERE task_id = %i AND finished_at IS NULL',
                 $processId
             );
@@ -264,7 +264,7 @@ 
 
         } else {
             // Task is currently being in progress by another server process
-            provideLog('[TASK][#'. $task_to_perform['increment_id'].'][WARNING] Similar task already being processes', $SETTINGS);
+            provideLog('[TASK][#'.$task_to_perform['increment_id'].'][WARNING] Similar task already being processes', $SETTINGS);
             return false;
         }
     } else {
@@ -311,7 +311,7 @@ 
         // Loop on all files for this item
         // and encrypt them for each user
         if (WIP === true) provideLog('[DEBUG] '.print_r($args['files_keys'], true), $SETTINGS);
-        foreach($args['files_keys'] as $file) {
+        foreach ($args['files_keys'] as $file) {
             storeUsersShareKey(
                 prefixTable('sharekeys_items'),
                 0,
@@ -328,7 +328,7 @@ 
         // Loop on all encrypted fields for this item
         // and encrypt them for each user
         if (WIP === true) provideLog('[DEBUG] '.print_r($args, true), $SETTINGS);
-        foreach($args['fields_keys'] as $field) {
+        foreach ($args['fields_keys'] as $field) {
             storeUsersShareKey(
                 prefixTable('sharekeys_fields'),
                 0,
@@ -382,6 +382,6 @@ 
     DB::query(
         'DELETE FROM '.prefixTable('items_edition').'
         WHERE timestamp < %i',
-        ($SETTINGS['delay_item_edition'] > 0) ? time() - ($SETTINGS['delay_item_edition']*60) : time() - EDITION_LOCK_PERIOD
+        ($SETTINGS['delay_item_edition'] > 0) ? time() - ($SETTINGS['delay_item_edition'] * 60) : time() - EDITION_LOCK_PERIOD
     );
 }
\ No newline at end of file

scripts/background_tasks___do_calculation.php

Spacing +4 added lines, -4 removed lines

@@ -74,7 +74,7 @@ 
     // get count of Items in this folder
     $get = DB::queryfirstrow(
         'SELECT count(*) as num_results
-        FROM ' . prefixTable('items') . '
+        FROM ' . prefixTable('items').'
         WHERE inactif = %i AND id_tree = %i',
         0,
         $child->id
@@ -83,14 +83,14 @@ 
     $ret[$child->id]['id'] = $child->id;
 
     // get number of subfolders
-    $nodeDescendants =$tree->getDescendants($child->id, false, false, true);
+    $nodeDescendants = $tree->getDescendants($child->id, false, false, true);
     $ret[$child->id]['subfoldersCount'] = count($nodeDescendants);
 
     // get items number in subfolders
     if (count($nodeDescendants) > 0) {
         $get = DB::queryfirstrow(
             'SELECT count(*) as num_results
-            FROM ' . prefixTable('items') . '
+            FROM ' . prefixTable('items').'
             WHERE inactif = %i AND id_tree IN (%l)',
             0,
             implode(',', $nodeDescendants)
@@ -138,7 +138,7 @@ 
     // Get item key
     $itemKey = DB::queryFirstRow(
         'SELECT share_key
-        FROM ' . prefixTable('sharekeys_items') . '
+        FROM ' . prefixTable('sharekeys_items').'
         WHERE user_id = %i AND object_id = %i',
         TP_USER_ID,
         $item['itemId']

scripts/task_maintenance_clean_orphan_objects.php

Spacing +18 added lines, -18 removed lines

@@ -131,64 +131,64 @@
 
     // Delete all item keys for which no user exist
     DB::query(
-        'DELETE k FROM ' . prefixTable('sharekeys_items') . ' k
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
+        'DELETE k FROM '.prefixTable('sharekeys_items').' k
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
     );
 
     // Delete all files keys for which no user exist
     DB::query(
-        'DELETE k FROM ' . prefixTable('sharekeys_files') . ' k
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
+        'DELETE k FROM '.prefixTable('sharekeys_files').' k
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
     );
 
     // Delete all fields keys for which no user exist
     DB::query(
-        'DELETE k FROM ' . prefixTable('sharekeys_fields') . ' k
-        LEFT JOIN ' . prefixTable('users') . ' u ON k.user_id = u.id
+        'DELETE k FROM '.prefixTable('sharekeys_fields').' k
+        LEFT JOIN ' . prefixTable('users').' u ON k.user_id = u.id
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
     );
 
     // Delete all item logs for which no user exist
     DB::query(
-        'DELETE l FROM ' . prefixTable('log_items') . ' l
-        LEFT JOIN ' . prefixTable('users') . ' u ON l.id_user = u.id
+        'DELETE l FROM '.prefixTable('log_items').' l
+        LEFT JOIN ' . prefixTable('users').' u ON l.id_user = u.id
         WHERE u.id IS NULL OR u.deleted_at IS NOT NULL'
     );
 
     // Delete all system logs for which no user exist
     DB::query(
-        'DELETE l FROM ' . prefixTable('log_system') . ' l
-        LEFT JOIN ' . prefixTable('users') . ' u ON l.qui = u.id
+        'DELETE l FROM '.prefixTable('log_system').' l
+        LEFT JOIN ' . prefixTable('users').' u ON l.qui = u.id
         WHERE i.id IS NULL OR u.deleted_at IS NOT NULL'
     );
 
     // Delete all item keys for which no object exist
     DB::query(
-        'DELETE k FROM ' . prefixTable('sharekeys_items') . ' k
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
+        'DELETE k FROM '.prefixTable('sharekeys_items').' k
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
         WHERE i.id IS NULL'
     );
 
     // Delete all files keys for which no object exist
     DB::query(
-        'DELETE k FROM ' . prefixTable('sharekeys_files') . ' k
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
+        'DELETE k FROM '.prefixTable('sharekeys_files').' k
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
         WHERE i.id IS NULL'
     );
 
     // Delete all fields keys for which no object exist
     DB::query(
-        'DELETE k FROM ' . prefixTable('sharekeys_fields') . ' k
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.object_id = i.id
+        'DELETE k FROM '.prefixTable('sharekeys_fields').' k
+        LEFT JOIN ' . prefixTable('items').' i ON k.object_id = i.id
         WHERE i.id IS NULL'
     );
 
     // Delete all item logs for which no object exist
     DB::query(
-        'DELETE l FROM ' . prefixTable('log_items') . ' l
-        LEFT JOIN ' . prefixTable('items') . ' i ON k.id_item = i.id
+        'DELETE l FROM '.prefixTable('log_items').' l
+        LEFT JOIN ' . prefixTable('items').' i ON k.id_item = i.id
         WHERE i.id IS NULL'
     );
 

scripts/background_tasks___userKeysCreation.php

Spacing +13 added lines, -13 removed lines

@@ -69,7 +69,7 @@ 
 
 $processToPerform = DB::queryfirstrow(
     'SELECT *
-    FROM ' . prefixTable('background_tasks') . '
+    FROM ' . prefixTable('background_tasks').'
     WHERE (finished_at IS NULL OR finished_at = "") AND process_type = %s
     ORDER BY increment_id ASC',
     'create_user_keys'
@@ -115,7 +115,7 @@ 
             // Extract the subtask parameters
             $subTaskParams = json_decode($subTask['task'], true);
 
-            error_log('Subtask in progress: '.$subTask['increment_id']." (".$taskId.") - ".print_r($subTaskParams,true));
+            error_log('Subtask in progress: '.$subTask['increment_id']." (".$taskId.") - ".print_r($subTaskParams, true));
 /*
             $fichier = fopen(__DIR__.'/log.txt', 'a');
             fwrite($fichier, 'Step : '.$subTaskParams['step']." - index : ".$subTaskParams['index']."\n");
@@ -128,7 +128,7 @@ 
                     // Get total number of items
                     DB::query(
                         'SELECT *
-                        FROM ' . prefixTable('items') . '
+                        FROM ' . prefixTable('items').'
                         '.(isset($taskArgumentsArray['only_personal_items']) === true && $taskArgumentsArray['only_personal_items'] === 1 ? 'WHERE perso = 1' : '')
                     );
                     createAllSubTasks($subTaskParams['step'], DB::count(), $subTaskParams['nb'], $taskId);
@@ -137,7 +137,7 @@ 
                     // Get total number of items
                     DB::query(
                         'SELECT *
-                        FROM ' . prefixTable('log_items') . '
+                        FROM ' . prefixTable('log_items').'
                         WHERE raison LIKE "at_pw :%" AND encryption_type = "teampass_aes"'
                     );
                     createAllSubTasks($subTaskParams['step'], DB::count(), $subTaskParams['nb'], $taskId);
@@ -146,7 +146,7 @@ 
                     // Get total number of items
                     DB::query(
                         'SELECT *
-                        FROM ' . prefixTable('categories_items') . '
+                        FROM ' . prefixTable('categories_items').'
                         WHERE encryption_type = "teampass_aes"'
                     );
                     createAllSubTasks($subTaskParams['step'], DB::count(), $subTaskParams['nb'], $taskId);
@@ -163,9 +163,9 @@ 
                     // Get total number of items
                     DB::query(
                         'SELECT *
-                        FROM ' . prefixTable('files') . ' AS f
-                        INNER JOIN ' . prefixTable('items') . ' AS i ON i.id = f.id_item
-                        WHERE f.status = "' . TP_ENCRYPTION_NAME . '"'
+                        FROM ' . prefixTable('files').' AS f
+                        INNER JOIN ' . prefixTable('items').' AS i ON i.id = f.id_item
+                        WHERE f.status = "' . TP_ENCRYPTION_NAME.'"'
                     );
                     createAllSubTasks($subTaskParams['step'], DB::count(), $subTaskParams['nb'], $taskId);
                 }
@@ -192,7 +192,7 @@ 
     // Check if subtasks have to be created
     DB::query(
         'SELECT *
-        FROM ' . prefixTable('background_subtasks') . '
+        FROM ' . prefixTable('background_subtasks').'
         WHERE task_id = %i AND task LIKE %ss',
         $taskId,
         $action
@@ -224,7 +224,7 @@ 
 function countActiveSymfonyProcesses() {
     // Compter le nombre de processus actifs
     return DB::queryFirstField(
-        'SELECT COUNT(*) FROM ' . prefixTable('background_subtasks') . 
+        'SELECT COUNT(*) FROM '.prefixTable('background_subtasks'). 
         ' WHERE process_id IS NOT NULL AND finished_at IS NULL'
     );
 }
@@ -235,7 +235,7 @@ 
 function getSubTasks($taskId) {
     $task_to_perform = DB::query(
         'SELECT *
-        FROM ' . prefixTable('background_subtasks') . '
+        FROM ' . prefixTable('background_subtasks').'
         WHERE task_id = %i AND finished_at IS NULL
         ORDER BY increment_id ASC',
         $taskId
@@ -286,7 +286,7 @@ 
 function reloadSubTask($subTaskId) {
     // Récupérer les informations de la sous-tâche de la base de données
     $subTask = DB::queryFirstRow(
-        'SELECT * FROM ' . prefixTable('background_subtasks') . ' WHERE increment_id = %i', 
+        'SELECT * FROM '.prefixTable('background_subtasks').' WHERE increment_id = %i', 
         $subTaskId
     );
 
@@ -332,7 +332,7 @@ 
     // Get all processes
     $subtasks = DB::query(
         'SELECT *
-        FROM ' . prefixTable('background_subtasks') . '
+        FROM ' . prefixTable('background_subtasks').'
         WHERE process_id IS NOT NULL AND finished_at IS NULL'
     );
 

pages/api.php

Spacing +25 added lines, -25 removed lines

@@ -71,7 +71,7 @@ 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('api') === false) {
     // Not allowed page
     $session->set('system-error_code', ERR_NOT_ALLOWED);
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit;
 }
 
@@ -158,7 +158,7 @@ 
                                     <?php
                                     $rowsKeys = DB::query(
                                         'SELECT *
-                                        FROM ' . prefixTable('api') . '
+                                        FROM ' . prefixTable('api').'
                                         WHERE type = %s
                                         ORDER BY timestamp ASC',
                                         'key'
@@ -181,15 +181,15 @@ 
                                             <?php
                                             foreach ($rowsKeys as $key) {
                                                 echo '
-                                                    <tr data-id="' . $key['increment_id'] . '">
-                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-key" title="' . $lang->get('del_button') . '"></i></td>
-                                                    <td><span class="edit-api-key pointer">' . $key['label'] . '</span></td>
-                                                    <td>' . $key['value']. '</td>   
-                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="' . $key['increment_id'] . '"></i></td>                   
+                                                    <tr data-id="' . $key['increment_id'].'">
+                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-key" title="' . $lang->get('del_button').'"></i></td>
+                                                    <td><span class="edit-api-key pointer">' . $key['label'].'</span></td>
+                                                    <td>' . $key['value'].'</td>   
+                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="'.$key['increment_id'].'"></i></td>                   
                                                 </tr>';
                                             } ?>
                                         </tbody>
@@ -224,7 +224,7 @@ 
                                 <div class="col-12 mt-4" id="table-api-ip">
                                     <?php
                                     $rowsIps = DB::query(
-                                                'SELECT increment_id, label, timestamp value FROM ' . prefixTable('api') . '
+                                                'SELECT increment_id, label, timestamp value FROM '.prefixTable('api').'
                                                 WHERE type = %s
                                                 ORDER BY timestamp ASC',
                                                 'ip'
@@ -242,10 +242,10 @@ 
                                             <?php
                                             foreach ($rowsIps as $ip) {
                                                 echo '
-                                                <tr data-id="' . $ip['increment_id'] . '">
-                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-ip" title="' . $lang->get('del_button') . '"></i></td>
-                                                    <td><span class="edit-api-ip pointer" data-field="label">' . $ip['label'] . '</span></td>
-                                                    <td><span class="edit-api-ip pointer" data-field="value">' . $ip['value'] . '</span></td>
+                                                <tr data-id="' . $ip['increment_id'].'">
+                                                    <td width="50px"><i class="fas fa-trash infotip pointer delete-api-ip" title="' . $lang->get('del_button').'"></i></td>
+                                                    <td><span class="edit-api-ip pointer" data-field="label">' . $ip['label'].'</span></td>
+                                                    <td><span class="edit-api-ip pointer" data-field="value">' . $ip['value'].'</span></td>
                                                 </tr>';
                                             } ?>
                                         </tbody>
@@ -281,8 +281,8 @@ 
                                     <?php
                                     $rowsKeys = DB::query(
                                         'SELECT a.*, u.name, u.lastname, u.login
-                                        FROM ' . prefixTable('api') . ' AS a
-                                        INNER JOIN ' . prefixTable('users') . ' AS u ON a.user_id = u.id
+                                        FROM ' . prefixTable('api').' AS a
+                                        INNER JOIN ' . prefixTable('users').' AS u ON a.user_id = u.id
                                         WHERE a.type = %s
                                         ORDER BY u.login ASC',
                                         'user'
@@ -303,13 +303,13 @@ 
                                             <?php
                                             foreach ($rowsKeys as $key) {
                                                 echo '
-                                                    <tr data-id="' . $key['increment_id'] . '">
-                                                    <td>' . $key['name'] . ' ' . $key['lastname'] . ' (<i>'.$key['login'].'</i>)</td>
-                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="' . $key['increment_id'] . '"></i></td>
-                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="' . $key['increment_id'] . '"></i></td>
+                                                    <tr data-id="' . $key['increment_id'].'">
+                                                    <td>' . $key['name'].' '.$key['lastname'].' (<i>'.$key['login'].'</i>)</td>
+                                                    <td><i class="fas '.((int) $key['enabled'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="enabled" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_create'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_create" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_read'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_read" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_update'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_update" data-increment-id="'.$key['increment_id'].'"></i></td>
+                                                    <td><i class="fas '.((int) $key['allowed_to_delete'] === 1 ? 'fa-toggle-on text-info' : 'fa-toggle-off').' mr-1 text-center pointer api-clickme-action" data-field="allowed_to_delete" data-increment-id="'.$key['increment_id'].'"></i></td>
                                                 </tr>';
                                             } ?>
                                         </tbody>

pages/admin.php

Braces +1 added lines, -2 removed lines

@@ -224,8 +224,7 @@
                             </div>
         <?php
     }
-}
-catch (Exception $e) {
+} catch (Exception $e) {
     error_log('TEAMPASS Error - admin page - '.$e->getMessage());
     // deepcode ignore ServerLeak: no critical information is provided
     echo 'An error occurred. Please refer to server logs.';

Spacing +11 added lines, -11 removed lines

@@ -71,7 +71,7 @@ 
 if ($checkUserAccess->checkSession() === false || $checkUserAccess->userAccessPage('admin') === false) {
     // Not allowed page
     $session->set('system-error_code', ERR_NOT_ALLOWED);
-    include $SETTINGS['cpassman_dir'] . '/error.php';
+    include $SETTINGS['cpassman_dir'].'/error.php';
     exit;
 }
 
@@ -262,7 +262,7 @@ 
                     <div class="card-body">
                         <?php
                         // Display information about server
-                        $dbSize = DB::queryFirstRow("SELECT ROUND(SUM(data_length + index_length) / 1024 / 1024, 2) AS 'size' FROM information_schema.TABLES WHERE table_schema = '" . DB_NAME . "'");
+                        $dbSize = DB::queryFirstRow("SELECT ROUND(SUM(data_length + index_length) / 1024 / 1024, 2) AS 'size' FROM information_schema.TABLES WHERE table_schema = '".DB_NAME."'");
 
                         // Get OS
                         $uname = php_uname('s');
@@ -301,7 +301,7 @@ 
 
                         // Test internet access
                         $connected = @fsockopen("www.cloudflare.com", 443, $errno, $errstr, 1); // API Duo API (MFA).
-                        if ($connected){
+                        if ($connected) {
                             fclose($connected);
                             $internetAccess = '
                             <p>
@@ -318,17 +318,17 @@ 
                         }
 
                         echo 
-                        '<p>' . $os.
+                        '<p>'.$os.
                             '<br><span class="ml-4"></span>'.
                         '</p>'.
                         $internetAccess.
-                        '<p><i class="fa-brands fa-php mr-2"></i>PHP version: ' . phpversion().
+                        '<p><i class="fa-brands fa-php mr-2"></i>PHP version: '.phpversion().
                             '<br><span class="ml-4">Memory limit: '.(ini_get('memory_limit')).'</span>'.
                             '<br><span class="ml-4">Memory usage: '.formatSizeUnits(memory_get_usage()).'</span>'.
                             '<br><span class="ml-4">Maximum time execution: '.ini_get('max_execution_time').'</span>'.
                             '<br><span class="ml-4">Maximum file size upload: '.ini_get('upload_max_filesize').'</span>'.
                         '</p>'.
-                        '<p><i class="fa-solid fa-server mr-2"></i>Server version: ' . DB::serverVersion().
+                        '<p><i class="fa-solid fa-server mr-2"></i>Server version: '.DB::serverVersion().
                             '<br><span class="ml-4">Database size: '.($dbSize['size']).'MB</span>'.
                         '</p>';
 
@@ -336,11 +336,11 @@ 
                         $serverTime = localtime(time(), true);
                         echo '<div class="row">'.
                             '<div class="col-6"><i class="fa-solid fa-clock mr-2"></i>Server time:</div>'.
-                            '<div class="col-6"><span class="badge badge-info">' . 
-                            str_pad(strval($serverTime['tm_hour']), 2, "0", STR_PAD_LEFT) . ':' .
-                            str_pad(strval($serverTime['tm_min']), 2, "0", STR_PAD_LEFT) . ':' .
-                            str_pad(strval($serverTime['tm_sec']), 2, "0", STR_PAD_LEFT) .
-                            '</span></div>' .
+                            '<div class="col-6"><span class="badge badge-info">'. 
+                            str_pad(strval($serverTime['tm_hour']), 2, "0", STR_PAD_LEFT).':'.
+                            str_pad(strval($serverTime['tm_min']), 2, "0", STR_PAD_LEFT).':'.
+                            str_pad(strval($serverTime['tm_sec']), 2, "0", STR_PAD_LEFT).
+                            '</span></div>'.
                         '</div>'.
                         '<div class="row">'.
                             '<div class="col-6"><span class="ml-4">Timezone:</span></div>'.